From: Florian Weimer <fweimer@redhat.com>
To: libc-alpha@sourceware.org
Subject: [PATCH v2 06/32] elf: Remove version assert in check_match in elf/dl-lookup.c
Date: Fri, 07 Jul 2023 20:47:59 +0200 [thread overview]
Message-ID: <6abcd5145b4eb8a4fe7ee2a0640303c2906f8656.1688741159.git.fweimer@redhat.com> (raw)
In-Reply-To: <cover.1688741159.git.fweimer@redhat.com>
This case is detected early in the elf/dl-versionc.c consistency
checks. (These checks could be disabled in the future to allow
the removal of symbol versioning from objects.)
Commit f0b2132b35 ("ld.so: Support moving versioned symbols between
sonames [BZ #24741]) removed another call to _dl_name_match_p. The
_dl_check_caller function no longer exists, and the remaining calls
to _dl_name_match_p happen under the loader lock. This means that
atomic accesses are no longer required for the l_libname list. This
supersedes commit 395be7c218 ("elf: Fix data race in _dl_name_match_p
[BZ #21349]").
---
elf/dl-load.c | 18 +-----------------
elf/dl-lookup.c | 19 +++----------------
elf/dl-misc.c | 4 +---
3 files changed, 5 insertions(+), 36 deletions(-)
diff --git a/elf/dl-load.c b/elf/dl-load.c
index 58c5dc7355..9a9cee599d 100644
--- a/elf/dl-load.c
+++ b/elf/dl-load.c
@@ -439,23 +439,7 @@ add_name_to_object (struct link_map *l, const char *name)
newname->name = memcpy (newname + 1, name, name_len);
newname->next = NULL;
newname->dont_free = 0;
- /* CONCURRENCY NOTES:
-
- Make sure the initialization of newname happens before its address is
- read from the lastp->next store below.
-
- GL(dl_load_lock) is held here (and by other writers, e.g. dlclose), so
- readers of libname_list->next (e.g. _dl_check_caller or the reads above)
- can use that for synchronization, however the read in _dl_name_match_p
- may be executed without holding the lock during _dl_runtime_resolve
- (i.e. lazy symbol resolution when a function of library l is called).
-
- The release MO store below synchronizes with the acquire MO load in
- _dl_name_match_p. Other writes need to synchronize with that load too,
- however those happen either early when the process is single threaded
- (dl_main) or when the library is unloaded (dlclose) and the user has to
- synchronize library calls with unloading. */
- atomic_store_release (&lastp->next, newname);
+ lastp->next = newname;
}
/* Standard search directories. */
diff --git a/elf/dl-lookup.c b/elf/dl-lookup.c
index a8f48fed12..52decf616d 100644
--- a/elf/dl-lookup.c
+++ b/elf/dl-lookup.c
@@ -94,22 +94,9 @@ check_match (const char *const undef_name,
const ElfW(Half) *verstab = map->l_versyms;
if (version != NULL)
{
- if (__glibc_unlikely (verstab == NULL))
- {
- /* We need a versioned symbol but haven't found any. If
- this is the object which is referenced in the verneed
- entry it is a bug in the library since a symbol must
- not simply disappear.
-
- It would also be a bug in the object since it means that
- the list of required versions is incomplete and so the
- tests in dl-version.c haven't found a problem.*/
- assert (version->filename == NULL
- || ! _dl_name_match_p (version->filename, map));
-
- /* Otherwise we accept the symbol. */
- }
- else
+ /* If there is no version information, accept the symbol. This
+ can happen during symbol interposition. */
+ if (__glibc_likely (verstab != NULL))
{
/* We can match the version information or use the
default one if it is not hidden. */
diff --git a/elf/dl-misc.c b/elf/dl-misc.c
index 5b84adc2f4..e998083284 100644
--- a/elf/dl-misc.c
+++ b/elf/dl-misc.c
@@ -75,9 +75,7 @@ _dl_name_match_p (const char *name, const struct link_map *map)
if (strcmp (name, runp->name) == 0)
return 1;
else
- /* Synchronize with the release MO store in add_name_to_object.
- See CONCURRENCY NOTES in add_name_to_object in dl-load.c. */
- runp = atomic_load_acquire (&runp->next);
+ runp = runp->next;
return 0;
}
--
2.41.0
next prev parent reply other threads:[~2023-07-07 18:48 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-07 18:47 [PATCH v2 00/32] RELRO link maps Florian Weimer
2023-07-07 18:47 ` [PATCH v2 01/32] support: Add <support/memprobe.h> for protection flags probing Florian Weimer
2023-07-07 18:47 ` [PATCH v2 02/32] misc: Enable internal use of memory protection keys Florian Weimer
2023-07-07 18:47 ` [PATCH v2 03/32] elf: Remove _dl_sysdep_open_object hook function Florian Weimer
2023-07-07 18:47 ` [PATCH v2 04/32] elf: Eliminate second loop in find_version in dl-version.c Florian Weimer
2023-07-07 18:47 ` [PATCH v2 05/32] elf: In rtld_setup_main_map, assume ld.so has a DYNAMIC segment Florian Weimer
2023-07-07 18:47 ` Florian Weimer [this message]
2023-07-07 18:48 ` [PATCH v2 07/32] elf: Disambiguate some failures in _dl_load_cache_lookup Florian Weimer
2023-07-07 18:48 ` [PATCH v2 08/32] elf: Eliminate alloca in open_verify Florian Weimer
2023-07-07 18:48 ` [PATCH v2 09/32] Do not export <alloc_buffer.h> functions from libc Florian Weimer
2023-07-07 18:48 ` [PATCH v2 10/32] elf: Make <alloc_buffer.h> usable in ld.so Florian Weimer
2023-07-07 18:48 ` [PATCH v2 11/32] elf: Merge the three implementations of _dl_dst_substitute Florian Weimer
2023-07-07 18:48 ` [PATCH v2 12/32] elf: Move __rtld_malloc_init_stubs call into _dl_start_final Florian Weimer
2023-07-07 18:48 ` [PATCH v2 13/32] elf: Merge __dl_libc_freemem into __rtld_libc_freeres Florian Weimer
2023-07-07 18:48 ` [PATCH v2 14/32] elf: Use struct link_map_private for the internal link map Florian Weimer
2023-07-07 18:48 ` [PATCH v2 15/32] elf: Remove run-time-writable fields from struct link_map_private Florian Weimer
2023-07-07 18:48 ` [PATCH v2 16/32] elf: Move l_tls_offset into read-write part of link map Florian Weimer
2023-07-07 18:48 ` [PATCH v2 17/32] elf: Allocate auditor state after read-write " Florian Weimer
2023-07-07 18:48 ` [PATCH v2 18/32] elf: Move link map fields used by dependency sorting to writable part Florian Weimer
2023-07-07 18:48 ` [PATCH v2 19/32] elf: Split _dl_lookup_map, _dl_map_new_object from _dl_map_object Florian Weimer
2023-07-07 18:48 ` [PATCH v2 20/32] elf: Add l_soname accessor function for DT_SONAME values Florian Weimer
2023-07-07 18:49 ` [PATCH v2 21/32] elf: _dl_rtld_map should not exist in static builds Florian Weimer
2023-07-07 18:49 ` [PATCH v2 22/32] elf: Introduce GLPM accessor for the protected memory area Florian Weimer
2023-07-07 18:49 ` [PATCH v2 23/32] elf: Bootstrap allocation for future protected memory allocator Florian Weimer
2023-07-07 18:49 ` [PATCH v2 24/32] elf: Implement a basic " Florian Weimer
2023-07-07 18:49 ` [PATCH v2 25/32] elf: Move most of the _dl_find_object data to the protected heap Florian Weimer
2023-07-07 18:49 ` [PATCH v2 26/32] elf: Switch to a region-based protected memory allocator Florian Weimer
2023-07-07 18:49 ` [PATCH v2 27/32] elf: Determine the caller link map in _dl_open Florian Weimer
2023-07-07 18:49 ` [PATCH v2 28/32] elf: Add fast path to dlopen for fully-opened maps Florian Weimer
2023-07-07 18:49 ` [PATCH v2 29/32] elf: Use _dl_find_object instead of _dl_find_dso_for_object in dlopen Florian Weimer
2023-07-07 18:50 ` [PATCH v2 30/32] elf: Put critical _dl_find_object pointers into protected memory area Florian Weimer
2023-07-07 19:08 ` [PATCH v2 31/32] elf: Add hash tables to speed up DT_NEEDED, dlopen lookups Florian Weimer
2023-07-07 19:08 ` [PATCH v2 32/32] elf: Use memory protection keys for the protected memory allocator Florian Weimer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6abcd5145b4eb8a4fe7ee2a0640303c2906f8656.1688741159.git.fweimer@redhat.com \
--to=fweimer@redhat.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).