From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from camel.birch.relay.mailchannels.net (camel.birch.relay.mailchannels.net [23.83.209.29]) by sourceware.org (Postfix) with ESMTPS id 2DF5E3858012 for ; Mon, 13 Dec 2021 14:54:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 2DF5E3858012 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=gotplt.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gotplt.org X-Sender-Id: dreamhost|x-authsender|siddhesh@gotplt.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 76E01E067E; Mon, 13 Dec 2021 14:54:56 +0000 (UTC) Received: from pdx1-sub0-mail-a306.dreamhost.com (unknown [127.0.0.6]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id C732BE12C7; Mon, 13 Dec 2021 14:54:55 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|siddhesh@gotplt.org Received: from pdx1-sub0-mail-a306.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384) by 100.112.64.116 (trex/6.4.3); Mon, 13 Dec 2021 14:54:56 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|siddhesh@gotplt.org X-MailChannels-Auth-Id: dreamhost X-Reaction-Industry: 4f281c535527764b_1639407296097_1365031887 X-MC-Loop-Signature: 1639407296097:4186783802 X-MC-Ingress-Time: 1639407296097 Received: from [192.168.52.116] (unknown [223.185.62.238]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: siddhesh@gotplt.org) by pdx1-sub0-mail-a306.dreamhost.com (Postfix) with ESMTPSA id 4JCPgL1gHqz1F; Mon, 13 Dec 2021 06:54:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=gotplt.org; s=gotplt.org; t=1639407295; bh=2IpVYiv35thquSlZMVZESVnHVT8=; h=Date:Subject:To:Cc:From:Content-Type:Content-Transfer-Encoding; b=RWTB50cn5v3QwuNl7YfgKgoASQUgGndaCA7Xc2JJg4KSKapyaJ9qq9PTHslX3HMaL CYakr+PJ82CgCLMDuchNL4g8cfNxJN1uybtSNXk0HF9TYO7BRknamwlouLqI3UC9pw p9gm4gYXgS7mVL8CIFLerrkofBANKLEteJtG7Z+Q= Message-ID: <6af259d3-1123-5b5a-fe2b-7207d48e46af@gotplt.org> Date: Mon, 13 Dec 2021 20:24:50 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.1.0 Subject: Re: [PATCH] Fix glibc 2.34 ABI omission (missing GLIBC_2.34 in dynamic loader) Content-Language: en-US To: Florian Weimer Cc: libc-alpha@sourceware.org References: <87h7bjmnt0.fsf@oldenburg.str.redhat.com> <026b3d7a-7de3-3f7e-d59e-85fe7514eb54@gotplt.org> <874k7c1z20.fsf@oldenburg.str.redhat.com> From: Siddhesh Poyarekar In-Reply-To: <874k7c1z20.fsf@oldenburg.str.redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3031.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, URIBL_BLACK autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 Dec 2021 14:55:03 -0000 On 12/13/21 17:45, Florian Weimer wrote: > It's only possible to move symbols if version nodes exist on both > sides. Therefore, this patch adds a version node to ld.so. Could we enforce via a test that both libc.so and ld.so always have the same version nodes? That'll give us future flexibility at the cost of the extra few bytes. > Without the version node, a binary linked against newer glibc will start > referencing GLIBC_2.34 in ld.so after a symbol move to ld.so. The lazy Would it contain a reference to ld.so though? IIRC, the symbol/version checks don't care about the DSO in which they are found. So in old glibc, it should resolve to pthread_key_create@GLIBC_2.34 in libc.so.6 and in newer glibc it should resolve to pthread_key_create@GLIBC_2.34 in ld.so. Siddhesh