public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Patrick McGehearty <patrick.mcgehearty@oracle.com>
To: DJ Delorie <dj@redhat.com>
Cc: libc-alpha@sourceware.org
Subject: Re: [PATCH v2] Remove upper limit on tunable MALLOC_MMAP_THRESHOLD
Date: Tue, 7 Dec 2021 13:51:01 -0600	[thread overview]
Message-ID: <6baba8a1-99da-bea4-ab51-ea77ba1946a9@oracle.com> (raw)
In-Reply-To: <xntufuitho.fsf@greed.delorie.com>

DJ, does your final comments mean this patch is
OK to commit?

I should say that I intend to also change HEAP_MAX to be
a tunable to handle the issues we discussed as a separate
patch. It does not look to be time consuming. I just
can't predict when I'll have it ready because it's behind
a couple of other things in my task list and I can't
predict what new work tasks might cause further delays.

- patrick

On 11/29/2021 2:42 PM, DJ Delorie wrote:
> Ok, based on all that, I think it's safe to increase the threshold -
> although, given your description, setting it bigger than the mmap'd heap
> size will still be kinda pointless in multi-threaded programs.  Safe,
> but pointless.
>
> I wonder if any of these details or caveats need to be documented,
> either in the code or the manual...
>


  parent reply	other threads:[~2021-12-07 19:51 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-01 21:48 Patrick McGehearty
2021-11-02  0:27 ` DJ Delorie
2021-11-09 22:33   ` Patrick McGehearty
2021-11-10  0:36     ` DJ Delorie
2021-11-25  0:52       ` Patrick McGehearty
2021-11-29 20:42         ` DJ Delorie
2021-11-29 21:35           ` Patrick McGehearty
2021-12-07 19:51           ` Patrick McGehearty [this message]
2021-12-07 20:35             ` DJ Delorie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6baba8a1-99da-bea4-ab51-ea77ba1946a9@oracle.com \
    --to=patrick.mcgehearty@oracle.com \
    --cc=dj@redhat.com \
    --cc=libc-alpha@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).