From: Paul E Murphy <murphyp@linux.ibm.com>
To: Adhemerval Zanella Netto <adhemerval.zanella@linaro.org>,
Rajalakshmi Srinivasaraghavan <rajis@linux.ibm.com>,
libc-alpha@sourceware.org
Subject: Re: [PATCH] powerpc64: Remove old strncmp optimization
Date: Thu, 1 Dec 2022 14:26:52 -0600 [thread overview]
Message-ID: <6bb448ff-c0e8-14c5-2621-000b8d3e20d3@linux.ibm.com> (raw)
In-Reply-To: <34bc5a63-b4a6-caac-4091-534982646577@linaro.org>
On 11/30/22 7:49 AM, Adhemerval Zanella Netto wrote:
>
>
> On 29/11/22 19:37, Paul E Murphy via Libc-alpha wrote:
>>
>>
>> On 11/29/22 10:02 AM, Rajalakshmi Srinivasaraghavan via Libc-alpha wrote:
>>> This patch removes the power4 strncmp optimization for powerpc64 and uses
>>> __strncmp_ppc implementation instead. Currently, both power4 and ppc
>>> IFUNC variants result in similar performance.
>> What cpu was used to test performance? I'd be curious if this holds for something like the venerable ppc970.
>
>
> Do we really care, specially because I am not sure how it was evaluated on
> power4 chip?
On the merits of performance, I don't think this is sufficient
justification. We should be more detailed.
If the justification is tidying up, this patch is OK. That should be
made explicit in the commit message.
It does make me wonder, when is it OK to drop cpu specific
optimizations? I suspect there aren't many running a modern BE ppc
distro with P7 or older.
next prev parent reply other threads:[~2022-12-01 20:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-29 16:02 Rajalakshmi Srinivasaraghavan
2022-11-29 22:37 ` Paul E Murphy
2022-11-30 13:49 ` Adhemerval Zanella Netto
2022-12-01 20:26 ` Paul E Murphy [this message]
2022-11-30 16:50 ` Rajalakshmi Srinivasaraghavan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6bb448ff-c0e8-14c5-2621-000b8d3e20d3@linux.ibm.com \
--to=murphyp@linux.ibm.com \
--cc=adhemerval.zanella@linaro.org \
--cc=libc-alpha@sourceware.org \
--cc=rajis@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).