From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 118815 invoked by alias); 18 May 2017 19:15:44 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 118680 invoked by uid 89); 18 May 2017 19:15:35 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:588, H*M:30e8 X-HELO: mx1.redhat.com DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com CE11C3B716 Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=fweimer@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com CE11C3B716 Subject: Re: [PATCH] Tests for res_init To: Siddhesh Poyarekar , GNU C Library References: <2b4fc76e-e756-e4e4-11ca-829a03cf84bb@redhat.com> <43792192-037e-6c6f-3988-11755e30c2c7@gotplt.org> <3665dcaf-a362-ee61-1db8-a0cd84b717ac@redhat.com> From: Florian Weimer Message-ID: <6bca5109-9c16-fcaa-30e8-f59f34a173a8@redhat.com> Date: Thu, 18 May 2017 19:15:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-05/txt/msg00550.txt.bz2 On 05/18/2017 09:09 PM, Siddhesh Poyarekar wrote: > On Friday 19 May 2017 12:07 AM, Florian Weimer wrote: >> I can make this clearer in the comment. The test currently contains the >> wrong expected output, as a remainder to update the bug when this is fixed. > > Oh no, that would be worse I think, much better to not have it in there > and add it with the fix than have it in there with the wrong expected > output. I don't have a strong opinion on this matter. I'll remove the test. Do you have any comments on the rest of the patch? Thanks, Florian