From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by sourceware.org (Postfix) with ESMTPS id EBB173858D33 for ; Tue, 28 Feb 2023 12:44:31 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org EBB173858D33 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=linux.ibm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linux.ibm.com Received: from pps.filterd (m0098399.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 31SAuQO7003882 for ; Tue, 28 Feb 2023 12:44:31 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : date : subject : to : references : from : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pp1; bh=KJYrBtTxMVzq2khOcpcbhoQRQMngHjZyixLP19s2sbk=; b=Mho90ZCTz6sXnlbXzV7FMCca/9CvDNpatsL4Hvj0PMe7jbUn75rM4VSuetbqSg5GkBDD L8aIuG1po07BIVtccs0U2b1ffObsB1RDxEM0ggHwzFQ8y8puy+3ZxqXPji8kNSdKFPs0 MF58PxH5MsYOLu3V+dFssQ8YJhxoegFGzZzeLpCkQn28dnVKThVH91p0RhnOpLS8JIZO 6ucnUMn8l4pnmic2mKFweQ3zv8zsn6GxnhIFMxXRrr/SAMTCEJNoLCDDb+bqcQ5wvL4B /zKz4nYLe/KjQ/bCTdB63EKOtzX6n0t6FqQzSy0qGQxfAKjwO08hdMOLgO+7kF34RBsj cQ== Received: from ppma03fra.de.ibm.com (6b.4a.5195.ip4.static.sl-reverse.com [149.81.74.107]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3p1ga5tmmu-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Tue, 28 Feb 2023 12:44:30 +0000 Received: from pps.filterd (ppma03fra.de.ibm.com [127.0.0.1]) by ppma03fra.de.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 31SBMEaO032590 for ; Tue, 28 Feb 2023 12:44:28 GMT Received: from smtprelay05.fra02v.mail.ibm.com ([9.218.2.225]) by ppma03fra.de.ibm.com (PPS) with ESMTPS id 3nybbdj79e-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Tue, 28 Feb 2023 12:44:28 +0000 Received: from smtpav04.fra02v.mail.ibm.com (smtpav04.fra02v.mail.ibm.com [10.20.54.103]) by smtprelay05.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 31SCiQ4047645166 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Tue, 28 Feb 2023 12:44:26 GMT Received: from smtpav04.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id E606E20043 for ; Tue, 28 Feb 2023 12:44:25 +0000 (GMT) Received: from smtpav04.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id BE93320040 for ; Tue, 28 Feb 2023 12:44:25 +0000 (GMT) Received: from [9.171.18.26] (unknown [9.171.18.26]) by smtpav04.fra02v.mail.ibm.com (Postfix) with ESMTP for ; Tue, 28 Feb 2023 12:44:25 +0000 (GMT) Message-ID: <6bd28e12-8a84-26bc-c036-37deeb569dd4@linux.ibm.com> Date: Tue, 28 Feb 2023 13:44:25 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: Fix ifunc-impl-list.c build for s390 Content-Language: en-US To: libc-alpha@sourceware.org References: <4e5aeda7-899e-5bc6-b2d-c9e2359f4e3@codesourcery.com> <9e8a1491-e778-674c-5d4f-71f473e2aa53@linux.ibm.com> From: Stefan Liebler In-Reply-To: <9e8a1491-e778-674c-5d4f-71f473e2aa53@linux.ibm.com> Content-Type: text/plain; charset=UTF-8 X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: VLwO6jT5Ec1yDi2ypMV_vnCY7Kg-P65A X-Proofpoint-GUID: VLwO6jT5Ec1yDi2ypMV_vnCY7Kg-P65A Content-Transfer-Encoding: 8bit X-Proofpoint-UnRewURL: 0 URL was un-rewritten MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.219,Aquarius:18.0.930,Hydra:6.0.573,FMLib:17.11.170.22 definitions=2023-02-28_08,2023-02-28_02,2023-02-09_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 suspectscore=0 phishscore=0 malwarescore=0 spamscore=0 lowpriorityscore=0 clxscore=1015 mlxscore=0 bulkscore=0 impostorscore=0 mlxlogscore=496 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000 definitions=main-2302280101 X-Spam-Status: No, score=-4.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,KAM_NUMSUBJECT,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 17.02.23 14:46, Stefan Liebler via Libc-alpha wrote: >> Note: s390x-linux-gnu-O3 started failing with a different error >> earlier; that problem may still need to be fixed after this fix is in. >> >> https://sourceware.org/pipermail/libc-testresults/2023q1/010829.html >> > I will have a look. Independently I've recognized a fail on x86_64/s390x > with -O3 starting with commit 32c7acd46401530fdbd4e98508c9baaa705f8b53 > "Replace rawmemchr (s, '\0') with strchr": > In function ‘nis_local_host’, > inlined from ‘nis_local_host’ at nis_local_names.c:147:1: > nis_local_names.c:171:11: error: ‘strncpy’ output may be truncated > copying between 0 and 1023 bytes from a string of length 1024 > [-Werror=stringop-truncation] > 171 | strncpy (cp, nis_local_directory (), NIS_MAXNAMELEN - > len -1); > > But so far I had no further time to look into it. Hi Joseph, I've posted a patch to fix the earlier error with -O3. The same error is also observable with x86_64 -O3, but s390x is the only architecture in the build-many-script which also builds with -O3 as gcc tends to inline more than on other architectures. Please have a look here: [PATCH] nis: Fix stringop-truncation warning with -O3 in nis_local_host. https://sourceware.org/pipermail/libc-alpha/2023-February/145923.html