public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Siddhesh Poyarekar <siddhesh@gotplt.org>
To: "Никита Попов" <npv1310@gmail.com>
Cc: libc-alpha@sourceware.org
Subject: Re: [PATCH] librt: add test (bug 28213)
Date: Fri, 13 Aug 2021 09:17:38 +0530	[thread overview]
Message-ID: <6be85eac-1b1c-06c3-66e7-47974206b02d@gotplt.org> (raw)
In-Reply-To: <CA+cA0PBptDd-Ug43CN1sy9VXtOheMw5Y-fTnFWamnG7tvax74Q@mail.gmail.com>

On 8/13/21 8:58 AM, Никита Попов wrote:
> Hello. I have some concerns about the recent commit
> 4cc79c217744743077bf7a0ec5e0a4318f1e6641. In rt/tst-bz28213.c we use
> one call to pause (). Should it return for some reason 'return 0' from
> do_test () follows. Maybe it is better to wrap pause () call here into
> an infinite loop like this? [while (1) pause ();] Then we can be sure
> that the only success in this test can be reached via exit (0) from
> the callback function.

The only way pause() can return is through a signal handler.  The only 
signal we handle in this test is SIGALRM (in the test driver for test 
timeout) and it results in a test failure.  All other signals will 
result in immediate process termination, which will also result in a 
test failure.

Siddhesh

      reply	other threads:[~2021-08-13  3:47 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-11 11:26 Никита Попов
2021-08-12  3:10 ` Никита Попов
2021-08-12  4:18 ` Siddhesh Poyarekar
2021-08-12  9:00   ` Никита Попов
2021-08-12  9:34     ` Siddhesh Poyarekar
2021-08-12 10:20       ` Никита Попов
2021-08-13  3:28         ` Никита Попов
2021-08-13  3:47           ` Siddhesh Poyarekar [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6be85eac-1b1c-06c3-66e7-47974206b02d@gotplt.org \
    --to=siddhesh@gotplt.org \
    --cc=libc-alpha@sourceware.org \
    --cc=npv1310@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).