From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from donkey.elm.relay.mailchannels.net (donkey.elm.relay.mailchannels.net [23.83.212.49]) by sourceware.org (Postfix) with ESMTPS id 41DDE3886C74 for ; Fri, 13 Aug 2021 03:47:48 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 41DDE3886C74 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=gotplt.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gotplt.org X-Sender-Id: dreamhost|x-authsender|siddhesh@gotplt.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id B40131E26D9; Fri, 13 Aug 2021 03:47:46 +0000 (UTC) Received: from pdx1-sub0-mail-a89.g.dreamhost.com (100-96-16-111.trex-nlb.outbound.svc.cluster.local [100.96.16.111]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 0C77B1E26B3; Fri, 13 Aug 2021 03:47:46 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|siddhesh@gotplt.org Received: from pdx1-sub0-mail-a89.g.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384) by 100.96.16.111 (trex/6.3.3); Fri, 13 Aug 2021 03:47:46 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|siddhesh@gotplt.org X-MailChannels-Auth-Id: dreamhost X-Ruddy-Robust: 1cac16d33b999955_1628826466271_2264868442 X-MC-Loop-Signature: 1628826466271:3215018867 X-MC-Ingress-Time: 1628826466271 Received: from pdx1-sub0-mail-a89.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a89.g.dreamhost.com (Postfix) with ESMTP id 8F4F27EFDF; Thu, 12 Aug 2021 20:47:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gotplt.org; h=subject:to :cc:references:from:message-id:date:mime-version:in-reply-to :content-type:content-transfer-encoding; s=gotplt.org; bh=tsuKNM 6vWDNqHMb2noQskaqpuM4=; b=i+ZcelOV6T5P5EA2PahF3gk42Wle0HDpfhZG9P XrfD7vzYkGGHOV9sLlixPUDjsA4kBbYB2vCBA8cFvNEYT8QLmo2fcnKNBAzYzoX7 OIqYzhcgPW7i2qpEmBHEIOqzKdFDwYYuzb65qSmZuQ9zwh8KYVuovrUgzi1nCVRH C4LRo= Received: from [192.168.1.159] (unknown [1.186.101.110]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: siddhesh@gotplt.org) by pdx1-sub0-mail-a89.g.dreamhost.com (Postfix) with ESMTPSA id 8002A7EFE3; Thu, 12 Aug 2021 20:47:43 -0700 (PDT) Subject: Re: [PATCH] librt: add test (bug 28213) To: =?UTF-8?B?0J3QuNC60LjRgtCwINCf0L7Qv9C+0LI=?= Cc: libc-alpha@sourceware.org References: <7aafeb13-18ac-e211-bdb8-84ee3c1fe76b@gotplt.org> X-DH-BACKEND: pdx1-sub0-mail-a89 From: Siddhesh Poyarekar Message-ID: <6be85eac-1b1c-06c3-66e7-47974206b02d@gotplt.org> Date: Fri, 13 Aug 2021 09:17:38 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-3027.7 required=5.0 tests=BAYES_00, BODY_8BITS, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 Aug 2021 03:47:58 -0000 On 8/13/21 8:58 AM, =D0=9D=D0=B8=D0=BA=D0=B8=D1=82=D0=B0 =D0=9F=D0=BE=D0=BF= =D0=BE=D0=B2 wrote: > Hello. I have some concerns about the recent commit > 4cc79c217744743077bf7a0ec5e0a4318f1e6641. In rt/tst-bz28213.c we use > one call to pause (). Should it return for some reason 'return 0' from > do_test () follows. Maybe it is better to wrap pause () call here into > an infinite loop like this? [while (1) pause ();] Then we can be sure > that the only success in this test can be reached via exit (0) from > the callback function. The only way pause() can return is through a signal handler. The only=20 signal we handle in this test is SIGALRM (in the test driver for test=20 timeout) and it results in a test failure. All other signals will=20 result in immediate process termination, which will also result in a=20 test failure. Siddhesh