From: Paul Eggert <eggert@cs.ucla.edu>
To: Florian Weimer <fweimer@redhat.com>,
Adhemerval Zanella <adhemerval.zanella@linaro.org>,
libc-alpha@sourceware.org
Subject: Re: [PATCH] libio: Add small optimization on fmemopen
Date: Wed, 21 Sep 2016 18:57:00 -0000 [thread overview]
Message-ID: <6beed9ba-f675-4860-9070-76b7afa31654@cs.ucla.edu> (raw)
In-Reply-To: <f1657343-a97b-78d6-c941-2fd65c733b64@redhat.com>
On 09/21/2016 11:47 AM, Florian Weimer wrote:
> We don't know the nature of the GCC issue, so we cannot work around it
> reliably. The most likely explanation is that Address Sanitizer does
> not account for a valid GCC optimization.
That's not the sense that I get from looking at Bug 66661. GCC is
assuming it can do an aligned word load of the trailing bytes of a
flexible array member in a properly-aligned structure. This assumption
is something we can easily work around reliably, e.g., with the patch I
suggested. Although the followups to Bug 66661 suggest that there may be
further problems with overaligned structures, the code here is not using
_Alignas so these further problems are not an issue here.
next prev parent reply other threads:[~2016-09-21 18:57 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-21 14:06 Adhemerval Zanella
2016-09-21 14:57 ` Florian Weimer
2016-09-21 18:18 ` Adhemerval Zanella
2016-09-21 17:22 ` Paul Eggert
2016-09-21 18:17 ` Adhemerval Zanella
2016-09-21 18:23 ` Florian Weimer
2016-09-21 18:26 ` Adhemerval Zanella
2016-09-21 18:43 ` Paul Eggert
2016-09-21 18:47 ` Florian Weimer
2016-09-21 18:57 ` Paul Eggert [this message]
2016-09-21 19:27 ` Florian Weimer
2016-09-21 20:16 ` Adhemerval Zanella
2016-09-21 20:42 ` Paul Eggert
2016-09-23 5:17 ` Ondřej Bílka
2016-09-23 5:34 ` Florian Weimer
2016-09-23 18:14 ` Ondřej Bílka
2016-09-23 20:38 ` Florian Weimer
2016-09-23 18:29 ` Paul Eggert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6beed9ba-f675-4860-9070-76b7afa31654@cs.ucla.edu \
--to=eggert@cs.ucla.edu \
--cc=adhemerval.zanella@linaro.org \
--cc=fweimer@redhat.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).