From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oa1-x33.google.com (mail-oa1-x33.google.com [IPv6:2001:4860:4864:20::33]) by sourceware.org (Postfix) with ESMTPS id 3CF6E388EFA9 for ; Thu, 8 Dec 2022 17:08:56 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 3CF6E388EFA9 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-oa1-x33.google.com with SMTP id 586e51a60fabf-144bd860fdbso2582552fac.0 for ; Thu, 08 Dec 2022 09:08:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:organization:from:references :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Xes1rLlBE0B3yjsnf4DbERtBp2+mHuDH6H5+0ntyoWo=; b=uWfCDk32M2zqIz8oB3wXf/BgQR49KhCKDcyESu5piT+B9qgsv1NosJa3Pa4BaVS59w 3ts74KaAzl7KM2UbrJLws2pFbMbRtH5ZJa2rSyAGRAVhIvEZLJQ64a+7xxnN6kNUhjD9 CcUpKPX2SAOO/ttISW4WpC/85hxn/znfjQh+KSRdxqbRmcUWja/BjmhcDHpVKPkEBAXz jtRStZ0vcqqbyWU9duoZDFpxdZMRfC/AqOj1SRGopbBerhuEMAQyyIqS2ogK+RELpirK CyX64Yymq0sLzPSRUE5XK9rxV69glxxQzrrI2dgFJN0XcqwhMn5NrlYma2EHBKUUpEaf SxWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Xes1rLlBE0B3yjsnf4DbERtBp2+mHuDH6H5+0ntyoWo=; b=42Wy0P1/dK5rim4H2qsOoXaIOJorrJGueEggqP4/s7nNADDXq9hAyhUJosDCbJMzcg J9L+6V7/wCuJakYfJiimikJTXdqjM7WJSZsb76UUoMnvwOggUWAjQSoy5ub/GdUJk1BG sSxgpQpn1cBGqBbN+jAzhidzqKe0TlN37/0IkaSDOPCWzDhdhAFmvvffdWAvHUjmwShe BDGviWFvZOKIM0TGoWorvQkj+oX1EGvs7qg59iPGQ9gtjrGdaOUPaeeOhP4gjL/fQ5ap 6YurveytKcQN1nFZPiMqy2D3F4YGIRwQgMoOgB+ghO0njcTtjqI96CykcBGNkPnMyK8h LJbg== X-Gm-Message-State: ANoB5ple/0KE2w6oGFsbPRznWUT+uQcBxXRebyAHxNDpaAGFnusmdHBa Jl0hQt4fFaS4MmfPbsya0XcHJH1GC7gSK9bUU3Y= X-Google-Smtp-Source: AA0mqf47uvv6qwOcl0M58QNdMZDB74Ek5v+B54ihq26RGCr/WvAYs4Bbykdt137oX9rfCKtWXh8CzA== X-Received: by 2002:a05:6870:c688:b0:144:f2f6:c212 with SMTP id cv8-20020a056870c68800b00144f2f6c212mr1511461oab.278.1670519335168; Thu, 08 Dec 2022 09:08:55 -0800 (PST) Received: from ?IPV6:2804:1b3:a7c2:6793:d83e:e871:6162:c8c0? ([2804:1b3:a7c2:6793:d83e:e871:6162:c8c0]) by smtp.gmail.com with ESMTPSA id w82-20020acadf55000000b00342eade43d4sm10776379oig.13.2022.12.08.09.08.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 08 Dec 2022 09:08:54 -0800 (PST) Message-ID: <6c3d6c35-69e3-4d2b-2e91-011b160df37f@linaro.org> Date: Thu, 8 Dec 2022 14:08:52 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Subject: Re: [PATCH v2] : Make fopencookie, vasprintf, asprintf available by default Content-Language: en-US To: Florian Weimer , libc-alpha@sourceware.org References: <87fse82w0d.fsf@oldenburg.str.redhat.com> From: Adhemerval Zanella Netto Organization: Linaro In-Reply-To: <87fse82w0d.fsf@oldenburg.str.redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-13.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 24/11/22 12:49, Florian Weimer via Libc-alpha wrote: > FreeBSD makes these functions available by default, so we should > not treat them as GNU-specific and restrict them to _GNU_SOURCE. > LGTM, thanks. Reviewed-by: Adhemerval Zanella > --- > v2: Do not include fcloseall because it's broken. > > libio/stdio.h | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/libio/stdio.h b/libio/stdio.h > index 0e0f16b464..10af6d9b60 100644 > --- a/libio/stdio.h > +++ b/libio/stdio.h > @@ -42,7 +42,7 @@ __BEGIN_DECLS > #include > #include > > -#ifdef __USE_GNU > +#ifdef __USE_MISC > # include > #endif > > @@ -294,7 +294,7 @@ extern FILE *fdopen (int __fd, const char *__modes) __THROW > __attribute_malloc__ __attr_dealloc_fclose __wur; > #endif > > -#ifdef __USE_GNU > +#ifdef __USE_MISC > /* Create a new stream that refers to the given magic cookie, > and uses the given functions for input and output. */ > extern FILE *fopencookie (void *__restrict __magic_cookie, > @@ -384,7 +384,7 @@ extern int vsnprintf (char *__restrict __s, size_t __maxlen, > __THROWNL __attribute__ ((__format__ (__printf__, 3, 0))); > #endif > > -#if __GLIBC_USE (LIB_EXT2) > +#if defined (__USE_MISC) || __GLIBC_USE (LIB_EXT2) > /* Write formatted output to a string dynamically allocated with `malloc'. > Store the address of the string in *PTR. */ > extern int vasprintf (char **__restrict __ptr, const char *__restrict __f, > > base-commit: 5bb4b51a76cc9bec72f67f702b5bf2fce30f0f7c >