Re: [PATCH v2 4/4] malloc: Add Huge Page support for sysmalloc

[Adhemerval Zanella <adhemerval.zanella@linaro.org>]

On 19/08/2021 14:58, Matheus Castanho wrote:
> Hi Adhemerval,
> 
> I tested this patchset on a POWER9, and I'm seeing the following test
> failures when running make check with glibc.malloc.mmap_hugetlb=1:

Thanks for checking on this.

> 
> malloc/tst-free-errno
> malloc/tst-free-errno-malloc-check
> malloc/tst-free-errno-mcheck

These one I couldn't really reproduce it on gcc farm power machines,
a power9 with 2M huge page default and power8 with 16M default. Both
didn't have any page allocated in the poll. I don't have admin access
so I can change the pool size to check what is happening.

I also tested on my x86_64 environment without any pages in the poll,
with 4 pages in the pool and with 10 pages.  

If you could the stacktrace from where we get the
"Didn't expect signal from child: got `Aborted'" it would be useful.

It could be also something related to /proc/sys/vm/max_map_count
value, since it mmap seems to be failing for some reason.

> posix/tst-exec
> posix/tst-exec-static
> posix/tst-spawn
> posix/tst-spawn-static
> posix/tst-spawn5

These are an overlook at 'malloc_default_hugepage_size()' where it
does not close the file descriptor on success.  I have fixed it.