From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg1-x533.google.com (mail-pg1-x533.google.com [IPv6:2607:f8b0:4864:20::533]) by sourceware.org (Postfix) with ESMTPS id 9CBD5385482F for ; Thu, 19 Aug 2021 18:50:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 9CBD5385482F Received: by mail-pg1-x533.google.com with SMTP id o2so6751077pgr.9 for ; Thu, 19 Aug 2021 11:50:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=/GqnlpB2Hn/G4c1GZf8IBkY0g3bZcOvg2xV5Gv8jp4I=; b=H+2C5ZbtPEaaDo6TYIMCV6dWAnEEOtlA/1bQoB1q0X9sDSS50cktgVeEf27QgaFi1M oe7SdKIAQr4BbLefbx566o8locA7kdt8EjqMR+44DgxZIHMgc2+RRE+zybW/rbrENs2G XOivS2LmRD1+K56lzWjkKPTeEgUn/QR6v7RSm/cGyrxYqg4uHqjsvFqJ3IB4UyMSHd7Y Ic/4OPDu0iTJtYVlAZP8iiHI6xEcGl5nVizcbIB0+nfm+XDwAkFIngLeOSnZpwJWab1+ Yeogo76Tc6D3g6T8AvJMQ/Y5f76wouqgPo4bgpdTem03mJ9Wf+IFlnwU7YXYjJ4hbMFm h0eQ== X-Gm-Message-State: AOAM530plnM9FfAWBrLGsEKmX8XrHrqiRRImyyuLAOTSGcERstnX2sqK 0OCSpt6gTaLJw3dMNbJhPiGOEC3gbv6hJw== X-Google-Smtp-Source: ABdhPJzSgYUvob5GbYdxMCgUFZGvtmUHsGVNLoY2yTTVKUfEWN9ibWjAoPNav3XFI4YHZvD7w4pk8A== X-Received: by 2002:a05:6a00:23ca:b0:3e1:2d8:33f3 with SMTP id g10-20020a056a0023ca00b003e102d833f3mr16185277pfc.42.1629399031719; Thu, 19 Aug 2021 11:50:31 -0700 (PDT) Received: from ?IPv6:2804:431:c7ca:cd83:aa1a:7bd:9935:9bba? ([2804:431:c7ca:cd83:aa1a:7bd:9935:9bba]) by smtp.gmail.com with ESMTPSA id 65sm4845514pgi.12.2021.08.19.11.50.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 19 Aug 2021 11:50:31 -0700 (PDT) Subject: Re: [PATCH v2 4/4] malloc: Add Huge Page support for sysmalloc To: Matheus Castanho Cc: Norbert Manthey , Guillaume Morin , Siddhesh Poyarekar , libc-alpha@sourceware.org, Tulio Magno Quites Machado Filho References: <20210818142000.128752-1-adhemerval.zanella@linaro.org> <20210818142000.128752-5-adhemerval.zanella@linaro.org> <871r6pjp03.fsf@linux.ibm.com> From: Adhemerval Zanella Message-ID: <6c46a3ab-3031-5729-6160-d13cca1899cb@linaro.org> Date: Thu, 19 Aug 2021 15:50:28 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <871r6pjp03.fsf@linux.ibm.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Aug 2021 18:50:43 -0000 On 19/08/2021 14:58, Matheus Castanho wrote: > Hi Adhemerval, > > I tested this patchset on a POWER9, and I'm seeing the following test > failures when running make check with glibc.malloc.mmap_hugetlb=1: Thanks for checking on this. > > malloc/tst-free-errno > malloc/tst-free-errno-malloc-check > malloc/tst-free-errno-mcheck These one I couldn't really reproduce it on gcc farm power machines, a power9 with 2M huge page default and power8 with 16M default. Both didn't have any page allocated in the poll. I don't have admin access so I can change the pool size to check what is happening. I also tested on my x86_64 environment without any pages in the poll, with 4 pages in the pool and with 10 pages. If you could the stacktrace from where we get the "Didn't expect signal from child: got `Aborted'" it would be useful. It could be also something related to /proc/sys/vm/max_map_count value, since it mmap seems to be failing for some reason. > posix/tst-exec > posix/tst-exec-static > posix/tst-spawn > posix/tst-spawn-static > posix/tst-spawn5 These are an overlook at 'malloc_default_hugepage_size()' where it does not close the file descriptor on success. I have fixed it.