public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Paul Eggert <eggert@cs.ucla.edu>
To: Albert ARIBAUD <albert.aribaud@3adev.fr>
Cc: libc-alpha@sourceware.org
Subject: Re: [PATCH 1/1] Y2038: add function __difftime64
Date: Mon, 25 Jun 2018 23:56:00 -0000	[thread overview]
Message-ID: <6c6c0111-572d-538a-e9e7-26b43b44d6c4@cs.ucla.edu> (raw)
In-Reply-To: <20180626003245.023eb716@athena>

On 06/25/2018 03:32 PM, Albert ARIBAUD wrote:
> I replaced the original 32-bit difftime with a wrapper
> around the 64-bit time; and in both cases, there were two functions, on
> for each time size.

Yes, and all this is in the patch you posted in 
<https://www.sourceware.org/ml/libc-alpha/2018-06/msg00605.html>. What 
I'm not understanding is how the functions it defines (__difftime64 and 
__difftime on 32-bit hosts, and just __difftime on 64-bit hosts) 
interoperate the with user-defined macro (is it still _TIME_BITS? I 
can't recall) that specifies whether the user wants time_t is 64 or 32 
bits, and how they interoperate with the macro that Joseph Myers 
suggested was needed by the system to say whether a 32-bit time_t 
variant is supported.

In short, I'm still missing the bigger picture here.

> Since you want the changes in gnulib first, then I suspect I should
> provide branches above gnulib as well as above glibc? If so, what
> would you recommend as a good source on setting up a build and test
> setup for gnulib, similar to build-many-glibcs.py is for glibc?
>

Yes, it would be helpful to have this in Gnulib too. The basic idea is 
that Gnulib and glibc sources should be as close to each other as 
possible; preferably identical. You can build and test a Gnulib module 
by running './gnulib-tool --test modulename'; run './gnulib-tool --help' 
for more.

  reply	other threads:[~2018-06-25 23:56 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-20 12:14 [PATCH 0/1] Y2038 support batch 3 - difftime Albert ARIBAUD (3ADEV)
2018-06-20 12:14 ` [PATCH 1/1] Y2038: add function __difftime64 Albert ARIBAUD (3ADEV)
2018-06-20 19:29   ` Paul Eggert
2018-06-20 20:55     ` Albert ARIBAUD
2018-06-21 21:17       ` Paul Eggert
2018-06-25 22:32         ` Albert ARIBAUD
2018-06-25 23:56           ` Paul Eggert [this message]
2018-06-27 11:03             ` Albert ARIBAUD
2018-07-05 18:36               ` Albert ARIBAUD
2018-07-05 19:13                 ` Zack Weinberg
2018-07-05 19:40                 ` Paul Eggert
2018-07-05 20:38                   ` Albert ARIBAUD
2018-07-05 21:17                     ` Bruno Haible
2018-07-06  5:06                       ` Albert ARIBAUD
2018-07-06 22:54                         ` Paul Eggert
2018-07-06 22:40                       ` Paul Eggert
2018-07-06 22:37                     ` Paul Eggert
2018-07-17 20:40                   ` Joseph Myers
2018-07-05 20:50                 ` time_t in gnulib Bruno Haible

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6c6c0111-572d-538a-e9e7-26b43b44d6c4@cs.ucla.edu \
    --to=eggert@cs.ucla.edu \
    --cc=albert.aribaud@3adev.fr \
    --cc=libc-alpha@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).