From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 021CD3858C83 for ; Wed, 11 Jan 2023 21:27:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 021CD3858C83 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1673472425; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=v58CnZJPBlW7rZuY6quPXaz52GbvoC4pAPtLT3OGvvo=; b=hEYBFPjDZVYGjqaaNJNNZinvHY5wmudNWwDDavsXal0L8vgReaCKfy1ymNXBeMpLy8fr6S S73yz2NIRB8u1deGY0F+XvA2a8dNCaOFg2L58mXGoHCVAPDStzEwykaUh+0qzm9zqeyLC0 P71Bg7QDFKhjNAyVhNfNkiovWgc/5SM= Received: from mail-io1-f72.google.com (mail-io1-f72.google.com [209.85.166.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-80-7fhJGezyML-OOItCDaKXXw-1; Wed, 11 Jan 2023 16:27:04 -0500 X-MC-Unique: 7fhJGezyML-OOItCDaKXXw-1 Received: by mail-io1-f72.google.com with SMTP id q21-20020a6bf215000000b006f305924242so9841575ioh.9 for ; Wed, 11 Jan 2023 13:27:04 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=v58CnZJPBlW7rZuY6quPXaz52GbvoC4pAPtLT3OGvvo=; b=n71XZjaCr8KUGQetpCT1PJFeNxRVrzJ0ntVrtWmlUYXhzLAuQz9TghTci2HVZC2/QJ GO6lGEN6YlN/VfbY0E2HzqWrw2HhgZgjkVGo+vWt6MpuJtRBdBQ62Edgi5iqne7/5s5s lEw9sfv3dsVWnxLCe8pbfntjaQDRPG7if+WkXbhpIJU1GZbW0pxOzqRSX/v8CGIzsGbF JfQimMgDSq3N8MzGk27Cno/2fBq/tPG3BBjMthZYQljAxQ3DdUE0iScYRWlLUAJWVZ3I 9dIHKR4C2Pl+C0eqFagq1o32FyxaW+I0svOOZGCrnQQ/cV0fFNvQXNqEYTKuGWA5J5ZQ RSdA== X-Gm-Message-State: AFqh2kpwvzDNL4i2/hNF65Tv6B2vXGnoPWKxBPsAN6iiz+vvak78mpTv 1D2OgvvUcthsVCSPdK07EcKhHzuWNrbboUhl8riv+5JBCdw9dqKImQb0oel6Le6naIiwD+Zk4O/ p74m9HDfmpBSWxagTCZr7 X-Received: by 2002:a5d:88c4:0:b0:704:7066:9aec with SMTP id i4-20020a5d88c4000000b0070470669aecmr1544062iol.8.1673472423708; Wed, 11 Jan 2023 13:27:03 -0800 (PST) X-Google-Smtp-Source: AMrXdXtAX2+9t4YbGdDN5amJIJJhMI5bDC9NmsykVauDhwKPhGUSOydQNnPsv9qROdBGzIOAa9FQvQ== X-Received: by 2002:a5d:88c4:0:b0:704:7066:9aec with SMTP id i4-20020a5d88c4000000b0070470669aecmr1544055iol.8.1673472423506; Wed, 11 Jan 2023 13:27:03 -0800 (PST) Received: from [192.168.0.241] (192-0-145-146.cpe.teksavvy.com. [192.0.145.146]) by smtp.gmail.com with ESMTPSA id q20-20020a0566022f1400b006ff6e8b3b8csm5393288iow.41.2023.01.11.13.27.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 11 Jan 2023 13:27:03 -0800 (PST) Message-ID: <6c790e11-1d0b-fd7f-2574-c26815b8f6e4@redhat.com> Date: Wed, 11 Jan 2023 16:27:01 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Subject: Re: [PATCH v2 01/11] linux: Do not reset signal handler in posix_spawn if it is already SIG_DFL To: Adhemerval Zanella , libc-alpha@sourceware.org, Szabolcs Nagy , "H . J . Lu" Cc: Christian Brauner References: <20221104190112.2566409-1-adhemerval.zanella@linaro.org> <20221104190112.2566409-2-adhemerval.zanella@linaro.org> From: Carlos O'Donell Organization: Red Hat In-Reply-To: <20221104190112.2566409-2-adhemerval.zanella@linaro.org> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-12.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 11/4/22 15:01, Adhemerval Zanella via Libc-alpha wrote: > There is no need to issue another sigaction is the disposition is > already SIG_DFL. > > Checked on x86_64-linux-gnu. Changes requested per original v2. See other review. Please post v4. > --- > sysdeps/unix/sysv/linux/spawni.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/sysdeps/unix/sysv/linux/spawni.c b/sysdeps/unix/sysv/linux/spawni.c > index ee843a2247..65ee03c804 100644 > --- a/sysdeps/unix/sysv/linux/spawni.c > +++ b/sysdeps/unix/sysv/linux/spawni.c > @@ -129,7 +129,7 @@ __spawni_child (void *arguments) > else > { > __libc_sigaction (sig, 0, &sa); > - if (sa.sa_handler == SIG_IGN) > + if (sa.sa_handler == SIG_IGN || sa.sa_handler == SIG_DFL) > continue; > sa.sa_handler = SIG_DFL; > } -- Cheers, Carlos.