From: Joseph Myers <joseph@codesourcery.com>
To: Carlos O'Donell <carlos@redhat.com>
Cc: Zack Weinberg <zack@owlfolio.org>,
Yonggang Luo <luoyonggang@gmail.com>,
GNU libc development <libc-alpha@sourceware.org>,
Florian Weimer <fweimer@redhat.com>
Subject: Re: [PATCH v2 1/4] clang-format: should format with 2 space and do not usage tab
Date: Wed, 21 Jun 2023 17:35:26 +0000 [thread overview]
Message-ID: <6cea509b-500-3cfb-edd6-afea9a859022@codesourcery.com> (raw)
In-Reply-To: <de5f7484-223b-8204-27c3-ba6a4e8c9cfb@redhat.com>
On Wed, 21 Jun 2023, Carlos O'Donell via Libc-alpha wrote:
> It is *my* failing as a steward for the project if we don't make this
> easy, and I like clang-format because it makes this easy. I don't
> actually care what we pick but we should as project pick something and
> make it easy to support developers.
Personally I like not using tabs, but (a) the current glibc convention
definitely uses tabs and (b) changes like that definitely don't belong in
an unrelated patch series.
I don't think the convention of tabs for every eight columns is
*documented* GNU style, it's more like "GNU style by default because it's
what Emacs does by default" (you can stop Emacs doing it with an
appropriate .dir-locals.el, but then you need to re-enable tabs in
.dir-locals.el for makefile-mode and any other modes that should continue
to use tabs).
--
Joseph S. Myers
joseph@codesourcery.com
next prev parent reply other threads:[~2023-06-21 17:35 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-20 17:17 [PATCH v2 0/4] c2y proposal add monotonicwait support for mtx and ctx Yonggang Luo
2023-06-20 17:17 ` [PATCH v2 1/4] clang-format: should format with 2 space and do not usage tab Yonggang Luo
2023-06-20 17:45 ` Zack Weinberg
2023-06-21 6:31 ` 罗勇刚(Yonggang Luo)
2023-06-21 6:47 ` Xi Ruoyao
2023-06-21 6:55 ` 罗勇刚(Yonggang Luo)
2023-06-21 7:13 ` Xi Ruoyao
2023-06-21 7:36 ` 罗勇刚(Yonggang Luo)
2023-06-21 14:26 ` Zack Weinberg
2023-06-21 7:17 ` Xi Ruoyao
2023-06-21 16:19 ` Carlos O'Donell
2023-06-21 17:35 ` Joseph Myers [this message]
2023-06-21 17:41 ` 罗勇刚(Yonggang Luo)
2023-06-21 17:49 ` Andrew Pinski
2023-06-21 17:59 ` 罗勇刚(Yonggang Luo)
2023-06-21 18:31 ` Arsen Arsenović
2023-06-21 18:42 ` 罗勇刚(Yonggang Luo)
2023-06-21 19:36 ` Zack Weinberg
2023-06-21 21:26 ` Paul Eggert
2023-06-22 21:43 ` Joseph Myers
2023-06-22 21:48 ` Paul Eggert
2023-06-20 17:17 ` [PATCH v2 2/4] time: Implement c23 timespec_get base Yonggang Luo
2023-06-20 20:37 ` Joseph Myers
2023-06-21 6:42 ` 罗勇刚(Yonggang Luo)
2023-06-20 17:17 ` [PATCH v2 3/4] c11: Switch to use pthread_mutex_clocklock and pthread_cond_clockwait to implement cnd and mtx lock and wait Yonggang Luo
2023-06-20 17:17 ` [PATCH v2 4/4] c2y: Add function cnd_timedwait_base and mtx_timedlock_base Yonggang Luo
2023-06-20 20:41 ` Joseph Myers
2023-06-21 9:21 ` 罗勇刚(Yonggang Luo)
2023-06-21 9:54 ` Xi Ruoyao
2023-06-21 10:16 ` 罗勇刚(Yonggang Luo)
2023-06-21 10:25 ` Xi Ruoyao
2023-06-21 10:40 ` Florian Weimer
2023-06-21 13:23 ` Jₑₙₛ Gustedt
2023-06-21 12:09 ` Joseph Myers
2023-06-21 14:30 ` enh
2023-06-21 15:08 ` Joseph Myers
2023-06-21 18:39 ` 罗勇刚(Yonggang Luo)
2023-06-21 19:04 ` enh
2023-06-21 19:07 ` 罗勇刚(Yonggang Luo)
2023-06-21 19:18 ` enh
2023-06-21 19:38 ` 罗勇刚(Yonggang Luo)
2023-06-21 19:41 ` enh
2023-06-21 20:14 ` 罗勇刚(Yonggang Luo)
2023-06-21 19:43 ` 罗勇刚(Yonggang Luo)
2023-06-20 20:50 ` Joseph Myers
2023-06-20 20:45 ` [PATCH v2 0/4] c2y proposal add monotonicwait support for mtx and ctx Joseph Myers
2023-06-21 6:52 ` 罗勇刚(Yonggang Luo)
2023-06-21 7:14 ` Xi Ruoyao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6cea509b-500-3cfb-edd6-afea9a859022@codesourcery.com \
--to=joseph@codesourcery.com \
--cc=carlos@redhat.com \
--cc=fweimer@redhat.com \
--cc=libc-alpha@sourceware.org \
--cc=luoyonggang@gmail.com \
--cc=zack@owlfolio.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).