From: Adhemerval Zanella Netto <adhemerval.zanella@linaro.org>
To: Florian Weimer <fweimer@redhat.com>, libc-alpha@sourceware.org
Cc: Carlos O'Donell <carlos@redhat.com>
Subject: Re: [PATCH 2/2] Linux: Remove epoll_create, inotify_init from syscalls.list
Date: Mon, 19 Dec 2022 09:16:27 -0300 [thread overview]
Message-ID: <6d5d5de5-b761-e578-fe21-744b89b49e8d@linaro.org> (raw)
In-Reply-To: <a7958b34ad6331bb08b0d3f15d25e888da40a6bb.1671451274.git.fweimer@redhat.com>
On 19/12/22 09:03, Florian Weimer wrote:
> Their presence causes stub warnings to be created on architectures
> which do not implement them.
>
> Fixes commit d1d23b134244d59c4d6ef2295 ("Lninux: consolidate
> epoll_create implementation") and commit 842128f160a48e5545900ea3b
> ("Linux: consolidate inotify_init implementation").
LGTM, thanks.
Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org>
> ---
> sysdeps/unix/sysv/linux/Makefile | 2 ++
> sysdeps/unix/sysv/linux/syscalls.list | 2 --
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/sysdeps/unix/sysv/linux/Makefile b/sysdeps/unix/sysv/linux/Makefile
> index 42e51625ab..f298878e8f 100644
> --- a/sysdeps/unix/sysv/linux/Makefile
> +++ b/sysdeps/unix/sysv/linux/Makefile
> @@ -62,6 +62,7 @@ sysdep_routines += \
> clone3 \
> closefrom_fallback \
> convert_scm_timestamps \
> + epoll_create \
> epoll_pwait \
> epoll_pwait2 \
> epoll_wait \
> @@ -73,6 +74,7 @@ sysdep_routines += \
> fxstat64 \
> fxstatat \
> fxstatat64 \
> + inotify_init \
> lxstat \
> lxstat64 \
> mlock2 \
> diff --git a/sysdeps/unix/sysv/linux/syscalls.list b/sysdeps/unix/sysv/linux/syscalls.list
> index b9f45463c5..73e941ef89 100644
> --- a/sysdeps/unix/sysv/linux/syscalls.list
> +++ b/sysdeps/unix/sysv/linux/syscalls.list
> @@ -6,7 +6,6 @@ capget EXTRA capget i:pp capget
> capset EXTRA capset i:pp capset
> create_module EXTRA create_module 3 __compat_create_module create_module@GLIBC_2.0:GLIBC_2.23
> delete_module EXTRA delete_module 3 delete_module
> -epoll_create EXTRA epoll_create i:i epoll_create
> epoll_create1 EXTRA epoll_create1 i:i epoll_create1
> epoll_ctl EXTRA epoll_ctl i:iiip epoll_ctl
> eventfd EXTRA eventfd2 i:ii eventfd
> @@ -28,7 +27,6 @@ getresgid - getresgid i:ppp getresgid
> getsid - getsid i:i getsid
> init_module EXTRA init_module 5 init_module
> inotify_add_watch EXTRA inotify_add_watch i:isi inotify_add_watch
> -inotify_init EXTRA inotify_init i: inotify_init
> inotify_init1 EXTRA inotify_init1 i:I inotify_init1
> inotify_rm_watch EXTRA inotify_rm_watch i:ii inotify_rm_watch
> ioperm - ioperm i:UUi ioperm
next prev parent reply other threads:[~2022-12-19 12:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-19 12:03 [PATCH 0/2] Fix incorrect stub warnings after generic refactor Florian Weimer
2022-12-19 12:03 ` [PATCH 1/2] Linux: Reflow and sort some Makefile variables Florian Weimer
2022-12-19 12:15 ` Adhemerval Zanella Netto
2022-12-19 12:03 ` [PATCH 2/2] Linux: Remove epoll_create, inotify_init from syscalls.list Florian Weimer
2022-12-19 12:16 ` Adhemerval Zanella Netto [this message]
2022-12-19 12:16 ` [PATCH 0/2] Fix incorrect stub warnings after generic refactor Adhemerval Zanella Netto
2022-12-19 12:27 ` Florian Weimer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6d5d5de5-b761-e578-fe21-744b89b49e8d@linaro.org \
--to=adhemerval.zanella@linaro.org \
--cc=carlos@redhat.com \
--cc=fweimer@redhat.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).