From: Adhemerval Zanella <adhemerval.zanella@linaro.org>
To: Libc-alpha <libc-alpha@sourceware.org>,
Florian Weimer <fweimer@redhat.com>,
hpa@zytor.com
Subject: RFC: pthread pid accessor (BZ# 27880)
Date: Thu, 27 May 2021 16:36:05 -0300 [thread overview]
Message-ID: <6d79a213-0df2-be8e-3596-e010f366a34f@linaro.org> (raw)
It seems that this is trickier than it seems, some issues we might consider
first:
1. What should we do with detached threads? As for pthread_kill, issuing
a pthread_gettid_np might use an invalid handler (since the pthread_t
identifier might be reused). This only solution I have is to define
it as undefined behavior, this is not great but to proper support it
would incur to keep tracking or all possible pthread_t identifiers
(we already keep the glibc provided stacks, dl_stack_cache, so it
would be a matter to include the user provided one in the list as
special entries).
2. I think that once we provide this API, developers will start to use to
query if a thread is alive and I am not sure if this is really the
proper API for this. This is the same issue as 1.
3. How do we handle the concurrent access between pthread_join and
pthread_gettid_np? Once a pthread_join is issued, the pthread_t identifier
might be reused and accessing it should be invalid. pthread_join first
synchronizes using 'joinid' to avoid concurrent pthread_join and then
wait the kernel signal on 'tid' that the thread has finished.
The straightforward 'pthread_gettid_np' implementation would do a atomic
load on tid, however it might read a transient value between pthread_join
'joinid' setup and the futex wait. I am not sure how to handle it correctly.
Also, MacOSX signature is:
int pthread_gettid_np (pthread_t thread, uint64_t *thread_id)
And it returns the current thread identification if THREAD is NULL, returns
ESRCH for invalid handle (the 1. and 2. issue below), and also consults
the kernel if the identifier can no be obtained.
I think for possible glibc symbols we should use a pid_t instead, the NULL
special arguments is also tricky because if by POSIX pthread_t might be
NULL (this is an implementation detail), for ESRCH we can our
INVALID_NOT_TERMINATED_TD_P (which not the best solution, but it the
current practice).
Thoughts?
next reply other threads:[~2021-05-27 19:36 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-27 19:36 Adhemerval Zanella [this message]
2021-05-31 16:51 ` Florian Weimer
2021-06-01 14:09 ` Adhemerval Zanella
2021-06-01 14:18 ` Florian Weimer
2021-06-01 15:16 ` Adhemerval Zanella
2021-06-01 17:36 ` Florian Weimer
2021-06-01 17:51 ` Adhemerval Zanella
2021-06-01 17:54 ` Florian Weimer
2021-06-01 18:01 ` Adhemerval Zanella
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6d79a213-0df2-be8e-3596-e010f366a34f@linaro.org \
--to=adhemerval.zanella@linaro.org \
--cc=fweimer@redhat.com \
--cc=hpa@zytor.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).