From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from purple.birch.relay.mailchannels.net (purple.birch.relay.mailchannels.net [23.83.209.150]) by sourceware.org (Postfix) with ESMTPS id 42B033858407 for ; Thu, 4 Aug 2022 15:15:39 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 42B033858407 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=gotplt.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gotplt.org X-Sender-Id: dreamhost|x-authsender|siddhesh@gotplt.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id A1C0312263C; Thu, 4 Aug 2022 15:15:36 +0000 (UTC) Received: from pdx1-sub0-mail-a304.dreamhost.com (unknown [127.0.0.6]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 33E80122412; Thu, 4 Aug 2022 15:15:36 +0000 (UTC) ARC-Seal: i=1; s=arc-2022; d=mailchannels.net; t=1659626136; a=rsa-sha256; cv=none; b=MItJfCvmcOEy4BRAhzUbPnzRPfJK8yfDxBdhf4CEcxYDOkEcslKZEOLUqAfrQD6LhE6qsh 8TFixTTnNV6qH2qYHsEv2XrbvT2EjOC4wK9VsPCctoQbs3A/TPq7xVHiHP61Pi580NyCOH 8kfSad8lYIOHQdTnxXzF5MH77dD+dseCnctK1vDAVCB1czrYQ2iwUB/79JJbApq93Mtsp8 N4+Yaj7nrmRys3WfmaNB4TVRiD5WAbs3oR9kLjRMWJOi2AgANfDc5RCQT3CIdVUgQD3bTT ZOSSrKtOZtrZiZNv1PXP5MNaAAKtNKWh46vyBd/4t7Ybd8tEH3QhhU9LGOMfkg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=mailchannels.net; s=arc-2022; t=1659626136; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=y9Ra/jPKIEWEccSRK2c1IBjq9rtgs9N9NAEs8XURrZE=; b=XY+qP9vg4nHym94eDVQRA70JyihJ9+bzmoJGD/S7s8PPq44obUJrlxG1lECk/U1IR1lO7G tV+k+EnkGPoi83MlHoSAlpwnQ3MsA1jPp7WEzDEKick7NTwai5WF/Oa+p5Ykz42cEbaxHf oyxSQWqQ3jx0XXw18Y+1NWUYoyqFf5uKfvDElu/Xtt7eNgwm+fOi1yJfotX48O72voxLJC UQyivc5Fb93k6bB/zRXwGdfw+1aVlr+NaBCu+NFU+BR6KMYftI3hRR6N7/TarjdN2TP3Ui qXQgQ/XLkXUqMpQ8SHGDV7x95D3S1fz0A0YIqNDEmPX3oZvhPtcc/W73czagTA== ARC-Authentication-Results: i=1; rspamd-7c478d8c66-sjdk4; auth=pass smtp.auth=dreamhost smtp.mailfrom=siddhesh@gotplt.org X-Sender-Id: dreamhost|x-authsender|siddhesh@gotplt.org X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|siddhesh@gotplt.org X-MailChannels-Auth-Id: dreamhost X-Shelf-Reaction: 02e6930e79459c0f_1659626136456_1020905919 X-MC-Loop-Signature: 1659626136455:957282452 X-MC-Ingress-Time: 1659626136455 Received: from pdx1-sub0-mail-a304.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384) by 100.110.28.208 (trex/6.7.1); Thu, 04 Aug 2022 15:15:36 +0000 Received: from [192.168.176.119] (unknown [24.114.73.53]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) (Authenticated sender: siddhesh@gotplt.org) by pdx1-sub0-mail-a304.dreamhost.com (Postfix) with ESMTPSA id 4LzC3C2jgNz8l; Thu, 4 Aug 2022 08:15:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gotplt.org; s=dreamhost; t=1659626135; bh=y9Ra/jPKIEWEccSRK2c1IBjq9rtgs9N9NAEs8XURrZE=; h=Date:Subject:To:Cc:From:Content-Type:Content-Transfer-Encoding; b=xS6UIulBg/4t2+jodBrmyAeWCV0QUYCZ6gC59ZAvmAkHNdHsEP0AqofIv8QhM5DC4 qwLuU1833d2AQcwYfZXJL9F9leKz3YS+IiSrjtdWusbU3MWRKKWonm1g4NbBlq4R9C dbrEo+GwNwMkqlumC8m1YTvlJQUrXxAa3K2/0vCz/+H4T1UjeAmxD2z/7A4JYGZYOx zyMJEFT5z4lTw2RcTsfn4bWG78S6yCF3GaEj3/cAKnz5L5eRvCwLPRh9Pp2qYv9tms w1VsWZuz+Ukksg/Ce4xPCv6w4BPjnb/t8kMjgK0v2tHg5R9lQ3InUR/Y1SPzcLJfZs EN/r2HgrmF+Zg== Message-ID: <6db9b99b-1ea2-c57c-8b6e-40cf38169460@gotplt.org> Date: Thu, 4 Aug 2022 11:15:33 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH] malloc: Correct the documentation of the top_pad default Content-Language: en-US To: Florian Weimer Cc: libc-alpha@sourceware.org References: <87wnbojswh.fsf@oldenburg.str.redhat.com> <9ddb2422-47f5-ba9a-e7a3-d9522d80719a@gotplt.org> <878ro4jb1z.fsf@oldenburg.str.redhat.com> From: Siddhesh Poyarekar In-Reply-To: <878ro4jb1z.fsf@oldenburg.str.redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3031.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Aug 2022 15:15:41 -0000 On 2022-08-04 11:14, Florian Weimer wrote: > * Siddhesh Poyarekar: > >> On 2022-08-04 04:48, Florian Weimer via Libc-alpha wrote: >>> DEFAULT_TOP_PAD is defined as 131072 in >>> sysdeps/generic/malloc-machine.h. >> >> LGTM, but I wonder if we should tighten this so that it doesn't appear >> that DEFAULT_TOP_PAD could be 0 in any of our build configurations. >> e.g. we could replace the definition with a #error "define >> DEFAULT_TOP_PAD" or something like that to ensure that it's always >> defined through malloc-machine.h. What do you think? > > We could just remove the various #ifdefs, I guess. The other question > is whether we can use the constant in the tunable definition file. I > haven't investigate any of this. > > Should I push my change in the meantime? Yes please. Thanks, Sid