From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qt1-x82c.google.com (mail-qt1-x82c.google.com [IPv6:2607:f8b0:4864:20::82c]) by sourceware.org (Postfix) with ESMTPS id 0E740388C015 for ; Mon, 8 Mar 2021 13:41:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 0E740388C015 Received: by mail-qt1-x82c.google.com with SMTP id h26so3093202qtm.5 for ; Mon, 08 Mar 2021 05:41:19 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=GQyO/Jf2saDR0tUhQKvVD52EE6tnkU/4CmnzWTCvWzA=; b=oBD3BaRD0jUBCJ4Oxh2R79c04PJo7sqh41dfgJfPBUF+QPYJLDKqEz7q6+nizKnnqn RMROGMHBOwWzpzjsL/Ock5YsZAtAXoUr5U0ajip7POTPRQemKcJhM/qWIiQWJI4gl5Bc dGzx45WPueFdPaRF/NBRm0Gh+oj4oK0gmJBKRIyHl/nKrAa1CQoXXD0Xy6EEzjXGV/m3 AlUxHn7wKCLeA6GOFFOc4oOIduCHHhMlyi3kXCzWlcKo8Pt4xZTXSwF29hxXb15lcR8G +Bh5i86lKO1J5sZPfzHRtBgNJ9+pVjuznIIJ1u5027a01XOBeGzPyf7GeM0LRho36Nap O2oA== X-Gm-Message-State: AOAM532rqrylwOhvdE+EJJaRZi0VcpxwzOaa6jfqOPiwc72UFY5cZrJ3 Q6pq/mcp9ERbvAWqZa/n7fcqPg== X-Google-Smtp-Source: ABdhPJwKnM1TMdu1bphGBIbACeePZE5Rlb12QNoDNxo9mJwHMm3fuv3to7p/9Vc0j9fecDca7m13yg== X-Received: by 2002:ac8:4e95:: with SMTP id 21mr20499529qtp.177.1615210878577; Mon, 08 Mar 2021 05:41:18 -0800 (PST) Received: from [192.168.1.4] ([177.194.48.209]) by smtp.googlemail.com with ESMTPSA id e15sm7857766qtp.58.2021.03.08.05.41.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 08 Mar 2021 05:41:18 -0800 (PST) Subject: Re: [PATCH] tst: Add test for utime To: Florian Weimer Cc: Arjun Shankar , Lukasz Majewski , Joseph Myers , DJ Delorie , GNU C Library , Florian Weimer , Alistair Francis References: <20210225003509.7151-1-lukma@denx.de> <35562645.32965585.1614874667382.JavaMail.zimbra@redhat.com> <87ft199wf9.fsf@oldenburg.str.redhat.com> From: Adhemerval Zanella Message-ID: <6e5c342c-77ff-6024-fe3c-fde015e40048@linaro.org> Date: Mon, 8 Mar 2021 10:41:14 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <87ft199wf9.fsf@oldenburg.str.redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 08 Mar 2021 13:41:20 -0000 On 05/03/2021 17:29, Florian Weimer wrote: > * Adhemerval Zanella: > >> Maybe fix the kernel or/and use a non buggy FS instead? IMHO the test is >> doing *exactly* is meant to do: trigger and expose an unexpected return >> from the kernel or the libc. I don't think hiding it using a different >> FS is the right thing to do on glibc testsuite. > > I disagree: We want to test glibc here, not file systems. Test outputs > are already difficult enough to interpret. We should not add known > FAILs that are very difficult to fix (reformat & reinstall with another > file system is definitely in that category). My take is since we are the first step to drive the proper y2038 support and it has time limit, it is better to fail hard and signal something is wrong either with glibc or kernel *now* so we iron out the issues instead of fail once users actually deploy glibc on system that are meant to handle y2038 issues.