From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id EE1A03858D20 for ; Mon, 19 Feb 2024 22:17:23 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org EE1A03858D20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org EE1A03858D20 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1708381047; cv=none; b=Alf1HNlpeGfzY47uPf3bH9RDXE19xZE3HxKBntEhFBj9Lixq//JdSWVmdJxLN7LjBmVCISAbAgCDXmnsNzHGZ9exGvDZp4heL8WaSMSMxwOi5cTnN1xvsiQks+YY9FEjxFe2aXg/OaijNGw/jmAYx92NG/iGuxwO4wRa1aUihD4= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1708381047; c=relaxed/simple; bh=pObqdcM+hwJ+0YYVZ51T6j+7RvqoC3Ri7OEbtFa/fFg=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=wj00KywOLvDAVLpAyp6BAIXnyH5anXV02/BC8rkRALrHXdM6QVzvRJjqGLU832vjF/FBGreIm3JNw+1fMDM2bXVE3zhgJ+mcDPFyxLyBdu5/XChUMVkCVbLWjoSC2qat5KC3hfdvj392UHRQVbgrhduTHirrtWcwP3sii6WGQUM= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1708381043; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=btxxKRz4FwY8Fejz7WncKPsGlbu8iRFJSkRzys4JpjM=; b=a4foWObCPSnvburZCMWazAtcqj/GzXXkyoxhe4oS+Qu65vIzzAKGNhQxletC16eOPhKQtc /aItRs+lTu9t2ss+GvjX/TNk2B9wwOu7hGQBTa2EoP2d6hq6uV4+Tj2oXMJib69zRdhYYi ARUVfgihBaClyaLwND5THATx0f8b5qY= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-623-RxCsH1soNT63f-OSgcDkaQ-1; Mon, 19 Feb 2024 17:17:22 -0500 X-MC-Unique: RxCsH1soNT63f-OSgcDkaQ-1 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-40f01cf71ceso28271795e9.1 for ; Mon, 19 Feb 2024 14:17:22 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708381041; x=1708985841; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=btxxKRz4FwY8Fejz7WncKPsGlbu8iRFJSkRzys4JpjM=; b=wQLEzMpqSVMVDWV3WPpI2+Ee1131IlmOxb/b0ovjY54wao20/HJ7SzNxQqPC0JsNoz zrVvrZWXeGIf8Ts/HVoidY/DGsqpo6Fo/iEqJYNgQ7E4647/nRSWoDewYxvg1WK1z4fD J5ohKjwodvStXD1wNgX9RiHIOUobgw3O2c7BhlKz1w3vd+goIy2yw8NSbQTTOX0c+ltp o6+NrWQYfYhqXUP3XfDSdDS9ukj2jaFWS2POTuTOyk22MKXW6Pevv+kfduq8pEsm5y6+ tvv4eQ+fq/BDGfbPuIhq1sBgPOyoS51C/N9PF468y3/Eod5nCFAgOgEFdny0qGDihxJz OJ6g== X-Gm-Message-State: AOJu0YwX+tmrRWmFs/e+KvrE840q38T/lHGxJSFpqGMRqplWIHMhZ/c8 OyxYfSLMuvja7Fbvhrh9vYB2JmaP7/P48AeVpaGnV4T4IkOXmnaBK2IbHpvNnxjjb023oEtW2e+ Bye6OpeU/f9vwCrnp9FuXH8LTpI5RehAwlCtK2yQWsla/2vSLOyLZVVLETQ== X-Received: by 2002:a1c:4c07:0:b0:410:4630:1467 with SMTP id z7-20020a1c4c07000000b0041046301467mr9041558wmf.38.1708381041256; Mon, 19 Feb 2024 14:17:21 -0800 (PST) X-Google-Smtp-Source: AGHT+IEW5v9dGMVW6iHNHwnv5+nR9+YJedPb5k1TdYL1nbl35tvsASP1ir2pFvXu7Qp6qN9HMFBvIQ== X-Received: by 2002:a1c:4c07:0:b0:410:4630:1467 with SMTP id z7-20020a1c4c07000000b0041046301467mr9041554wmf.38.1708381040929; Mon, 19 Feb 2024 14:17:20 -0800 (PST) Received: from digraph.polyomino.org.uk (digraph.polyomino.org.uk. [2001:8b0:bf73:93f7::51bb:e332]) by smtp.gmail.com with ESMTPSA id k4-20020a5d5184000000b0033b4f82b301sm11644306wrv.3.2024.02.19.14.17.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Feb 2024 14:17:20 -0800 (PST) Received: from jsm28 (helo=localhost) by digraph.polyomino.org.uk with local-esmtp (Exim 4.95) (envelope-from ) id 1rcBwt-003grB-IQ; Mon, 19 Feb 2024 22:17:19 +0000 Date: Mon, 19 Feb 2024 22:17:19 +0000 (UTC) From: Joseph Myers To: Florian Weimer cc: libc-alpha@sourceware.org Subject: Re: [PATCH v3 04/32] elf: Eliminate second loop in find_version in dl-version.c In-Reply-To: Message-ID: <6e8b2e62-d72d-6218-dfb1-edd78be9cba5@redhat.com> References: MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII X-Spam-Status: No, score=-3.9 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Thu, 7 Dec 2023, Florian Weimer wrote: > Turn the assert in _dl_check_map_versions into a proper error > because it can be triggered by inconsistent variants of shared > objects. What's involved in such "inconsistent variants of shared objects"? I feel like such an error really ought to have an actual test in the glibc testsuite (even if we don't have many tests for dynamic linker error handling at present), but failing that, more details in the commit message of what's needed to result in that error. -- Joseph S. Myers josmyers@redhat.com