From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from bird.elm.relay.mailchannels.net (bird.elm.relay.mailchannels.net [23.83.212.17]) by sourceware.org (Postfix) with ESMTPS id 0E95239C2007 for ; Fri, 25 Jun 2021 09:07:15 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 0E95239C2007 X-Sender-Id: dreamhost|x-authsender|siddhesh@gotplt.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 6CE5A342BA6; Fri, 25 Jun 2021 09:07:14 +0000 (UTC) Received: from pdx1-sub0-mail-a75.g.dreamhost.com (100-96-17-81.trex.outbound.svc.cluster.local [100.96.17.81]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 057D7342C07; Fri, 25 Jun 2021 09:07:14 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|siddhesh@gotplt.org Received: from pdx1-sub0-mail-a75.g.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384) by 100.96.17.81 (trex/6.3.3); Fri, 25 Jun 2021 09:07:14 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|siddhesh@gotplt.org X-MailChannels-Auth-Id: dreamhost X-Spill-Imminent: 5d0bd142389d3fb0_1624612034260_3711461944 X-MC-Loop-Signature: 1624612034260:617286030 X-MC-Ingress-Time: 1624612034260 Received: from pdx1-sub0-mail-a75.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a75.g.dreamhost.com (Postfix) with ESMTP id 9DEB68C382; Fri, 25 Jun 2021 02:07:13 -0700 (PDT) Received: from [192.168.1.134] (unknown [1.186.101.110]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: siddhesh@gotplt.org) by pdx1-sub0-mail-a75.g.dreamhost.com (Postfix) with ESMTPSA id 58FDC8C37A; Fri, 25 Jun 2021 02:07:09 -0700 (PDT) Subject: Re: [PATCH v2] iconvconfig: Fix multiple issues To: Florian Weimer Cc: schwab@linux-m68k.org, libc-alpha@sourceware.org References: <20210625090128.316837-1-siddhesh@sourceware.org> <87czsagvr6.fsf@oldenburg.str.redhat.com> X-DH-BACKEND: pdx1-sub0-mail-a75 From: Siddhesh Poyarekar Message-ID: <6e926fff-7739-bbe0-6e62-5369810217db@sourceware.org> Date: Fri, 25 Jun 2021 14:37:04 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <87czsagvr6.fsf@oldenburg.str.redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3486.8 required=5.0 tests=BAYES_00, JMQ_SPF_NEUTRAL, KAM_DMARC_NONE, KAM_DMARC_STATUS, NICE_REPLY_A, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NEUTRAL, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Jun 2021 09:07:17 -0000 On 6/25/21 2:35 PM, Florian Weimer via Libc-alpha wrote: > * Siddhesh Poyarekar: > >> @@ -519,11 +520,12 @@ module_compare (const void *p1, const void *p2) >> /* Create new module record. */ >> static void >> new_module (const char *fromname, size_t fromlen, const char *toname, >> - size_t tolen, const char *directory, >> + size_t tolen, const char *dir_in, >> const char *filename, size_t filelen, int cost, size_t need_ext) >> { >> struct module *new_module; >> - size_t dirlen = strlen (directory) + 1; >> + size_t dirlen = strlen (dir_in) + 1; >> + const char *directory = xstrdup (dir_in); > > Sorry, why is this copy needed? That's the fulldir reference that goes from here into the symtab and so on. Later once the handle_dir function returns and the cache file is being written out, this pointer is referenced and by then it has already been freed. Siddhesh