From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-x32e.google.com (mail-wm1-x32e.google.com [IPv6:2a00:1450:4864:20::32e]) by sourceware.org (Postfix) with ESMTPS id A2E9E3848038 for ; Mon, 28 Jun 2021 12:10:41 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A2E9E3848038 Received: by mail-wm1-x32e.google.com with SMTP id w13so11299459wmc.3 for ; Mon, 28 Jun 2021 05:10:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:from:to:cc:references:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=/s5ntRR1JmxnVmTebmtMvo/S0ha2iJsjhTLPq9iWUNo=; b=nAjjO5+Jvay1VMvdmvYV5gDLYE9UBpNfjbPMsBCpd0dW68qLIymfYRzZKGZ1tLZF7t kzFBnQQM/y5XJ7cGdvyhFHAlI1wd+/u4VlftgC3QHRadQoVJgeTIbSrh3S4HF9jW5kG2 oMTOhGLzssuGjxx+v3AryEs63Z2oAQzPgDL/8E8/a8sZL2TG+vq0ojyw6oFply8m/8MP BtEq2XsfTyDrJkSM7g9/prpkyYnAhUuFT30IIGht7hKvGSS/jkqO9hUe2Q16xaiQp4Pj fwFwK/FDfaLeni0i6KQqQDFJ4NQDb00zQ+QnveThi0IQTkyqsBxSrqZsnw62zazw6S3N Gs0g== X-Gm-Message-State: AOAM530cCJDCYQW4dQro+PxeJQDSJE+2vg4Bl12/+0RS3COc60jgFgZ7 gT8kSOFkf20ahfwmepg92IU= X-Google-Smtp-Source: ABdhPJw0b+zEVGJoy+JpR4p2RvtMfiKkQ7V22N6GI37OQ3+H+aRCKqKL/+Qe9aHWKx8qF5tmN77JFg== X-Received: by 2002:a05:600c:2cb5:: with SMTP id h21mr1646938wmc.91.1624882240885; Mon, 28 Jun 2021 05:10:40 -0700 (PDT) Received: from [10.8.0.150] ([195.53.121.100]) by smtp.gmail.com with ESMTPSA id c133sm19076433wmf.0.2021.06.28.05.10.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 28 Jun 2021 05:10:40 -0700 (PDT) Subject: Re: [RFC] strcpys(): New function for copying strings safely From: "Alejandro Colomar (man-pages)" To: David Laight , glibc Cc: "tech@openbsd.org" , Christoph Hellwig , "linux-kernel@vger.kernel.org" , drepper@gmail.com References: <755875ec-baae-6cab-52a8-3c9530db1ce6@gmail.com> <38428d5e-ead2-bf18-e198-cecd4caeb3e7@gmail.com> <52e57bd5-0d04-4b4f-978a-8c1dbc08115c@gmail.com> Message-ID: <6ea2efaf-7898-9723-54e7-2cd59702f854@gmail.com> Date: Mon, 28 Jun 2021 14:10:39 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-6.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 28 Jun 2021 12:10:43 -0000 On 6/28/21 2:00 PM, Alejandro Colomar (man-pages) wrote: > l = strscat(n - l, dest + l, src2); Hmm, that's a bug; I wrote it too fast. Either l += strscpy(n - l, dest + l, src2); or l = strscat(n - l, dest, src2); should be used instead. -- Alejandro Colomar Linux man-pages comaintainer; https://www.kernel.org/doc/man-pages/ http://www.alejandro-colomar.es/