From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <eggert@cs.ucla.edu>
Received: from zimbra.cs.ucla.edu (zimbra.cs.ucla.edu [131.179.128.68])
 by sourceware.org (Postfix) with ESMTPS id 186863836C09
 for <libc-alpha@sourceware.org>; Mon, 28 Dec 2020 21:07:56 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 186863836C09
Authentication-Results: sourceware.org;
 dmarc=none (p=none dis=none) header.from=cs.ucla.edu
Authentication-Results: sourceware.org;
 spf=pass smtp.mailfrom=eggert@cs.ucla.edu
Received: from localhost (localhost [127.0.0.1])
 by zimbra.cs.ucla.edu (Postfix) with ESMTP id 91FAF160087;
 Mon, 28 Dec 2020 13:07:55 -0800 (PST)
Received: from zimbra.cs.ucla.edu ([127.0.0.1])
 by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032)
 with ESMTP id 57gXrg5GvmnB; Mon, 28 Dec 2020 13:07:54 -0800 (PST)
Received: from localhost (localhost [127.0.0.1])
 by zimbra.cs.ucla.edu (Postfix) with ESMTP id A4EFF1600CD;
 Mon, 28 Dec 2020 13:07:54 -0800 (PST)
X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu
Received: from zimbra.cs.ucla.edu ([127.0.0.1])
 by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026)
 with ESMTP id 8oQiDMjsZt26; Mon, 28 Dec 2020 13:07:54 -0800 (PST)
Received: from [192.168.1.9] (cpe-23-243-218-95.socal.res.rr.com
 [23.243.218.95])
 by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 7C56E160087;
 Mon, 28 Dec 2020 13:07:54 -0800 (PST)
Subject: Re: [PATCH v2 4/6] stdlib: Sync canonicalize with gnulib [BZ #10635]
 [BZ #26592] [BZ #26341] [BZ #24970]
To: Adhemerval Zanella <adhemerval.zanella@linaro.org>
Cc: bug-gnulib@gnu.org, libc-alpha@sourceware.org
References: <20201228135944.1018303-1-adhemerval.zanella@linaro.org>
 <20201228135944.1018303-4-adhemerval.zanella@linaro.org>
From: Paul Eggert <eggert@cs.ucla.edu>
Organization: UCLA Computer Science Department
Message-ID: <6eaea6a5-4064-ba5d-8d69-26529d3ae4c3@cs.ucla.edu>
Date: Mon, 28 Dec 2020 13:07:54 -0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.5.0
MIME-Version: 1.0
In-Reply-To: <20201228135944.1018303-4-adhemerval.zanella@linaro.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-Spam-Status: No, score=-4.7 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS,
 NICE_REPLY_A, SPF_HELO_NONE, SPF_PASS,
 TXREP autolearn=ham autolearn_force=no version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
 server2.sourceware.org
X-BeenThere: libc-alpha@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Libc-alpha mailing list <libc-alpha.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/libc-alpha>,
 <mailto:libc-alpha-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/libc-alpha/>
List-Post: <mailto:libc-alpha@sourceware.org>
List-Help: <mailto:libc-alpha-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/libc-alpha>,
 <mailto:libc-alpha-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Mon, 28 Dec 2020 21:07:57 -0000

On 12/28/20 5:59 AM, Adhemerval Zanella wrote:
> It sync with gnulib version bbaba6ce5 with the following difference
> require fix a glibc build:
> 
> --- stdlib/canonicalize.c
> +++ lib/canonicalize-lgpl.c
> @@ -52,7 +52,6 @@
>   # endif
>   # define GCC_LINT 1
>   # define _GL_ATTRIBUTE_PURE __attribute__ ((__pure__))
> -# define FUNC_REALPATH_WORKS 1

I hope a better fix for that problem is this change:

-#if !FUNC_REALPATH_WORKS || defined _LIBC
+#if defined _LIBC || !FUNC_REALPATH_WORKS

which I just installed into Gnulib 
<https://git.savannah.gnu.org/cgit/gnulib.git/commit/?id=18bc1ab1feca304d2a357407af8e29b3354496f2>. 
This sort of technique works in the "# if defined _LIBC || 
HAVE_FACCESSAT" line later on.