From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oi1-x22a.google.com (mail-oi1-x22a.google.com [IPv6:2607:f8b0:4864:20::22a]) by sourceware.org (Postfix) with ESMTPS id 3AE27385802F for ; Fri, 4 Mar 2022 12:42:57 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 3AE27385802F Received: by mail-oi1-x22a.google.com with SMTP id a6so7689949oid.9 for ; Fri, 04 Mar 2022 04:42:57 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=BH+pNCWNQJKtZg3A1BC5rctMHDPCelPsNcZum+Gg7O0=; b=QQhd1THCFotGpvDHs5l2BpGgTamt6d7ls7UUAVWvTt7P3+4jaivXAkFxhNfRGc90gA S92DFATTxCKSx9QXOv5EExddR1+Yko5GLwA3ZKi6l1b/LhV724PDgRJBUYv5kuQw8ZNp zWjGQ1LAaTCAyZoAU2NnTW5q0v3Hq+aJqIzfqEaGaFk9kLlE+N90DTXer3k4ug/t1xUR 1gsAG05DbgkNyp0bFqhXkYZnw+M78lwNPcpGNO4xgg9c2UMvYF/xX4B69/b429+Ia6cF CuBqwPfIxbAuTTjq9HBwJ5YnbcyOD97nC43uu/t0SezQL9nMwirla9R4ER3omyMaxbDs amVQ== X-Gm-Message-State: AOAM530M9Mpo8u3GXHgYecnQcKJFYVw5bdbYygR3OABtHJStvgig/bHE cFDXP+/lPJWsPwCiBByeKwzf8tful5TGxA== X-Google-Smtp-Source: ABdhPJybNoBYujY7EuTY2cFlkyI4zDzlBNLqRBYHEmcJ6xBe//fzPKv3MD9h+vP+Viudp7yHCb6JKg== X-Received: by 2002:a05:6808:b17:b0:2d9:87af:79cb with SMTP id s23-20020a0568080b1700b002d987af79cbmr6315511oij.171.1646397776615; Fri, 04 Mar 2022 04:42:56 -0800 (PST) Received: from ?IPV6:2804:431:c7ca:2dcb:a992:742c:8048:43bc? ([2804:431:c7ca:2dcb:a992:742c:8048:43bc]) by smtp.gmail.com with ESMTPSA id l15-20020a4ab0cf000000b0031c0494981csm2311766oon.9.2022.03.04.04.42.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 04 Mar 2022 04:42:56 -0800 (PST) Message-ID: <6eb5cf61-8c38-96e2-de92-01980d9e420f@linaro.org> Date: Fri, 4 Mar 2022 09:42:53 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Subject: Re: [PATCH 2/2] Remove dl-librecon.h header. Content-Language: en-US To: Florian Weimer , Adhemerval Zanella via Libc-alpha References: <20220221175922.3909198-1-adhemerval.zanella@linaro.org> <20220221175922.3909198-3-adhemerval.zanella@linaro.org> <87r17mrel0.fsf@oldenburg.str.redhat.com> From: Adhemerval Zanella In-Reply-To: <87r17mrel0.fsf@oldenburg.str.redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-12.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Mar 2022 12:42:58 -0000 On 28/02/2022 16:11, Florian Weimer wrote: > * Adhemerval Zanella via Libc-alpha: > >> diff --git a/elf/dl-support.c b/elf/dl-support.c >> index 1d648ce3a6..fa9fcdbe5a 100644 >> --- a/elf/dl-support.c >> +++ b/elf/dl-support.c > >> @@ -370,15 +367,9 @@ _dl_non_dynamic_init (void) >> >> if (__libc_enable_secure) >> { >> - static const char unsecure_envvars[] = >> - UNSECURE_ENVVARS >> -#ifdef EXTRA_UNSECURE_ENVVARS >> - EXTRA_UNSECURE_ENVVARS >> -#endif >> - ; >> - const char *cp = unsecure_envvars; >> + const char *cp = UNSECURE_ENVVARS; >> >> - while (cp < unsecure_envvars + sizeof (unsecure_envvars)) >> + while (cp < UNSECURE_ENVVARS + sizeof (UNSECURE_ENVVARS)) >> { >> __unsetenv (cp); >> cp = (const char *) __rawmemchr (cp, '\0') + 1; > > Please keep unsecure_envvars. I think C does not guarantee that there > is just one array for UNSECURE_ENVVARS. > Ack. > Rest looks okay to me. >