From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from loongson.cn (mail.loongson.cn [114.242.206.163]) by sourceware.org (Postfix) with ESMTP id 8FB413857344 for ; Sun, 15 May 2022 07:54:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 8FB413857344 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=loongson.cn Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=loongson.cn Received: from [10.20.4.187] (unknown [10.20.4.187]) by mail.loongson.cn (Coremail) with SMTP id AQAAf9Dxb9uUsYBi48UWAA--.13761S3; Sun, 15 May 2022 15:53:56 +0800 (CST) Subject: Re: [PATCH v4 08/13] LoongArch: Linux Syscall Interface To: Arnd Bergmann Cc: GNU C Library , xuchenghua@loongson.cn, joseph_myers@mentor.com, Adhemerval Zanella References: <20220509022611.1248063-1-caiyinyu@loongson.cn> <20220509022611.1248063-9-caiyinyu@loongson.cn> From: caiyinyu Message-ID: <6ef4c33f-c3d8-e360-212f-31d78b60522e@loongson.cn> Date: Sun, 15 May 2022 15:53:56 +0800 User-Agent: Mozilla/5.0 (X11; Linux mips64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-CM-TRANSID: AQAAf9Dxb9uUsYBi48UWAA--.13761S3 X-Coremail-Antispam: 1UD129KBjvJXoW7WFWkWr47Xw4UtrW7ArW7CFg_yoW8Gr15pa 18AF18ta17GayxC3s3uw1IyryIqFnxtrWUCryrK3W8AFWUtw1fZFWqvr9agry2qF95XF18 XrWDtFn8uFWxX3DanT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDU0xBIdaVrnRJUUUvq14x267AKxVWUJVW8JwAFc2x0x2IEx4CE42xK8VAvwI8IcIk0 rVWrJVCq3wAFIxvE14AKwVWUJVWUGwA2ocxC64kIII0Yj41l84x0c7CEw4AK67xGY2AK02 1l84ACjcxK6xIIjxv20xvE14v26r1j6r1xM28EF7xvwVC0I7IYx2IY6xkF7I0E14v26r1j 6r4UM28EF7xvwVC2z280aVAFwI0_Cr0_Gr1UM28EF7xvwVC2z280aVCY1x0267AKxVW8Jr 0_Cr1UM2AIxVAIcxkEcVAq07x20xvEncxIr21l5I8CrVACY4xI64kE6c02F40Ex7xfMcIj 6xIIjxv20xvE14v26r1j6r18McIj6I8E87Iv67AKxVWUJVW8JwAm72CE4IkC6x0Yz7v_Jr 0_Gr1lF7xvr2IY64vIr41lF7I21c0EjII2zVCS5cI20VAGYxC7Mxk0xIA0c2IEe2xFo4CE bIxvr21lc2xSY4AK6svPMxAIw28IcxkI7VAKI48JMxC20s026xCaFVCjc4AY6r1j6r4UMI 8I3I0E5I8CrVAFwI0_Jr0_Jr4lx2IqxVCjr7xvwVAFwI0_JrI_JrWlx4CE17CEb7AF67AK xVWUAVWUtwCIc40Y0x0EwIxGrwCI42IY6xIIjxv20xvE14v26r1j6r1xMIIF0xvE2Ix0cI 8IcVCY1x0267AKxVWUJVW8JwCI42IY6xAIw20EY4v20xvaj40_WFyUJVCq3wCI42IY6I8E 87Iv67AKxVWUJVW8JwCI42IY6I8E87Iv6xkF7I0E14v26r1j6r4UYxBIdaVFxhVjvjDU0x ZFpf9x0JUywZ7UUUUU= X-CM-SenderInfo: 5fdl5xhq1xqz5rrqw2lrqou0/ X-Spam-Status: No, score=-12.6 required=5.0 tests=BAYES_00, BODY_8BITS, GIT_PATCH_0, KAM_DMARC_STATUS, NICE_REPLY_A, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 15 May 2022 07:54:03 -0000 在 2022/5/11 下午3:02, Arnd Bergmann 写道: > On Mon, May 9, 2022 at 4:26 AM caiyinyu wrote: > >> +#define __NR_clone 220 >> +#define __NR_clone3 435 >> +#define __NR_fstat 80 >> +#define __NR_newfstatat 79 > stat() and newfstatat() are not in the current ABI for the kernel, this needs > to be updated, and the libc wrapper updated to call statx() instead. > > clone() is still an open question, this may have to be implemented on top > of clone3() > > Arnd Currently, glibc is not enable FSTATAT_USE_STATX in 64 bits system. Shall we modify sysdeps/unix/sysv/linux/fstatat64.c to support statx like: === diff --git a/sysdeps/unix/sysv/linux/fstatat64.c b/sysdeps/unix/sysv/linux/fstatat64.c index 2ab914380d..bd3b20644e 100644 --- a/sysdeps/unix/sysv/linux/fstatat64.c +++ b/sysdeps/unix/sysv/linux/fstatat64.c @@ -42,7 +42,7 @@ _Static_assert (sizeof (__blkcnt_t) == sizeof (__blkcnt64_t),  #if (__WORDSIZE == 32 \       && (!defined __SYSCALL_WORDSIZE || __SYSCALL_WORDSIZE == 32)) \ -     || defined STAT_HAS_TIME32 +     || defined STAT_HAS_TIME32 || !defined __NR_newfstatat  # define FSTATAT_USE_STATX 1  static inline int === or add fstatat64.c in loongarch port?? By now no other architectures have their own fstatat64.c.