From: Adhemerval Zanella <adhemerval.zanella@linaro.org>
To: Sam James <sam@gentoo.org>, libc-alpha@sourceware.org
Subject: Re: [PATCH] configure.ac: fix bashism in configure.ac
Date: Tue, 22 Mar 2022 09:46:14 -0300 [thread overview]
Message-ID: <6f05f963-9aa5-680e-60b1-7468a487a778@linaro.org> (raw)
In-Reply-To: <20220321230343.2582331-1-sam@gentoo.org>
On 21/03/2022 20:03, Sam James via Libc-alpha wrote:
> configure scripts need to be runnable with a POSIX-compliant /bin/sh.
>
> On many (but not all!) systems, /bin/sh is provided by Bash, so errors
> like this aren't spotted. Notably Debian defaults to /bin/sh provided
> by dash which doesn't tolerate such bashisms as '=='.
>
> This retains compatibility with bash.
>
> Fixes configure warnings/errors like:
> ```
> checking if compiler warns about alias for function with incompatible types... yes
> /var/tmp/portage/sys-libs/glibc-2.34-r10/work/glibc-2.34/configure: 4209: test: xyes: unexpected operator
> ```
>
> Signed-off-by: Sam James <sam@gentoo.org>
There are other occurrences of this bashism as on other configure.ac:
sysdeps/powerpc/powerpc64/le/configure.ac:66:AS_IF([test "$libc_cv_compiler_powerpc64le_ldbl128_mabi" == "no"],
sysdeps/powerpc/powerpc64/le/fpu/multiarch/configure.ac:12:AS_IF([[test "$libc_cv_mcpu_power10" == "yes"]],[
Should we fix it them as well?
Beside LGTM, thanks.
Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org>
> ---
> configure | 2 +-
> configure.ac | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/configure b/configure
> index 8e5bee775a..2a3cb49b0b 100755
> --- a/configure
> +++ b/configure
> @@ -4232,7 +4232,7 @@ if test x"$libc_cv_gcc_indirect_function" != xyes; then
> # GCC 8+ emits a warning for alias with incompatible types and it might
> # fail to build ifunc resolvers aliases to either weak or internal
> # symbols. Disables multiarch build in this case.
> - if test x"$libc_cv_gcc_incompatible_alias" == xyes; then
> + if test x"$libc_cv_gcc_incompatible_alias" = xyes; then
> { $as_echo "$as_me:${as_lineno-$LINENO}: WARNING: gcc emits a warning for alias between functions of incompatible types" >&5
> $as_echo "$as_me: WARNING: gcc emits a warning for alias between functions of incompatible types" >&2;}
> if test x"$multi_arch" = xyes; then
> diff --git a/configure.ac b/configure.ac
> index 87f67d25ec..fa7d3c025b 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -767,7 +767,7 @@ if test x"$libc_cv_gcc_indirect_function" != xyes; then
> # GCC 8+ emits a warning for alias with incompatible types and it might
> # fail to build ifunc resolvers aliases to either weak or internal
> # symbols. Disables multiarch build in this case.
> - if test x"$libc_cv_gcc_incompatible_alias" == xyes; then
> + if test x"$libc_cv_gcc_incompatible_alias" = xyes; then
> AC_MSG_WARN([gcc emits a warning for alias between functions of incompatible types])
> if test x"$multi_arch" = xyes; then
> AC_MSG_ERROR([--enable-multi-arch support requires a gcc with gnu-indirect-function support])
next prev parent reply other threads:[~2022-03-22 12:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-21 23:03 Sam James
2022-03-22 12:46 ` Adhemerval Zanella [this message]
2022-03-22 17:15 ` Sam James
2022-03-22 17:33 ` [PATCH v3] configure.ac: fix bashisms " Sam James
2022-03-22 17:45 ` Adhemerval Zanella
2022-03-23 1:53 ` Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6f05f963-9aa5-680e-60b1-7468a487a778@linaro.org \
--to=adhemerval.zanella@linaro.org \
--cc=libc-alpha@sourceware.org \
--cc=sam@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).