From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 36834 invoked by alias); 28 Oct 2016 20:16:06 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 36724 invoked by uid 89); 28 Oct 2016 20:16:06 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,RCVD_IN_SORBS_SPAM autolearn=ham version=3.3.2 spammy= X-HELO: mail-qk0-f179.google.com X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:to:references:cc:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-transfer-encoding; bh=/TLWxzye1YXMrfFd1Z0CSy9ScuHa5hT/QpRmDGH06nw=; b=kw+SfhuZDSurmhKDEh327cu9LcHlZiPNnn6gHDBQW03XdoAI8qcxhp8CvhnmCEZVJn AlqflMoXkorQ7djsA0C21Yl1N22KndJoxGkXtdX0J+uk3qYD02iOBxFDntVMYQgUvd7f AfV9dj5P181CFj8Bp0MIu+GfMlLEqa1Lk9W3Eqvl9YwCkIqVEe19S/0M22U5cx8hz6tN bXNtGDzNTWiAJhA6X1AcIM3WFqJCT7sscS823zFWhEY44KU/dBe4wBv4/pXVy+/AG3G6 23c+mh3SE3ez+DzvKlmqxkDm/8FZ/MBfs50T+VEgsV61rtagHLKhfXm48NhjEhRPcrbp sIUw== X-Gm-Message-State: ABUngvcPAXv/i5q+l1gmpVzf2EwdxhiUHm7NZZdvY9/AjPcmn8QFRly73+XlA8mr0FVjbo7f X-Received: by 10.55.203.9 with SMTP id d9mr13983696qkj.215.1477685754190; Fri, 28 Oct 2016 13:15:54 -0700 (PDT) Subject: Re: [PATCH] Add test for linking against most static libraries To: Joseph Myers References: <20161028125742.928D7439942E0@oldenburg.str.redhat.com> <8b17140d-bbab-95c1-7458-7214f0e474ad@redhat.com> <9c9a0748-7101-a6a0-297e-106886589d81@redhat.com> <64653efd-c294-f544-685d-48e1cafa51a9@redhat.com> Cc: Florian Weimer , libc-alpha@sourceware.org From: Carlos O'Donell Message-ID: <6f47760b-11fd-8555-0330-e49feb04b6ac@redhat.com> Date: Fri, 28 Oct 2016 20:16:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <64653efd-c294-f544-685d-48e1cafa51a9@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-10/txt/msg00566.txt.bz2 On 10/28/2016 02:30 PM, Carlos O'Donell wrote: > On 10/28/2016 01:33 PM, Joseph Myers wrote: >> On Fri, 28 Oct 2016, Carlos O'Donell wrote: >> >>> I'm kinda baffled by this. We don't set it in config-sysdirs. >>> >>> I expect you have a local patch that hid this. >> >> I expect he happened to have a compiler that searched a system include >> directory with crypt.h. >> >>> I'm going to commit the following immediate fix: >>> >>> 2016-10-28 Carlos O'Donell >>> >>> * elf/Makefile (CFALGS-tst-linkall-static): Define. >> >> That's not the right fix. The right way to address such issues is a >> wrapper header in include/. > > OK, I'll fix it that way right now. Given that crypt.h is the only installed header in crypt/ that should fix all such issues. No regressions on x86. OK? 2016-10-28 Carlos O'Donell * elf/Makefile (CFALGS-tst-linkall-static): Remove. * include/crypt.h: New file. diff --git a/elf/Makefile b/elf/Makefile index 057a19f..82c7e05 100644 --- a/elf/Makefile +++ b/elf/Makefile @@ -1280,7 +1280,6 @@ $(objpfx)tst-ldconfig-X.out : tst-ldconfig-X.sh $(objpfx)ldconfig $(objpfx)tst-dlsym-error: $(libdl) -CFLAGS-tst-linkall-static.c = -I../crypt $(objpfx)tst-linkall-static: \ $(common-objpfx)math/libm.a \ $(common-objpfx)crypt/libcrypt.a \ diff --git a/include/crypt.h b/include/crypt.h new file mode 100644 index 0000000..544551d --- /dev/null +++ b/include/crypt.h @@ -0,0 +1,3 @@ +#ifndef _CRYPT_H +# include +#endif /* _CRYPT_H */ --- -- Cheers, Carlos.