From: Siddhesh Poyarekar <siddhesh@sourceware.org>
To: sellcey@cavium.com
Cc: "libc-alpha@sourceware.org" <libc-alpha@sourceware.org>,
adhemerval.zanella@linaro.org
Subject: Re: [PATCH v3 0/4] aarch64: Allow overriding HWCAP_CPUID feature check
Date: Thu, 01 Jun 2017 05:29:00 -0000 [thread overview]
Message-ID: <6f5bebea-0395-bdd9-56ae-6431c21342c9@sourceware.org> (raw)
In-Reply-To: <1496175803.18342.61.camel@cavium.com>
On Wednesday 31 May 2017 01:53 AM, Steve Ellcey wrote:
> OK, I made a little progress. If I don't set LD_HWCAP_MASK then it
> seems to be treating it as 0, even though the default value is supposed
> to be HWCAP_IMPORTANT which gets set to HWCAP_CPUID. If I explicitly
> set LD_HWCAP_MASK to 0x800 then I get the correct heaviour and my
> program checks for CPUID. I am not sure why the default value for
> LD_HWCAP_MASK does not seem to be right.
I just realized what's going on; it is a bug in tunables. The
__tunables_set_val function returns without setting the value if the
value was not set by glibc.tune.hwcap_mask or LD_HWCAP_MASK, which is
wrong. It should return whatever is set in the tunable list.
I'll fix that and repost.
Siddhesh
next prev parent reply other threads:[~2017-06-01 5:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <bebe9cec-5156-4bfc-9b41-6db09af69981@email.android.com>
2017-05-30 16:54 ` Steve Ellcey
2017-05-30 19:22 ` Steve Ellcey
2017-05-30 20:23 ` Steve Ellcey
2017-06-01 5:29 ` Siddhesh Poyarekar [this message]
2017-06-01 16:22 ` Steve Ellcey
2017-05-25 20:27 Siddhesh Poyarekar
2017-05-26 20:13 ` Steve Ellcey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6f5bebea-0395-bdd9-56ae-6431c21342c9@sourceware.org \
--to=siddhesh@sourceware.org \
--cc=adhemerval.zanella@linaro.org \
--cc=libc-alpha@sourceware.org \
--cc=sellcey@cavium.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).