From: Adhemerval Zanella <adhemerval.zanella@linaro.org>
To: Florian Weimer <fweimer@redhat.com>,
Adhemerval Zanella via Libc-alpha <libc-alpha@sourceware.org>
Cc: Andreas Schwab <schwab@linux-m68k.org>, Paul Eggert <eggert@cs.ucla.edu>
Subject: Re: [PATCH v2 4/4] stdlib: Remove lstat usage from realpath [BZ #24970]
Date: Tue, 27 Oct 2020 14:30:55 -0300 [thread overview]
Message-ID: <6f6234f5-21c4-2c08-62b5-6d1aa5335e63@linaro.org> (raw)
In-Reply-To: <87r1pj4r50.fsf@oldenburg2.str.redhat.com>
On 27/10/2020 12:36, Florian Weimer wrote:
> * Adhemerval Zanella via Libc-alpha:
>
>> The readlink already tells whether the file is a symlink, so there is
>> no need to call lstat to check it. However for '..' it requires an
>> extra readlink check if the previous component can be really accessed,
>> otherwise the next iteration will check a possible valid path and end
>> early. It should performance-wise acceptable and a gain over lstat,
>> afaik symlink should not update any inode information.
>
> Should this go into gnulib first?
I can send to gnulib, although glibc implementation is not really in
sync with gnulib one's. Also on first patch of this set I explicit
did not sync some gnulib features that I think only clutter the
implementation with code that either won't be used by any system glibc
supports or will be removed in subsequent patches.
Paul, do you think this could be included in gnulib?
next prev parent reply other threads:[~2020-10-27 17:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-27 14:35 [PATCH v2 1/4] Sync canonicalize with gnulib [BZ #10635] Adhemerval Zanella
2020-10-27 14:35 ` [PATCH v2 2/4] stdlib: Use fixed buffer size for realpath [BZ #26241] Adhemerval Zanella
2020-10-27 14:35 ` [PATCH v2 3/4] stdlib: Fix arithmetic overflows in realpath [BZ #26592] Adhemerval Zanella
2020-10-27 14:35 ` [PATCH v2 4/4] stdlib: Remove lstat usage from realpath [BZ #24970] Adhemerval Zanella
2020-10-27 15:36 ` Florian Weimer
2020-10-27 17:30 ` Adhemerval Zanella [this message]
2020-10-27 19:11 ` Paul Eggert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6f6234f5-21c4-2c08-62b5-6d1aa5335e63@linaro.org \
--to=adhemerval.zanella@linaro.org \
--cc=eggert@cs.ucla.edu \
--cc=fweimer@redhat.com \
--cc=libc-alpha@sourceware.org \
--cc=schwab@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).