From: Paul Eggert <eggert@cs.ucla.edu>
To: Albert ARIBAUD <albert.aribaud@3adev.fr>,
Joseph Myers <joseph@codesourcery.com>
Cc: libc-alpha@sourceware.org
Subject: Re: [PATCH v2 2/2] Y2038: make __tz_convert compatible with 64-bit-time
Date: Sat, 16 Jun 2018 14:23:00 -0000 [thread overview]
Message-ID: <6f6e040c-94ec-4e2f-5e12-2ec57e57aa88@cs.ucla.edu> (raw)
In-Reply-To: <20180616160254.533870e8@athena>
Albert ARIBAUD wrote:
> if I remove the __ctime64 and __ctime64_r defines
> and then build glibc for x86_64-linux-gnu, the linker stage fails due to
> nis/nis_print.c lines 336 and 338 referring to an undefined ctime().
How about if we fix nis/nis_print.c to use localtime_r and strftime instead of
ctime? ctime is not thread-safe, and ctime_r is problematic due to the potential
problem of overrunning its output buffer when given outlandish timestamps, so
such a fix should be made regardless of the Y2038 changes.
next prev parent reply other threads:[~2018-06-16 14:23 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-14 13:51 [PATCH v2 0/2] Y2038 support batch 1 - __time64_t and __tz_convert Albert ARIBAUD (3ADEV)
2018-06-14 13:51 ` [PATCH v2 1/2] Y2038: Add 64-bit time for all architectures Albert ARIBAUD (3ADEV)
2018-06-14 13:57 ` Joseph Myers
2018-06-14 18:51 ` Albert ARIBAUD
2018-06-14 16:56 ` Paul Eggert
2018-06-14 17:52 ` Albert ARIBAUD
2018-07-30 5:38 ` Ben Hutchings
2018-07-30 5:41 ` Ben Hutchings
2018-06-14 13:51 ` [PATCH v2 2/2] Y2038: make __tz_convert compatible with 64-bit-time Albert ARIBAUD (3ADEV)
2018-06-14 17:07 ` Paul Eggert
2018-06-14 17:52 ` Albert ARIBAUD
2018-06-14 18:52 ` Paul Eggert
2018-06-14 19:40 ` Joseph Myers
2018-06-16 14:03 ` Albert ARIBAUD
2018-06-16 14:23 ` Paul Eggert [this message]
2018-06-16 18:21 ` Albert ARIBAUD
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6f6e040c-94ec-4e2f-5e12-2ec57e57aa88@cs.ucla.edu \
--to=eggert@cs.ucla.edu \
--cc=albert.aribaud@3adev.fr \
--cc=joseph@codesourcery.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).