From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from brown.elm.relay.mailchannels.net (brown.elm.relay.mailchannels.net [23.83.212.23]) by sourceware.org (Postfix) with ESMTPS id 6C9933858430 for ; Tue, 16 Nov 2021 05:26:52 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 6C9933858430 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=gotplt.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gotplt.org X-Sender-Id: dreamhost|x-authsender|siddhesh@gotplt.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 4D58D225D8; Tue, 16 Nov 2021 05:15:25 +0000 (UTC) Received: from pdx1-sub0-mail-a306.dreamhost.com (100-96-18-151.trex.outbound.svc.cluster.local [100.96.18.151]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id CB8A7226CC; Tue, 16 Nov 2021 05:15:24 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|siddhesh@gotplt.org Received: from pdx1-sub0-mail-a306.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384) by 100.96.18.151 (trex/6.4.3); Tue, 16 Nov 2021 05:15:25 +0000 X-MC-Relay: Junk X-MailChannels-SenderId: dreamhost|x-authsender|siddhesh@gotplt.org X-MailChannels-Auth-Id: dreamhost X-Exultant-Madly: 4a9cdcee34d93254_1637039725075_2862851221 X-MC-Loop-Signature: 1637039725075:755565852 X-MC-Ingress-Time: 1637039725075 Received: from [192.168.1.174] (unknown [1.186.223.29]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: siddhesh@gotplt.org) by pdx1-sub0-mail-a306.dreamhost.com (Postfix) with ESMTPSA id 4HtZ570xgZz2X; Mon, 15 Nov 2021 21:15:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=gotplt.org; s=gotplt.org; t=1637039724; bh=W1ZNsiPoaHFBz4spq+F3BY9VPys=; h=Date:Subject:To:Cc:From:Content-Type:Content-Transfer-Encoding; b=OmitP2UoQQZuqSUuY4Wvqy85HxTkVlrgk/V6jg5kJQzkR30jaLoIH91PYomV1PR7N lpNcP6k+RXEOSaPETZwo3etB03mBMOYg3bZ7fnHgTReI3khm10BTWoED1rcjrpOxOS W+AxcZQ03xfxCj2uWMhfl27Mte+Sex3ip7gRD51A= Message-ID: <6fa81c60-d8a2-71ba-e964-c7e4161b9322@gotplt.org> Date: Tue, 16 Nov 2021 10:45:17 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.1.0 Subject: Re: [PATCH] malloc: Fix malloc debug for 2.35 onwards Content-Language: en-US To: Stafford Horne Cc: GLIBC patches References: <20211113004047.1980486-1-shorne@gmail.com> <98e3b40a-3d1f-bac9-997b-22a659a1200b@gotplt.org> <629dbe12-64c5-4307-183f-2c679a2cdd8c@gotplt.org> From: Siddhesh Poyarekar In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3031.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, URIBL_BLACK autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Nov 2021 05:27:00 -0000 On 11/16/21 10:42, Stafford Horne wrote: > On Tue, Nov 16, 2021 at 04:17:10AM +0530, Siddhesh Poyarekar wrote: >> On 11/16/21 02:37, Stafford Horne wrote: >>> I am not sure, after my patch the SHLIB_COMPAT usage is just there for compat >>> symbols. As you mention using SHLIB_COMPAT to ensure libc_malloc_debug.so and >>> libc.so have the same version seems strange, I would think that would be >>> controlled by shlib-version or done out of the box. >> >> Right, so it mostly works, i.e. you have symbols with version names: >> >> ... >>> 00009bb4 g DF .text 00000030 GLIBC_2.35 memalign >>> 0000a5a8 g DF .text 00000138 GLIBC_2.35 mallinfo >>> 000091a0 g DF .text 00000180 GLIBC_2.35 malloc >>> 0000a2ac g DF .text 000000f8 GLIBC_2.35 mallopt >> ... >> >> but they're default versions, which is not desirable since we don't want >> this library to be linkable. So you will need a new macro that always >> creates the non-default symbol at the version that it was introduced. > > I think I get what you mean. Is this something you are planning to sort out? > As is without this patch the mem tests are failing on my port, and any future > ports. For existing ports it is working because of the HACK as you say. I was hoping you'd do that ;) If you're unable to, I'll try to get to it later in the week. Siddhesh