From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oi1-x234.google.com (mail-oi1-x234.google.com [IPv6:2607:f8b0:4864:20::234]) by sourceware.org (Postfix) with ESMTPS id BBD15385ED40 for ; Thu, 27 Jan 2022 17:04:31 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org BBD15385ED40 Received: by mail-oi1-x234.google.com with SMTP id p203so7021790oih.10 for ; Thu, 27 Jan 2022 09:04:31 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=nlsuXHmktdYud3ahN1FiSq+0ymhyKXTDVuPiPNFJows=; b=d7Ii08kTopo9hccE7F17OSlF77ee0UjoEqJMN+HVR1kBAq8GSyg2OEE3jOPNpvUJfy ACxno4azckb5RBJOY5P/ljvTcfM9fZNswQaLoiTPY4D7bUzDuM/b8F9kC1R0K0/eWbcB rZU9sD7kSPoS39AHHFFip1dORD6GN3lVPrhzP+v6pPVGpCGzvXmd4LFi5aUJVn76ppf2 xNY4LgKXTZ/HhpvmJA2fDBSM9pnpbKeeUxNfFRUfSUbx1EOj9go+2upbwmmlxuATlk6q 40ql8aXW7hArJRK9ON9077h4v//OlBPmJ6PB6RR/8ZqjMSrsNy2fSdouwKA77iZ5OhE5 ne4Q== X-Gm-Message-State: AOAM532kjGU0CZb5ixKhcMdikANvMp+vCQUQZbm1mFtAk8XyAdpwva2U wyLOmqizBF9XqIP6IgU4/8DRzA== X-Google-Smtp-Source: ABdhPJw/PZ+X+yXTaimszeW6jNO/jp9tdpsEmQjWVUHF/oN/ka8NU3MeJIF3fahwdPYZvm1kK/bs7w== X-Received: by 2002:a05:6808:1709:: with SMTP id bc9mr7269937oib.173.1643303070685; Thu, 27 Jan 2022 09:04:30 -0800 (PST) Received: from ?IPV6:2804:431:c7ca:709a:1507:9c68:3ec9:801? ([2804:431:c7ca:709a:1507:9c68:3ec9:801]) by smtp.gmail.com with ESMTPSA id h1sm9962790otb.58.2022.01.27.09.04.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 27 Jan 2022 09:04:30 -0800 (PST) Message-ID: <6fc49d07-940d-a356-aebd-5b0de8c681f0@linaro.org> Date: Thu, 27 Jan 2022 14:04:28 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.1 Subject: Re: [PATCH] posix: Replace posix_spawnattr_tc{get,set}pgrp_np with posix_spawn_file_actions_addtcsetpgrp_np Content-Language: en-US To: Florian Weimer Cc: libc-alpha@sourceware.org, Carlos O'Donell References: <20220127141400.3364940-1-adhemerval.zanella@linaro.org> <87h79pma45.fsf@oldenburg.str.redhat.com> From: Adhemerval Zanella In-Reply-To: <87h79pma45.fsf@oldenburg.str.redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-5.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 27 Jan 2022 17:04:34 -0000 On 27/01/2022 13:11, Florian Weimer wrote: > * Adhemerval Zanella: > >> The posix_spawnattr_tcsetpgrp_np works on a file descriptor (the >> controlling terminal), so it would make more sense to actually fit >> it on the file actions API. >> >> Also, POSIX_SPAWN_TCSETPGROUP is not really required since it is >> implicit by the presence of tcsetpgrp file action. >> >> The posix/tst-spawn6.c is also fixed when TTY can is not present. >> >> Checked on x86_64-linux-gnu and i686-linux-gnu. > > This has an ABI check failure on Hurd: > > --- ../sysdeps/mach/hurd/i386/libc.abilist 2022-01-27 10:04:20.120812828 -0500 > +++ /home/bmg/build/glibcs/i686-gnu/glibc/libc.symlist 2022-01-27 10:43:39.646804376 -0500 > @@ -2292,2 +2291,0 @@ GLIBC_2.35 posix_spawn_file_actions_addt > -GLIBC_2.35 posix_spawnattr_tcgetpgrp_np F > -GLIBC_2.35 posix_spawnattr_tcsetpgrp_np F > > The changes look okay to me. A second review is probably warranted at > this stage. Thanks. It is really annoying that hurd make update-abi adds a bunch of files and requires manual edit to get it right.