Re: [PATCH 1/2] Add framework for tunables

[Florian Weimer <fweimer@redhat.com>]

On 07/11/2016 06:39 PM, Siddhesh Poyarekar wrote:
>>> > > +- secure_env_alias:	Specify whether the environment variable should be read
>>> > > +			for setuid binaries.
>> >
>> > This needs to describe the exact meaning of the choices, and the default.
>> > I'm not sure if the current/name values are intuitive.
> It specifies if the env_alias should be read even for setuid binaries.
> This is currently only useful for MALLOC_CHECK_ since it is read even
> for setuid binaries.  Would env_alias_is_secure be clearer?

No, because I think the sense is reverted:

+    check {
+      type: INT_32
+      minval: 0
+      maxval: 3
+      env_alias: MALLOC_CHECK_
+      secure_env_alias: true
+    }

That's why I said you need to document what the options are and what 
they do in AT_SECURE mode, and the default value.

Thanks,
Florian