From: Carlos O'Donell <carlos@redhat.com>
To: Adhemerval Zanella <adhemerval.zanella@linaro.org>,
libc-alpha@sourceware.org
Subject: Re: [PATCH v2] linux: Fix fstat64 on alpha and sparc64
Date: Fri, 12 Jan 2024 08:37:18 -0500 [thread overview]
Message-ID: <701cc903-6dc7-6f1d-9cdd-9dfa4955358b@redhat.com> (raw)
In-Reply-To: <20240102143152.3477636-1-adhemerval.zanella@linaro.org>
On 1/2/24 09:31, Adhemerval Zanella wrote:
> The 551101e8240b7514fc646d1722f8b79c90362b8f change is incorrect for
> alpha and sparc, since __NR_stat is defined by both kABI. Use
> __NR_newfstat to check whether to fallback to __NR_fstat64 (similar
> to what fstatat64 does).
LGTM for 2.39.
Reviewed-by: Carlos O'Donell <carlos@redhat.com>
> Checked on sparc64-linux-gnu.
> ---
> sysdeps/unix/sysv/linux/fstat64.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/sysdeps/unix/sysv/linux/fstat64.c b/sysdeps/unix/sysv/linux/fstat64.c
> index b4b5dc2908..cc9f695df9 100644
> --- a/sysdeps/unix/sysv/linux/fstat64.c
> +++ b/sysdeps/unix/sysv/linux/fstat64.c
> @@ -30,7 +30,10 @@ __fstat64_time64 (int fd, struct __stat64_t64 *buf)
> {
> #if !FSTATAT_USE_STATX
> # if XSTAT_IS_XSTAT64
> -# ifdef __NR_fstat
> + /* The __NR_stat macro is defined for all ABIs that also define
> + XSTAT_IS_STAT64, so to correctly identify alpha and sparc check
> + __NR_newfstatat (similar to what fstatat64 does). */
> +# ifdef __NR_newfstatat
OK. Confirmed in fstatat64.c we use __NR_newfstatat to identify a 64-bit kABI.
> /* 64-bit kABI, e.g. aarch64, ia64, powerpc64*, s390x, riscv64, and
> x86_64. */
> return INLINE_SYSCALL_CALL (fstat, fd, buf);
--
Cheers,
Carlos.
next prev parent reply other threads:[~2024-01-12 13:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-02 14:31 Adhemerval Zanella
2024-01-12 13:37 ` Carlos O'Donell [this message]
-- strict thread matches above, loose matches on Subject: below --
2023-12-29 19:44 Adhemerval Zanella
2023-12-30 0:36 ` Andreas Schwab
2023-12-30 12:16 ` Florian Weimer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=701cc903-6dc7-6f1d-9cdd-9dfa4955358b@redhat.com \
--to=carlos@redhat.com \
--cc=adhemerval.zanella@linaro.org \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).