From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg1-x531.google.com (mail-pg1-x531.google.com [IPv6:2607:f8b0:4864:20::531]) by sourceware.org (Postfix) with ESMTPS id 356073858422 for ; Wed, 1 Feb 2023 17:56:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 356073858422 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-pg1-x531.google.com with SMTP id q9so13070343pgq.5 for ; Wed, 01 Feb 2023 09:56:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=LBIhT7amp9gc5061VI1rmZEvu/NFTz8gsq2UxAc3yoQ=; b=HyfEnvoOi/WGnaXqystp07ZcW9mJFUtZivpLBhtmEJyMG3U2AfMWT01aBVfOqt/Cag ETGY+A5Hzc+2Elr3oPOpYJBTD8tOjZA8nLLJJ6oVx2iGaUw5PlevLHl3mNeWKNkwx+Qd ZSlu46ny7rIF0O/UDsNh6i1i5Wf9do/SZS7zvtjKnNhZNrGoniBKmy1Czl+9n+UXVk+Y lF4JxTRDajn70cf282Wrg1lCVqqWqN3DlpQOqCeuAD3xDYpmTqtZ8XBoqVRFJL/zGzap mCgxDcxHZx8gb6jxPYj1YqdEKek7RF6fkBtADDR6YGgAoaBxQO/hY0HgACfA5q5BDRs1 tmtw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=LBIhT7amp9gc5061VI1rmZEvu/NFTz8gsq2UxAc3yoQ=; b=MDGy/VvlwjnFszHIxwPHaZi5qMsVybbwOuryr2g51oT13VThRCjR/YJ87c5Rlc7F+n hJcGVSUg2XLLOXr//39+wXPDpgkHg2KQDIa41dMaVDGX8FPu8n+SIGrsHGUyshX4n6Hc 2yNo2ytCbNXsM4kgKPCevluvxuHS+qk1yn/aOCLxBCld+Bj1sm0XhPktSf9kZ5XvnNYD EAuSITex3NlJzPLJDQHU0yRxjlwAZAVTDFcHWLuOv6GtLIYGocC8tiJhKryJkJWUGTWW uLfoqZ7OrlmfwVilGx6cogkU56AgYbCH7Pbv+BW1oNFQhRzukPTDNC34ktFy08FJgDUt GaGw== X-Gm-Message-State: AO0yUKU+aP8BMUo07jEufC0d2G3tAaVObPSw8JDgSftFt5nqiR/yR97T Zxu912+mExLRVu2DqJEeZU92XT5B67bmtHvX X-Google-Smtp-Source: AK7set+mVUgSlfKEm69mm4nWZP4TaJQjLoGsZ8foRY70q9TPTS2U7YUbVybIu2mmXNRha2+YHda0yw== X-Received: by 2002:a05:6a00:1993:b0:592:5d3e:63d5 with SMTP id d19-20020a056a00199300b005925d3e63d5mr4391178pfl.5.1675274185262; Wed, 01 Feb 2023 09:56:25 -0800 (PST) Received: from [192.168.50.50] (rrcs-173-197-98-118.west.biz.rr.com. [173.197.98.118]) by smtp.gmail.com with ESMTPSA id c136-20020a624e8e000000b005898fcb7c2bsm12141935pfb.170.2023.02.01.09.56.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 01 Feb 2023 09:56:24 -0800 (PST) Message-ID: <708eb065-33f2-6bd7-9626-adf51a364dfd@linaro.org> Date: Wed, 1 Feb 2023 07:56:21 -1000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH v11 26/29] string: Hook up the default implementation on test-stpcpy Content-Language: en-US To: Adhemerval Zanella , libc-alpha@sourceware.org, Noah Goldstein , Jeff Law , Xi Ruoyao References: <20230201170406.303978-1-adhemerval.zanella@linaro.org> <20230201170406.303978-27-adhemerval.zanella@linaro.org> From: Richard Henderson In-Reply-To: <20230201170406.303978-27-adhemerval.zanella@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-11.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2/1/23 07:04, Adhemerval Zanella wrote: > --- > string/test-stpcpy.c | 32 +++++++++++++++++++++----------- > 1 file changed, 21 insertions(+), 11 deletions(-) Reviewed-by: Richard Henderson r~ > > diff --git a/string/test-stpcpy.c b/string/test-stpcpy.c > index c7a416f93a..5d344b6a23 100644 > --- a/string/test-stpcpy.c > +++ b/string/test-stpcpy.c > @@ -26,26 +26,36 @@ > #include "test-string.h" > #ifndef WIDE > # define CHAR char > -# define SIMPLE_STPCPY simple_stpcpy > # define STPCPY stpcpy > #else > # include > # define CHAR wchar_t > -# define SIMPLE_STPCPY simple_wcpcpy > # define STPCPY wcpcpy > #endif /* !WIDE */ > > -CHAR *SIMPLE_STPCPY (CHAR *, const CHAR *); > - > -IMPL (SIMPLE_STPCPY, 0) > IMPL (STPCPY, 1) > > -CHAR * > -SIMPLE_STPCPY (CHAR *dst, const CHAR *src) > -{ > - while ((*dst++ = *src++) != '\0'); > - return dst - 1; > -} > +/* Also check the generic implementation. */ > +#undef STPCPY > +#undef weak_alias > +#define weak_alias(a, b) > +#undef libc_hidden_def > +#define libc_hidden_def(a) > +#undef libc_hidden_builtin_def > +#define libc_hidden_builtin_def(a) > +#undef attribute_hidden > +#define attribute_hidden > +#ifndef WIDE > +# define STPCPY __stpcpy_default > +# include "string/stpcpy.c" > +IMPL (__stpcpy_default, 1) > +#else > +# define __wcslen wcslen > +# define __wmemcpy wmemcpy > +# define WCPCPY __wcpcpy_default > +# include "wcsmbs/wcpcpy.c" > +IMPL (__wcpcpy_default, 1) > +#endif > > #undef CHAR > #include "test-strcpy.c"