From: Alejandro Colomar <alx.manpages@gmail.com>
To: libc-alpha@sourceware.org
Cc: Alejandro Colomar <alx@kernel.org>,
Paul Eggert <eggert@cs.ucla.edu>,
Adhemerval Zanella Netto <adhemerval.zanella@linaro.org>
Subject: Ping: [PATCH] time: Fix strftime(3) API regarding nullability
Date: Fri, 31 Mar 2023 01:43:55 +0200 [thread overview]
Message-ID: <70951a20-7444-0bd8-6e15-3fa1bcc28cb6@gmail.com> (raw)
In-Reply-To: <a6913b07-adec-dd9d-022a-699296c10050@linaro.org>
[-- Attachment #1.1: Type: text/plain, Size: 1229 bytes --]
Ping :)
On 3/13/23 18:10, Adhemerval Zanella Netto wrote:
>
>
> On 11/03/23 21:08, Alejandro Colomar via Libc-alpha wrote:
>> strftime(3) doesn't accept null pointers in any of the parameters.
>>
>> Cc: Paul Eggert <eggert@cs.ucla.edu>
>> Signed-off-by: Alejandro Colomar <alx@kernel.org>
>
> LGTM, thanks.
>
> Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org>
>
>> ---
>> time/time.h | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/time/time.h b/time/time.h
>> index d18089116e..28fb075b19 100644
>> --- a/time/time.h
>> +++ b/time/time.h
>> @@ -99,7 +99,8 @@ extern time_t __REDIRECT_NTH (mktime, (struct tm *__tp), __mktime64);
>> of characters written, or 0 if it would exceed MAXSIZE. */
>> extern size_t strftime (char *__restrict __s, size_t __maxsize,
>> const char *__restrict __format,
>> - const struct tm *__restrict __tp) __THROW;
>> + const struct tm *__restrict __tp)
>> + __THROW __nonnull((1, 3, 4));
>>
>> #ifdef __USE_XOPEN
>> /* Parse S according to FORMAT and store binary time information in TP.
--
<http://www.alejandro-colomar.es/>
GPG key fingerprint: A9348594CE31283A826FBDD8D57633D441E25BB5
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2023-03-30 23:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-12 0:08 Alejandro Colomar
2023-03-13 17:10 ` Adhemerval Zanella Netto
2023-03-30 23:43 ` Alejandro Colomar [this message]
2023-03-31 13:37 ` Ping: " Adhemerval Zanella Netto
2023-03-31 18:33 ` Sam James
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=70951a20-7444-0bd8-6e15-3fa1bcc28cb6@gmail.com \
--to=alx.manpages@gmail.com \
--cc=adhemerval.zanella@linaro.org \
--cc=alx@kernel.org \
--cc=eggert@cs.ucla.edu \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).