From: Adhemerval Zanella <adhemerval.zanella@linaro.org>
To: Paul Eggert <eggert@cs.ucla.edu>
Cc: bug-gnulib@gnu.org, libc-alpha@sourceware.org
Subject: Re: [PATCH 1/5] stdlib: Sync canonicalize with gnulib [BZ #10635] [BZ #26592] [BZ #26241]
Date: Mon, 28 Dec 2020 09:53:09 -0300 [thread overview]
Message-ID: <70e3be6a-0c77-8f01-436b-589b64e41657@linaro.org> (raw)
In-Reply-To: <05d5bdbd-210b-bb14-969c-ba59434a2280@cs.ucla.edu>
On 24/12/2020 19:45, Paul Eggert wrote:
> On 12/24/20 7:16 AM, Adhemerval Zanella wrote:
>> It sync with gnulib version d9c121346 with the following difference
>> require fix a glibc build:
>
> As I mentioned today on bug-gnulib I installed some changes into Gnulib which are related, and it'd probably be better to sync with the latest version. (Unfortunately I didn't know about your changes, so there was some overlapping work here.)
>
>> +# define FUNC_REALPATH_WORKS 1
>
> I don't see why this change is needed, as the only use of that macro is in "#if !FUNC_REALPATH_WORKS || defined _LIBC", which is unaffected by this change since _LIBC is defined.
I am seeing this with gcc 9.2.1:
canonicalize.c:101:6: error: "FUNC_REALPATH_WORKS" is not defined, evaluates to 0 [-Werror=undef]
101 | #if !FUNC_REALPATH_WORKS || defined _LIBC
(We build glibc with -Wundef -Werror).
next prev parent reply other threads:[~2020-12-28 12:53 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-24 15:16 [PATCH 0/5] Fix multiple realpath issues Adhemerval Zanella
2020-12-24 15:16 ` [PATCH 1/5] stdlib: Sync canonicalize with gnulib [BZ #10635] [BZ #26592] [BZ #26241] Adhemerval Zanella
2020-12-24 22:45 ` Paul Eggert
2020-12-25 0:44 ` [PATCH 1/5] warnings in canonicalize.c Bruno Haible
2020-12-25 5:56 ` Paul Eggert
2020-12-28 12:53 ` Adhemerval Zanella [this message]
2020-12-24 15:16 ` [PATCH 2/5] Import idx.h from gnulib Adhemerval Zanella
2020-12-24 22:53 ` Paul Eggert
2020-12-25 20:34 ` Florian Weimer
2020-12-25 21:38 ` Bruno Haible
2020-12-26 1:29 ` Paul Eggert
2020-12-31 23:12 ` Joseph Myers
2021-01-01 3:24 ` Paul Eggert
2020-12-24 15:16 ` [PATCH 3/5] Import filename.h " Adhemerval Zanella
2020-12-31 23:13 ` Joseph Myers
2021-01-01 3:31 ` Paul Eggert
2020-12-24 15:17 ` [PATCH 4/5] stdlib: Add testcase fro BZ #26241 Adhemerval Zanella
2020-12-24 15:17 ` [PATCH 5/5] stdlib: Remove lstat usage from realpath [BZ #24970] Adhemerval Zanella
2020-12-25 0:27 ` Paul Eggert
2020-12-28 11:42 ` Adhemerval Zanella
2020-12-28 13:32 ` Adhemerval Zanella
2020-12-28 21:04 ` Paul Eggert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=70e3be6a-0c77-8f01-436b-589b64e41657@linaro.org \
--to=adhemerval.zanella@linaro.org \
--cc=bug-gnulib@gnu.org \
--cc=eggert@cs.ucla.edu \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).