From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oi1-x22b.google.com (mail-oi1-x22b.google.com [IPv6:2607:f8b0:4864:20::22b]) by sourceware.org (Postfix) with ESMTPS id 1E5933844751 for ; Mon, 20 Feb 2023 13:55:57 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1E5933844751 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-oi1-x22b.google.com with SMTP id c11so1804448oiw.2 for ; Mon, 20 Feb 2023 05:55:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=Vc3MGt7emIsmMbCemstDmFDipdh4TEzIcni7z5IJ0z8=; b=rUmTrwLucxdMkyhMVAIeE5jnjbBTTOUnPAO+1NjxgEu+JXls4FJQ2p/NZDirz9Byt1 wZlWPCZcvdCHFRR7e1RbcsL2BP9nAjc34E8bVJcg2RBV4l7v5kG1H6Fq1pY91s9J7qa8 CfN6aWovrVIs125DAV4Irq7bjmyxckMKx7YfV5s1il2tQQZk0wQ0CRqaxZjR8VtT4z0O HqDupPQ7WHWrQYEBVTg/pCyeCR60F+yU1bI44jCGW0fMR4RaSxabfp7Xwm09H6ebEteS Yo8Ybrmd8vDdhl2zMeAb8m/xR6hC5urprCZWlMbLnvJuW+hRmqgle+yhKjGbz3bFAopC Rzog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Vc3MGt7emIsmMbCemstDmFDipdh4TEzIcni7z5IJ0z8=; b=Y3II9cv/XzU+9UbfSYG6zk8XEswtiQOAnAcwLlSoVYihQ+Ep6gLsFKpUDJJwlcOlJn VQaS/Gp58vbFIzvMb1D1Ph0JcXdGk8K22eGtCqH3bK388jO0GBag6es9Tv61QCTVlANG m0FdqEPS8zwgb4FCfH6Bh5A5k9Ar2ZqHn1PlbjAjMmDPU9RmIKMXPdWrMQzSG4Rpg9GR 6sB5zLubrviSBHvKbPY3r3hJJnWXLFvxwRFJgZlQ+ZAuS+5gkP08NMvDmtlXIlK105qp p4BpB4Z5H1YSDMfXDHcQF5M/gkrHn0fziz1sXVsRZuALtIxZNXjLuDvltbNyrrzSZF2D wd5Q== X-Gm-Message-State: AO0yUKU/mXhiwZXMmjupuX0M2+xcPOwBNkMaF/+zhX0o8yaGSCs9lJ68 DGxgEtWWBcDWrfqNR0Kfp5oigg== X-Google-Smtp-Source: AK7set8NJfL/Ns4tDW4+6OvxBZ3KZJ86mzYzlbXyYP1y8OMEFMx8RInnBXAO25hnbkx2fUGuEp3BJw== X-Received: by 2002:aca:1a03:0:b0:37f:abf1:f143 with SMTP id a3-20020aca1a03000000b0037fabf1f143mr5985680oia.24.1676901356344; Mon, 20 Feb 2023 05:55:56 -0800 (PST) Received: from ?IPV6:2804:1b3:a7c3:3a5:a0:9596:f951:7d30? ([2804:1b3:a7c3:3a5:a0:9596:f951:7d30]) by smtp.gmail.com with ESMTPSA id v9-20020acade09000000b0037f8f4618acsm4877647oig.28.2023.02.20.05.55.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 20 Feb 2023 05:55:55 -0800 (PST) Message-ID: <70e98b0f-26c4-82ca-50ce-1efd31102988@linaro.org> Date: Mon, 20 Feb 2023 10:55:53 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.7.2 Subject: Re: [PATCH v4] elf: Restore ldconfig libc6 implicit soname logic [BZ #30125] Content-Language: en-US To: Florian Weimer , Adhemerval Zanella Netto via Libc-alpha Cc: Joan Bruguera References: <20230216020810.3947682-1-joanbrugueram@gmail.com> <20230218215215.3930119-1-joanbrugueram@gmail.com> <87bkloh3q5.fsf@oldenburg.str.redhat.com> From: Adhemerval Zanella Netto Organization: Linaro In-Reply-To: <87bkloh3q5.fsf@oldenburg.str.redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-6.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 20/02/23 10:21, Florian Weimer wrote: > * Adhemerval Zanella Netto via Libc-alpha: > >> On 18/02/23 18:52, Joan Bruguera wrote: >>> While cleaning up old libc version support, the deprecated libc4 code was >>> accidentally kept in `implicit_soname`, instead of the libc6 code. >>> >>> This causes additional symlinks to be created by `ldconfig` for libraries >>> without a soname, e.g. a library `libsomething.123.456.789` without a soname >>> will create a `libsomething.123` -> `libsomething.123.456.789` symlink. >>> >>> As the libc6 version of the `implicit_soname` code is a trivial `xstrdup`, >>> just inline it and remove `implicit_soname` altogether. >>> >>> Some further simplification looks possible (e.g. the call to `create_links` >>> looks like a no-op if `soname == NULL`, other than the verbose printfs), but >>> logic is kept as-is for now. >>> >>> Fixes: BZ #30125 >>> Fixes: 8ee878592c4a ("Assume only FLAG_ELF_LIBC6 suport") >>> Signed-off-by: Joan Bruguera >> >> LGTM, thanks. >> >> Reviewed-by: Adhemerval Zanella > > Reviewed-by: Florian Weimer > > Are you going to push & backport this to glibc 2.37? I already did from 2.34 to 2.37.