From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <libc-alpha-return-75313-listarch-libc-alpha=sources.redhat.com@sourceware.org>
Received: (qmail 21649 invoked by alias); 29 Nov 2016 17:38:22 -0000
Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <libc-alpha.sourceware.org>
List-Subscribe: <mailto:libc-alpha-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/libc-alpha/>
List-Post: <mailto:libc-alpha@sourceware.org>
List-Help: <mailto:libc-alpha-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: libc-alpha-owner@sourceware.org
Received: (qmail 21635 invoked by uid 89); 29 Nov 2016 17:38:21 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-4.8 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:812, super
X-HELO: mx1.redhat.com
Subject: Re: [PATCH] localedata: GBK: add mapping for 0x80->Euro sign [BZ
 #20864]
To: Mike Frysinger <vapier@gentoo.org>
References: <20161125161735.3823-1-vapier@gentoo.org>
 <mvmoa10t0ty.fsf@hawking.suse.de>
 <b7d39428-a95b-eeff-4958-e77af2ff6d50@redhat.com>
 <CAJaTeToXi=08APaL8c+ppDjGw8DW1bhL_OvjzNUtC4qGe3Q2vw@mail.gmail.com>
Cc: Andreas Schwab <schwab@suse.de>, GNU C Library <libc-alpha@sourceware.org>
From: Florian Weimer <fweimer@redhat.com>
Message-ID: <710146f0-d334-47ce-d599-cf0d2bddfe2b@redhat.com>
Date: Tue, 29 Nov 2016 17:38:00 -0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.4.0
MIME-Version: 1.0
In-Reply-To: <CAJaTeToXi=08APaL8c+ppDjGw8DW1bhL_OvjzNUtC4qGe3Q2vw@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
X-SW-Source: 2016-11/txt/msg01066.txt.bz2

On 11/29/2016 06:04 PM, Mike Frysinger wrote:
> On Tue, Nov 29, 2016 at 5:08 AM, Florian Weimer <fweimer@redhat.com> wrote:
>> On 11/28/2016 10:23 AM, Andreas Schwab wrote:
>>> FAIL: iconvdata/tst-tables
>>> failed: ./tst-table.sh
>>> /home/abuild/rpmbuild/BUILD/glibc-2.24.90.20161127.gb964e06/cc-base/
>>> /home/abuild/rpmbuild/BUILD/glibc-2.24.90.20161127.gb964e06/cc-base/iconvdata/
>>> GBK
>>
>> Here's one way to fix it.  Doesn't look really pretty, but it seems that
>> this new 0x80 mapping is quite an outlier.
>
> i'm not super familiar with the gconv modules, but this seems to make sense
>
> should use lowercase hex constants though to match surrounding code style

Right, I'll fix this before committing it.

Thanks,
Florian