From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id C136E385842B for ; Fri, 19 May 2023 11:36:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C136E385842B Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1684496197; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=by4K0yK/aG5LjY6vzwiYtB/TrMVql0RSnndwWGDJmmA=; b=ZQ52RieXxH8H6UBc6sHyb8sF9GvJvBA3uLVgZC8Njka5CYuc+MaqZnThHMNGXjJgHpzq6x 71epOXhpf2ux3I+3GjVBLhdBd1Ri5/ut+GmKVt1oEuio5bMyk9mA7fAfm+jc1kLWZZcm79 /+9yL988Is3EX7gdJjkgVUpJmSdm5Hg= Received: from mail-yw1-f199.google.com (mail-yw1-f199.google.com [209.85.128.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-453-zO-Ne-xhOcOtFfxAA_NayA-1; Fri, 19 May 2023 07:36:36 -0400 X-MC-Unique: zO-Ne-xhOcOtFfxAA_NayA-1 Received: by mail-yw1-f199.google.com with SMTP id 00721157ae682-55d9a9d19c9so57626717b3.1 for ; Fri, 19 May 2023 04:36:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684496195; x=1687088195; h=content-transfer-encoding:in-reply-to:organization:from:references :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=by4K0yK/aG5LjY6vzwiYtB/TrMVql0RSnndwWGDJmmA=; b=FnXP/Scj8lTKuge97AVR0FnVvmYKeFcAM5A9OO1XTckeYJI7O18NLAGH3Z1BW/Zx80 oez8iaazbvR58vEHERva5g2BYoRR29fQGhPspe/RCJxA4jfLbXrcll+nGJApe4SWmTXw 0IVEi44tL7HKaMBTaH/ua+Uy7RlHpiqOCI/0NX+7RRT9DkNThiaFEHuoWyl/C2tERQ5n vzorqklmJUlgmbXeYZDB/vxV4unkW83f+JX94yNuHBBAkbosB3DZfPV4HhMaYUAMnPQ2 AEKn5glnjaRRGe0w/3Z0kl943PL+aOGw3Xf8ziLbIT1lE84aHlDsgCvFxUI8n3fx4fRY A1rQ== X-Gm-Message-State: AC+VfDyEvOhLxJdBn3vkgsNQqWG24o1P022oxHauMbZImJ/BSvVZDjF+ IDeNdZeeiWgPmxzLbxDJSRH+VRW0iGLDd6cjHs7bCI7wWydKDVkkpzU/JyvVeg95CO5lYHi/C8h sM9xaaP0lf8+uSQGJAKZi X-Received: by 2002:a81:5c57:0:b0:561:9d6c:bdbd with SMTP id q84-20020a815c57000000b005619d6cbdbdmr1546720ywb.23.1684496195560; Fri, 19 May 2023 04:36:35 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6sl/Zc9C8EEpqzF8SctiBzcDp4lvfAZ0JJf3HSoPJMHNUBLw3fauwcQZaOIXnXKgXuwbOrug== X-Received: by 2002:a81:5c57:0:b0:561:9d6c:bdbd with SMTP id q84-20020a815c57000000b005619d6cbdbdmr1546706ywb.23.1684496195304; Fri, 19 May 2023 04:36:35 -0700 (PDT) Received: from [192.168.0.241] ([198.48.244.52]) by smtp.gmail.com with ESMTPSA id m77-20020a0dca50000000b00545cb6adc16sm1105622ywd.6.2023.05.19.04.36.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 19 May 2023 04:36:34 -0700 (PDT) Message-ID: <71432962-7be9-f60c-1daa-718cdc8e044d@redhat.com> Date: Fri, 19 May 2023 07:36:33 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [RFC PATCH 2/2] x86: Make dl-cache.h and readelflib.c not Linux-specific To: Sergey Bugaev , libc-alpha@sourceware.org, bug-hurd@gnu.org References: <20230517185422.71084-1-bugaevc@gmail.com> <20230517185422.71084-3-bugaevc@gmail.com> From: Carlos O'Donell Organization: Red Hat In-Reply-To: <20230517185422.71084-3-bugaevc@gmail.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-13.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 5/17/23 14:54, Sergey Bugaev via Libc-alpha wrote: > These files could be useful to any port that wants to use ld.so.cache. I agree, and this is likely cargo-cult across the targets. At most we look at EI_CLASS, and EM_* machine, and FLAG_ELF_LIBC6 is defined in sysdeps/generic/ldconfig.h (not Linux specific) and likewise for the other flags. LGTM. Reviewed-by: Carlos O'Donell > Signed-off-by: Sergey Bugaev > --- > sysdeps/{unix/sysv/linux => }/x86/readelflib.c | 0 > sysdeps/{unix/sysv/linux => }/x86_64/dl-cache.h | 0 > 2 files changed, 0 insertions(+), 0 deletions(-) > rename sysdeps/{unix/sysv/linux => }/x86/readelflib.c (100%) > rename sysdeps/{unix/sysv/linux => }/x86_64/dl-cache.h (100%) > > diff --git a/sysdeps/unix/sysv/linux/x86/readelflib.c b/sysdeps/x86/readelflib.c > similarity index 100% > rename from sysdeps/unix/sysv/linux/x86/readelflib.c > rename to sysdeps/x86/readelflib.c > diff --git a/sysdeps/unix/sysv/linux/x86_64/dl-cache.h b/sysdeps/x86_64/dl-cache.h > similarity index 100% > rename from sysdeps/unix/sysv/linux/x86_64/dl-cache.h > rename to sysdeps/x86_64/dl-cache.h -- Cheers, Carlos.