From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oa1-x2d.google.com (mail-oa1-x2d.google.com [IPv6:2001:4860:4864:20::2d]) by sourceware.org (Postfix) with ESMTPS id AA33A3860C3C for ; Thu, 2 Jun 2022 18:48:55 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org AA33A3860C3C Received: by mail-oa1-x2d.google.com with SMTP id 586e51a60fabf-f2cd424b9cso7857648fac.7 for ; Thu, 02 Jun 2022 11:48:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=yXAVJlbx5KX/Wkx2k6j1QznnYy/h7mBo8wQsH7RHlt8=; b=fzlt+quVjVtUw5cZ16ieg21U+qPyA/Jfq9owkYpfTJcCUFq4gcIOxfUVOcbudXHtBM DhaQU3cFDm2gw040RdmtGnQVXZIDmHPhvvWjEnsGa6q/AqosrTRGFRjuCBGBNUwz5NaM GGMMHT+1PgH6eQlVJnZJFHtDTm2yfwzxPYnawD4lX5/dWkgjix6bL4LQVbq+tOTxFyuv gDGUyDdKieaIxwdAV3YexleH6SfHTEr3JFE9zMg6Kv/LrFnVWGFARbmdZ5jAlKVDfYKB KvgN/7RVQJToHDttyxCEzIzvmlEMe4jzqfVwoOlUpwj2avvlQS8lo/TzJhtTnVgOZRO1 oz7g== X-Gm-Message-State: AOAM532KytHk9MZlcmJCqKlqL64knv6dO8Wz+0Z65+mBou0XD9r5A6Yh WeuLpC0SM6unwAbqCfXzoNJxbmxvaOOVrw== X-Google-Smtp-Source: ABdhPJywfsfMtuKJGFGG32F/7SNJ9tpZRKPIP1GEJ8/c+H7asujgT9Z4EJjohFCe5NSAKG0OKhSADA== X-Received: by 2002:a05:6871:7a1:b0:f1:b33d:7875 with SMTP id o33-20020a05687107a100b000f1b33d7875mr3656646oap.272.1654195735041; Thu, 02 Jun 2022 11:48:55 -0700 (PDT) Received: from ?IPV6:2804:431:c7ca:e39c:d866:26cd:928:370a? ([2804:431:c7ca:e39c:d866:26cd:928:370a]) by smtp.gmail.com with ESMTPSA id k5-20020a9d4b85000000b0060b0c9e7ff1sm2647033otf.47.2022.06.02.11.48.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 02 Jun 2022 11:48:54 -0700 (PDT) Message-ID: <7152bc46-ec47-196b-4dfa-0e1aaf5ad033@linaro.org> Date: Thu, 2 Jun 2022 15:48:52 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH v2 05/14] stdio-common: Introduce buffers for implementing printf Content-Language: en-US To: Florian Weimer , libc-alpha@sourceware.org References: From: Adhemerval Zanella In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-8.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 02 Jun 2022 18:48:57 -0000 On 23/05/2022 11:07, Florian Weimer via Libc-alpha wrote: > + > +void > +__printf_buffer_flush_to_file (struct __printf_buffer_to_file *buf) > +{ > + /* The bytes in the buffer are always consumed. */ > + buf->base.written += buf->base.write_ptr - buf->base.write_base; > + > + if (buf->base.write_end == array_end (buf->stage)) > + { > + /* If the stage buffer is used, make a copy into the file. The > + stage buffer is always consumed fully, even if just partially > + written, to ensure that the file stream has all the data. */ > + size_t count = buf->base.write_ptr - buf->stage; > + if ((size_t) _IO_sputn (buf->fp, buf->stage, count) != count) > + { > + __printf_buffer_mark_failed (&buf->base); > + return; > + } Indentation seems off here.