From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qv1-xf36.google.com (mail-qv1-xf36.google.com [IPv6:2607:f8b0:4864:20::f36]) by sourceware.org (Postfix) with ESMTPS id 19A163950C61 for ; Wed, 20 Jan 2021 11:29:45 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 19A163950C61 Received: by mail-qv1-xf36.google.com with SMTP id az16so10695387qvb.5 for ; Wed, 20 Jan 2021 03:29:45 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=f4iz1ngF1J1bEjuYVv6outzQq7h7i7XZHLf9CXkI+zo=; b=mKk1bbdVJSRPkWvX4HtiSRWAU+H1BoisR5IPY1xf7zB2LsucJSBpqQq+UvykPmKatj GlVb6ihx5WKDRiauXApqUnQq0cmyPwyP7RM1KthpNNHJo65PyZ+exJvwjPYQbhVtOl1g y/A67hGemXW5GgVvw1qESQ/ul1kY+PkeGJ3BAOCqW1T7+9RqB/nKOsCMtuZdUCk5oPpZ OLMFgj8PU0RDSqECMTz/8RNFmMs6oAjPBGVdZCv9UF6QIthauMq1wRGYWyfC+2sFIfRN YaZaa02AQmPuUGWjX+gpreaY3pJ7kN6bmKdFuORj1KFnq6bkLpzcGxI9IpxieA6ezHzg U7UQ== X-Gm-Message-State: AOAM5331e1haZZEtmbg/09SZGJGjSKzqndccNtZfZtkzHTwqX9kGSean e1vFmoHDiSz6NQ0WZ7R2jp6787OoAHD1Bg== X-Google-Smtp-Source: ABdhPJwssD6Czo5pi93Rdd+YYP/fWZ3dPr5rFnRT+VY057veVS00JYjHBryGcmN/z/ESjQW4Xwddyg== X-Received: by 2002:a0c:f48a:: with SMTP id i10mr8692914qvm.61.1611142184524; Wed, 20 Jan 2021 03:29:44 -0800 (PST) Received: from [192.168.1.4] ([177.194.48.209]) by smtp.googlemail.com with ESMTPSA id v145sm1130589qka.27.2021.01.20.03.29.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 20 Jan 2021 03:29:43 -0800 (PST) Subject: Re: [PATCH v4 00/10] fix ifunc with static pie [BZ #27072] To: "H.J. Lu" Cc: Szabolcs Nagy , GNU C Library References: <9f68b24a-437c-db8e-d1fa-b26d2e06d103@linaro.org> <20210119182504.GG3445@arm.com> <831d6134-b688-9049-5d7c-4092f4a6d968@linaro.org> From: Adhemerval Zanella Autocrypt: addr=adhemerval.zanella@linaro.org; prefer-encrypt=mutual; keydata= mQINBFcVGkoBEADiQU2x/cBBmAVf5C2d1xgz6zCnlCefbqaflUBw4hB/bEME40QsrVzWZ5Nq 8kxkEczZzAOKkkvv4pRVLlLn/zDtFXhlcvQRJ3yFMGqzBjofucOrmdYkOGo0uCaoJKPT186L NWp53SACXguFJpnw4ODI64ziInzXQs/rUJqrFoVIlrPDmNv/LUv1OVPKz20ETjgfpg8MNwG6 iMizMefCl+RbtXbIEZ3TE/IaDT/jcOirjv96lBKrc/pAL0h/O71Kwbbp43fimW80GhjiaN2y WGByepnkAVP7FyNarhdDpJhoDmUk9yfwNuIuESaCQtfd3vgKKuo6grcKZ8bHy7IXX1XJj2X/ BgRVhVgMHAnDPFIkXtP+SiarkUaLjGzCz7XkUn4XAGDskBNfbizFqYUQCaL2FdbW3DeZqNIa nSzKAZK7Dm9+0VVSRZXP89w71Y7JUV56xL/PlOE+YKKFdEw+gQjQi0e+DZILAtFjJLoCrkEX w4LluMhYX/X8XP6/C3xW0yOZhvHYyn72sV4yJ1uyc/qz3OY32CRy+bwPzAMAkhdwcORA3JPb kPTlimhQqVgvca8m+MQ/JFZ6D+K7QPyvEv7bQ7M+IzFmTkOCwCJ3xqOD6GjX3aphk8Sr0dq3 4Awlf5xFDAG8dn8Uuutb7naGBd/fEv6t8dfkNyzj6yvc4jpVxwARAQABtElBZGhlbWVydmFs IFphbmVsbGEgTmV0dG8gKExpbmFybyBWUE4gS2V5KSA8YWRoZW1lcnZhbC56YW5lbGxhQGxp bmFyby5vcmc+iQI3BBMBCAAhBQJXFRpKAhsDBQsJCAcDBRUKCQgLBRYCAwEAAh4BAheAAAoJ EKqx7BSnlIjv0e8P/1YOYoNkvJ+AJcNUaM5a2SA9oAKjSJ/M/EN4Id5Ow41ZJS4lUA0apSXW NjQg3VeVc2RiHab2LIB4MxdJhaWTuzfLkYnBeoy4u6njYcaoSwf3g9dSsvsl3mhtuzm6aXFH /Qsauav77enJh99tI4T+58rp0EuLhDsQbnBic/ukYNv7sQV8dy9KxA54yLnYUFqH6pfH8Lly sTVAMyi5Fg5O5/hVV+Z0Kpr+ZocC1YFJkTsNLAW5EIYSP9ftniqaVsim7MNmodv/zqK0IyDB GLLH1kjhvb5+6ySGlWbMTomt/or/uvMgulz0bRS+LUyOmlfXDdT+t38VPKBBVwFMarNuREU2 69M3a3jdTfScboDd2ck1u7l+QbaGoHZQ8ZNUrzgObltjohiIsazqkgYDQzXIMrD9H19E+8fw kCNUlXxjEgH/Kg8DlpoYJXSJCX0fjMWfXywL6ZXc2xyG/hbl5hvsLNmqDpLpc1CfKcA0BkK+ k8R57fr91mTCppSwwKJYO9T+8J+o4ho/CJnK/jBy1pWKMYJPvvrpdBCWq3MfzVpXYdahRKHI ypk8m4QlRlbOXWJ3TDd/SKNfSSrWgwRSg7XCjSlR7PNzNFXTULLB34sZhjrN6Q8NQZsZnMNs TX8nlGOVrKolnQPjKCLwCyu8PhllU8OwbSMKskcD1PSkG6h3r0AquQINBFcVGkoBEACgAdbR Ck+fsfOVwT8zowMiL3l9a2DP3Eeak23ifdZG+8Avb/SImpv0UMSbRfnw/N81IWwlbjkjbGTu oT37iZHLRwYUFmA8fZX0wNDNKQUUTjN6XalJmvhdz9l71H3WnE0wneEM5ahu5V1L1utUWTyh VUwzX1lwJeV3vyrNgI1kYOaeuNVvq7npNR6t6XxEpqPsNc6O77I12XELic2+36YibyqlTJIQ V1SZEbIy26AbC2zH9WqaKyGyQnr/IPbTJ2Lv0dM3RaXoVf+CeK7gB2B+w1hZummD21c1Laua +VIMPCUQ+EM8W9EtX+0iJXxI+wsztLT6vltQcm+5Q7tY+HFUucizJkAOAz98YFucwKefbkTp eKvCfCwiM1bGatZEFFKIlvJ2QNMQNiUrqJBlW9nZp/k7pbG3oStOjvawD9ZbP9e0fnlWJIsj 6c7pX354Yi7kxIk/6gREidHLLqEb/otuwt1aoMPg97iUgDV5mlNef77lWE8vxmlY0FBWIXuZ yv0XYxf1WF6dRizwFFbxvUZzIJp3spAao7jLsQj1DbD2s5+S1BW09A0mI/1DjB6EhNN+4bDB SJCOv/ReK3tFJXuj/HbyDrOdoMt8aIFbe7YFLEExHpSk+HgN05Lg5TyTro8oW7TSMTk+8a5M kzaH4UGXTTBDP/g5cfL3RFPl79ubXwARAQABiQIfBBgBCAAJBQJXFRpKAhsMAAoJEKqx7BSn lIjvI/8P/jg0jl4Tbvg3B5kT6PxJOXHYu9OoyaHLcay6Cd+ZrOd1VQQCbOcgLFbf4Yr+rE9l mYsY67AUgq2QKmVVbn9pjvGsEaz8UmfDnz5epUhDxC6yRRvY4hreMXZhPZ1pbMa6A0a/WOSt AgFj5V6Z4dXGTM/lNManr0HjXxbUYv2WfbNt3/07Db9T+GZkpUotC6iknsTA4rJi6u2ls0W9 1UIvW4o01vb4nZRCj4rni0g6eWoQCGoVDk/xFfy7ZliR5B+3Z3EWRJcQskip/QAHjbLa3pml xAZ484fVxgeESOoaeC9TiBIp0NfH8akWOI0HpBCiBD5xaCTvR7ujUWMvhsX2n881r/hNlR9g fcE6q00qHSPAEgGr1bnFv74/1vbKtjeXLCcRKk3Ulw0bY1OoDxWQr86T2fZGJ/HIZuVVBf3+ gaYJF92GXFynHnea14nFFuFgOni0Mi1zDxYH/8yGGBXvo14KWd8JOW0NJPaCDFJkdS5hu0VY 7vJwKcyHJGxsCLU+Et0mryX8qZwqibJIzu7kUJQdQDljbRPDFd/xmGUFCQiQAncSilYOcxNU EMVCXPAQTteqkvA+gNqSaK1NM9tY0eQ4iJpo+aoX8HAcn4sZzt2pfUB9vQMTBJ2d4+m/qO6+ cFTAceXmIoFsN8+gFN3i8Is3u12u8xGudcBPvpoy4OoG Message-ID: <71a094be-cce0-0082-7b1c-ec8566eaef3c@linaro.org> Date: Wed, 20 Jan 2021 08:29:41 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Jan 2021 11:29:46 -0000 On 19/01/2021 18:38, H.J. Lu wrote: > On Tue, Jan 19, 2021 at 12:16 PM Adhemerval Zanella > wrote: >> >> >> >> On 19/01/2021 16:41, H.J. Lu wrote: >>> On Tue, Jan 19, 2021 at 10:25 AM Szabolcs Nagy via Libc-alpha >>> wrote: >>>> >>>> The 01/18/2021 18:37, Adhemerval Zanella wrote: >>>>> As a side note I tried your branch with a build for all support Linux >>>>> ABIs and it as least improves by issuing an error on architectures >>>>> where previously indicated support static-pie but it is broken in practice >>>>> (powerpc for instance [1]) >>>>> >>>>> So currently static-pie are support for all architectures, however it >>>>> fails to build for: >>>>> >>>>> alpha-linux-gnu >>>>> arc-linux-gnuhf >>>>> hppa-linux-gnu >>>>> ia64-linux-gnu >>>>> m68k-linux-gnu >>>>> microblaze-linux-gnu >>>>> riscv32-linux-gnu-rv32imafdc-ilp32d >>>>> riscv64-linux-gnu-rv64imafdc-lp64d >>>>> s390-linux-gnu >>>>> sparc64-linux-gnu >>>>> sparcv9-linux-gnu >>>>> >>>>> By requiring PI_STATIC_AND_HIDDEN hppa, m68, microblaze, mips, nios2, >>>>> and powerpc fail at configure. Some architecture still fails at build: >>>>> >>>>> alpha-linux-gnu >>>>> arc-linux-gnuhf >>>>> riscv32-linux-gnu-rv32imafdc-ilp32d >>>>> riscv64-linux-gnu-rv64imafdc-lp64d >>>>> s390-linux-gnu >>>>> sparc64-linux-gnu >>>>> sparcv9-linux-gnu >>>>> >>>>> I haven't checked if mips is currently broken for static-pie (since >>>>> as for powerpc, it does not define PI_STATIC_AND_HIDDEN); but I would >>>>> expect so. >>>>> >>>>> It would be good if we could avoid building the broken configuration >>>>> and warn it on configure, but I don't think this should be a blocker. >>>>> The NEWS for 2.27 states this features is only supported for x86 >>>>> and aarch64, so I wonder if would be better to just enable it for >>>>> the supported architectures instead of relying on PI_STATIC_AND_HIDDEN. >>>> >>>> i randomly checked alpha, which fails while linking sln: >>>> >>>> elf/dl-reloc-static-pie.c:40: undefined reference to `_DYNAMIC' >>>> >>>> i think this should be possible to configure test in case others >>>> targets fail in a similar way. >>>> >>> >>> Linker must be fixed to support static PIE: >>> >>> https://sourceware.org/bugzilla/show_bug.cgi?id=22269 >>> https://sourceware.org/bugzilla/show_bug.cgi?id=22263 >>> https://sourceware.org/bugzilla/show_bug.cgi?id=21252 >> >> My question is which is the correct way to check at configure time >> for this support? Currently this patchset added the PI_STATIC_AND_HIDDEN, >> which is set by each configure snipper within glibc. > > Add and define SUPPORT_STATIC_PIE for x86 and aarch64. Other > targets can opt-in. I was expecting a way without an extra flag, but I think for now it should be suffice.