From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by sourceware.org (Postfix) with ESMTP id BE8D9384B110 for ; Thu, 11 Feb 2021 20:30:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org BE8D9384B110 Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-392-g66b1rjlNzq3JGkHmaDsSQ-1; Thu, 11 Feb 2021 15:30:36 -0500 X-MC-Unique: g66b1rjlNzq3JGkHmaDsSQ-1 Received: by mail-qk1-f198.google.com with SMTP id i11so5341953qkn.21 for ; Thu, 11 Feb 2021 12:30:36 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=Z/xPI50FY/ogpDVYVHvkHEvNSB4gi+SIlfmqaK8vxD4=; b=WRnO8aPGBsGcl+rKA11q32KndxPXIKxEBOKmkIKlQEaAon6FC125kN4RzuNkqOJps6 mUywHHsHANHdyCohqQoYz/SEYy08bYgI9c9/UfLi6c8NOnqAFoPgYuraHamegQ5hlHO/ D9oYYXH4Mmd/xJhK0eaUaL6l00Y+4IMVusJ8/TwIbU1HCVc4zWy09oyoAdschomgegt6 W7yluk158fRWmtKi2DvhhlH+/SYaCC5QRwMI7lLAix+mxjbjBKPGUtmrccHSpohx0LBb 11zd4YOT7xOAahbBHg07y7jBBzbgYj768+v0ZJn/BP74OFsh74edgOB/GP8F6n9ZN6Hn PutA== X-Gm-Message-State: AOAM5305y947z/hmY/fdThBEai+DQZIbVDRnVjEXFViPXfQ7DicTW5sT nAvxqkROcXmsWs/dn9Tn5I1qOn4jDZ+jbeDmQOHKdH8ajgvjitJdF7HhWB0LfIheGTKqal0JxPt mtiPvfWgvUX9yL7wYReXVvpdzHh2jFs0pT4hI6uDrZET5z+scUkKZ8XtmlyWbq9bWs8cLqg== X-Received: by 2002:ad4:5445:: with SMTP id h5mr9333064qvt.22.1613075435348; Thu, 11 Feb 2021 12:30:35 -0800 (PST) X-Google-Smtp-Source: ABdhPJwnMEMYP+ruU5n+cU6QEpKFunyEgUZquBc3lWbCXB8Q/6TT7uKEoWn/Pz52nSg9DtD08Kgq/w== X-Received: by 2002:ad4:5445:: with SMTP id h5mr9333048qvt.22.1613075435107; Thu, 11 Feb 2021 12:30:35 -0800 (PST) Received: from [192.168.1.16] (198-84-214-74.cpe.teksavvy.com. [198.84.214.74]) by smtp.gmail.com with ESMTPSA id m2sm4268155qtn.31.2021.02.11.12.30.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 11 Feb 2021 12:30:34 -0800 (PST) Subject: Re: [PATCH 00/10] [f]stat[fs,vfs] consolidation To: Adhemerval Zanella , Joseph Myers , DJ Delorie Cc: libc-alpha@sourceware.org References: <20210208214936.1502047-1-adhemerval.zanella@linaro.org> <3196b0c2-4f41-7184-172b-4072f2cb1d35@redhat.com> <3adce52b-9de3-1551-b4ca-8172137a1a89@linaro.org> From: Carlos O'Donell Organization: Red Hat Message-ID: <71a11c1c-ac41-ea1b-2c2a-bf9ad04c7116@redhat.com> Date: Thu, 11 Feb 2021 15:30:33 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <3adce52b-9de3-1551-b4ca-8172137a1a89@linaro.org> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-5.8 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 11 Feb 2021 20:30:39 -0000 On 2/11/21 3:17 PM, Adhemerval Zanella wrote: > > > On 11/02/2021 17:13, Carlos O'Donell wrote: >> On 2/11/21 3:08 PM, Joseph Myers wrote: >>> There is now a build failure for Hurd that looks like it probably comes >>> from one of these changes. >>> >>> ../sysdeps/mach/hurd/fstatfs.c:31:24: error: 'fstatfs' aliased to undefined symbol '__fstatfs' >>> 31 | weak_alias (__fstatfs, fstatfs) >>> | ^~~~~~~ >>> ./../include/libc-symbols.h:152:26: note: in definition of macro '_weak_alias' >>> 152 | extern __typeof (name) aliasname __attribute__ ((weak, alias (#name))) \ >>> | ^~~~~~~~~ >>> ../sysdeps/mach/hurd/fstatfs.c:31:1: note: in expansion of macro 'weak_alias' >>> 31 | weak_alias (__fstatfs, fstatfs) >>> | ^~~~~~~~~~ >>> >> >> I didn't run a full bmg build for reviewing. >> >> I should though just to review such refactoring. >> >> Adhemerval, Are you able to look into this? >> > > Working on it, I forgot to fire up a hurd build for this one... DJ, /buildon build-many-glibcs ;-) -- Cheers, Carlos.