public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
* [PATCH 0/1] gd_GB: Fix typo in abbreviated "May" (bug 23152).
@ 2018-05-09 21:30 Rafal Luzynski
  2018-05-09 21:34 ` [PATCH 1/1] " Rafal Luzynski
  0 siblings, 1 reply; 4+ messages in thread
From: Rafal Luzynski @ 2018-05-09 21:30 UTC (permalink / raw)
  To: libc-alpha

The body of the patch is probably correct because it comes from CLDR, [1]
and it has already been confirmed by two language experts, one in
Bugzilla [2] and another one in a private mail.  However, I'll appreciate
a review of metadata (commit comment etc.)

Since we are in May now and the bug may lead to the confusion of the users
(May is spelled as March) I'd like to commit soon and then backport the
patch to 2.27 stable branch.

Regards,

Rafal


[1] http://st.unicode.org/cldr-apps/v#/gd/Gregorian/
[2] https://sourceware.org/bugzilla/show_bug.cgi?id=23152

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH 1/1] gd_GB: Fix typo in abbreviated "May" (bug 23152).
  2018-05-09 21:30 [PATCH 0/1] gd_GB: Fix typo in abbreviated "May" (bug 23152) Rafal Luzynski
@ 2018-05-09 21:34 ` Rafal Luzynski
  2018-05-10 15:54   ` Carlos O'Donell
  0 siblings, 1 reply; 4+ messages in thread
From: Rafal Luzynski @ 2018-05-09 21:34 UTC (permalink / raw)
  To: libc-alpha

	[BZ #23152]
	* localedata/locales/gd_GB (abmon): Fix typo in May:
	"Mhàrt" -> "Cèit".  Adjust the comment according to the change.
---
 localedata/locales/gd_GB | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/localedata/locales/gd_GB b/localedata/locales/gd_GB
index d35efa8..d08644c 100644
--- a/localedata/locales/gd_GB
+++ b/localedata/locales/gd_GB
@@ -81,12 +81,12 @@ mon  "dhen Fhaoilleach";/
      "dhen D<U00E0>mhair";/
      "dhen t-Samhain";/
      "dhen D<U00F9>bhlachd"
-% Faoi, Gearr, Màrt, Gibl, Mhàrt, Ògmh, Iuch, Lùna, Sult, Dàmh, Samh, Dùbh
+% Faoi, Gearr, Màrt, Gibl, Cèit, Ògmh, Iuch, Lùna, Sult, Dàmh, Samh, Dùbh
 abmon         "Faoi";/
        "Gearr";/
        "M<U00E0>rt";/
        "Gibl";/
-       "Mh<U00E0>rt";/
+       "C<U00E8>it";/
        "<U00D2>gmh";/
        "Iuch";/
        "L<U00F9>na";/
-- 
2.7.5

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH 1/1] gd_GB: Fix typo in abbreviated "May" (bug 23152).
  2018-05-09 21:34 ` [PATCH 1/1] " Rafal Luzynski
@ 2018-05-10 15:54   ` Carlos O'Donell
  2018-05-10 22:25     ` Rafal Luzynski
  0 siblings, 1 reply; 4+ messages in thread
From: Carlos O'Donell @ 2018-05-10 15:54 UTC (permalink / raw)
  To: Rafal Luzynski, libc-alpha

On 05/09/2018 05:34 PM, Rafal Luzynski wrote:
> 	[BZ #23152]
> 	* localedata/locales/gd_GB (abmon): Fix typo in May:
> 	"Mhàrt" -> "Cèit".  Adjust the comment according to the change.
> ---
>  localedata/locales/gd_GB | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

This is correct. Mhàrt is actually the morphologically changed Màrt
when used in a correspondence format e.g. dhen Mhàrt, which I don't
think we have any way to express. Either way it's incorrect in the
locale today and needs fixing. This patch looks good to me.

OK to checkin.

Reviewed-by: Carlos O'Donell <carlos@redhat.com>

> diff --git a/localedata/locales/gd_GB b/localedata/locales/gd_GB
> index d35efa8..d08644c 100644
> --- a/localedata/locales/gd_GB
> +++ b/localedata/locales/gd_GB
> @@ -81,12 +81,12 @@ mon  "dhen Fhaoilleach";/
>       "dhen D<U00E0>mhair";/
>       "dhen t-Samhain";/
>       "dhen D<U00F9>bhlachd"
> -% Faoi, Gearr, Màrt, Gibl, Mhàrt, Ògmh, Iuch, Lùna, Sult, Dàmh, Samh, Dùbh
> +% Faoi, Gearr, Màrt, Gibl, Cèit, Ògmh, Iuch, Lùna, Sult, Dàmh, Samh, Dùbh
>  abmon         "Faoi";/
>         "Gearr";/
>         "M<U00E0>rt";/
>         "Gibl";/
> -       "Mh<U00E0>rt";/
> +       "C<U00E8>it";/
>         "<U00D2>gmh";/
>         "Iuch";/
>         "L<U00F9>na";/
> 


-- 
Cheers,
Carlos.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH 1/1] gd_GB: Fix typo in abbreviated "May" (bug 23152).
  2018-05-10 15:54   ` Carlos O'Donell
@ 2018-05-10 22:25     ` Rafal Luzynski
  0 siblings, 0 replies; 4+ messages in thread
From: Rafal Luzynski @ 2018-05-10 22:25 UTC (permalink / raw)
  To: libc-alpha, Carlos O'Donell

10.05.2018 17:54 Carlos O'Donell <carlos@redhat.com> wrote:
> [...]
> OK to checkin.
>
> Reviewed-by: Carlos O'Donell <carlos@redhat.com>

Thank you, Carlos.  Pushed to master.

Regards,

Rafal

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2018-05-10 22:25 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-09 21:30 [PATCH 0/1] gd_GB: Fix typo in abbreviated "May" (bug 23152) Rafal Luzynski
2018-05-09 21:34 ` [PATCH 1/1] " Rafal Luzynski
2018-05-10 15:54   ` Carlos O'Donell
2018-05-10 22:25     ` Rafal Luzynski

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).