From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <libc-alpha-return-74145-listarch-libc-alpha=sources.redhat.com@sourceware.org>
Received: (qmail 15074 invoked by alias); 28 Oct 2016 02:23:22 -0000
Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <libc-alpha.sourceware.org>
List-Subscribe: <mailto:libc-alpha-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/libc-alpha/>
List-Post: <mailto:libc-alpha@sourceware.org>
List-Help: <mailto:libc-alpha-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: libc-alpha-owner@sourceware.org
Received: (qmail 15014 invoked by uid 89); 28 Oct 2016 02:23:20 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-1.2 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_DNSWL_LOW,RCVD_IN_SORBS_SPAM autolearn=no version=3.3.2 spammy=Hx-languages-length:990
X-HELO: mail-qk0-f174.google.com
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20130820;
        h=x-gm-message-state:subject:to:references:cc:from:organization
         :message-id:date:user-agent:mime-version:in-reply-to
         :content-transfer-encoding;
        bh=7cDUNz6w8SlB/5Flenb4yPRbgVJpcEUnUHRYQszjAB0=;
        b=eWQ92YrMgejAExGmx0HPS7AAvQWj+AJcnkXDJbVMxAWGI85u4NCvjSqAueqrvBnknZ
         TFByYv8z4lyaCdwD8UTWf/svn6WFukxzLogEUKumYj2sgMEWd9WGrTIwb+VtD+8vwnTO
         5d1u4Ckcaizp8jz5JvcTBPks4lRN44ZNCCgqI6LaLPRSLx78jicX51uZOOH1S4tDApyO
         I0cxTMCcVdxwBN3NGPbbYzj/7OUm45qS+3aasUcj+t4SmMswNlmyGdJpHu6sZRD3sfgF
         WRzDd6C+5zWaXDwSDHMvoVYWSGEikX3elN7Qvvpi8OxXVyiJvlg4dfXH2apg3IhJPxFK
         3Ssw==
X-Gm-Message-State: ABUngvfknvEvjG6dmFgOhq7NroJ+NNTsaRB2M8k2ex/PsJSlJij9wz+jryNWPrrKHZNzQ0jL
X-Received: by 10.55.129.6 with SMTP id c6mr9827824qkd.4.1477621397553;
        Thu, 27 Oct 2016 19:23:17 -0700 (PDT)
Subject: Re: [PATCH] Fix i486 builds with gcc 5.3
To: Joseph Myers <joseph@codesourcery.com>
References: <b10e2136-4d2a-e1aa-5d82-ecb07bbbeef6@redhat.com>
 <alpine.DEB.2.20.1610272028270.22353@digraph.polyomino.org.uk>
Cc: GNU C Library <libc-alpha@sourceware.org>
From: Carlos O'Donell <carlos@redhat.com>
Message-ID: <730c76eb-c0eb-008f-a4ee-b540e392bbd5@redhat.com>
Date: Fri, 28 Oct 2016 02:23:00 -0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.2.0
MIME-Version: 1.0
In-Reply-To: <alpine.DEB.2.20.1610272028270.22353@digraph.polyomino.org.uk>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
X-SW-Source: 2016-10/txt/msg00505.txt.bz2

On 10/27/2016 04:30 PM, Joseph Myers wrote:
> On Thu, 27 Oct 2016, Carlos O'Donell wrote:
> 
>> I have specifically chosen to narrow down the warning suppression to
>> gcc 5.3 because I'm not sure exactly how wide-spread the warnings is and
>> I'd rather be conservative. Others who run into the same error can expand
>> the case to gcc 5 if we see a pattern of failures.
> 
> The version number in DIAG_IGNORE_NEEDS_COMMENT is not a restriction on 
> where the warning is suppressed, it's for documentation purposes only, the 
> most recent version known to need the suppression (so any such calls 
> naming a version older than the oldest now supported for building glibc 
> are appropriate for review to see if they are still needed).
 
Thanks. I mis-remembered that we did something with that number.

I'm going to drop this patch in favour of another one that actually fixes
all the issues compiling with -Os (unrelated to i486).

-- 
Cheers,
Carlos.