From: Adhemerval Zanella <adhemerval.zanella@linaro.org>
To: Florian Weimer <fweimer@redhat.com>
Cc: Adhemerval Zanella via Libc-alpha <libc-alpha@sourceware.org>
Subject: Re: [PATCH 1/4] Sync getcwd with gnulib
Date: Thu, 27 Aug 2020 08:33:28 -0300 [thread overview]
Message-ID: <734699ee-6a35-6fec-74a8-cb8b33bc0cc8@linaro.org> (raw)
In-Reply-To: <87k0xkz6n3.fsf@oldenburg2.str.redhat.com>
On 27/08/2020 08:10, Florian Weimer wrote:
> * Adhemerval Zanella:
>
>> On Thu, Aug 27, 2020 at 7:58 AM Florian Weimer <fweimer@redhat.com> wrote:
>>>
>>> * Adhemerval Zanella:
>>>
>>>> This specific part is not used by glibc, for LIBC my patch sets
>>>> HAVE_MINIMALLY_WORKING_GETCWD
>>>> explicit to 0. I just added to sync with gnulib implementation and
>>>> make future changes less complex
>>>> (and it also checks if gnulib code to disable the LIBC part is working
>>>> correctly).
>>>
>>> I meant: Is anything of this used on Hurd at all? I don't think so.
>>
>> No, Hurd re implements getcwd.c. I personally would prefer to get
>> streamline version without all the clutter required to build on all
>> the platforms gnulib support, but my impression from other gnulib code
>> sync was that we should avoid it.
>
> Hmm. Maybe I will give this a try and see how much code is left after
> the cleanup. This shouldn't block the current sync if you want to go
> ahead with it.
The io/getcwd-system.os text size from the last patch in this set is 1439
on x86_64. I think resulting size reduction possible on ld.so would
something like that.
prev parent reply other threads:[~2020-08-27 11:33 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-26 21:02 Adhemerval Zanella
2020-08-26 21:02 ` [PATCH 2/4] linux: Remove __ASSUME_ATFCTS Adhemerval Zanella
2020-08-26 21:02 ` [PATCH 3/4] Use LFS readdir in generic POSIX getcwd [BZ# 22899] Adhemerval Zanella
2020-08-27 9:58 ` Florian Weimer
2020-08-26 21:02 ` [PATCH 4/4] io: Reorganize the getcwd implementation Adhemerval Zanella
2020-08-26 22:39 ` Paul Eggert
2020-08-27 12:35 ` Adhemerval Zanella
2020-08-27 13:21 ` Florian Weimer
2020-08-27 13:40 ` Adhemerval Zanella
2020-08-27 17:29 ` Adhemerval Zanella
2020-08-27 19:20 ` [PATCH v2] " Adhemerval Zanella
2020-08-27 23:44 ` Paul Eggert
2020-08-31 18:27 ` Adhemerval Zanella
2020-08-26 22:39 ` [PATCH 1/4] Sync getcwd with gnulib Paul Eggert
2020-08-27 11:07 ` Adhemerval Zanella
2020-08-27 8:14 ` Florian Weimer
2020-08-27 10:53 ` Adhemerval Zanella
2020-08-27 10:58 ` Florian Weimer
2020-08-27 11:06 ` Adhemerval Zanella
2020-08-27 11:10 ` Florian Weimer
2020-08-27 11:33 ` Adhemerval Zanella [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=734699ee-6a35-6fec-74a8-cb8b33bc0cc8@linaro.org \
--to=adhemerval.zanella@linaro.org \
--cc=fweimer@redhat.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).