From: Carlos O'Donell <carlos@redhat.com>
To: "H.J. Lu" <hjl.tools@gmail.com>,
Florian Weimer <fweimer@redhat.com>,
GNU C Library <libc-alpha@sourceware.org>
Subject: Re: V2 [PATCH] x86: Add tst-get-cpu-features-static to $(tests) [BZ #23458]
Date: Mon, 30 Jul 2018 20:34:00 -0000 [thread overview]
Message-ID: <73c98be5-ce50-557b-2cd3-0e6877ad4a06@redhat.com> (raw)
In-Reply-To: <20180729141956.GA9314@gmail.com>
On 07/29/2018 10:19 AM, H.J. Lu wrote:
> On Fri, Jul 27, 2018 at 02:41:23PM -0700, H.J. Lu wrote:
>> On Fri, Jul 27, 2018 at 2:14 PM, Florian Weimer <fweimer@redhat.com> wrote:
>>> On 07/27/2018 10:38 PM, H.J. Lu wrote:
>>>>
>>>> -tests += tst-get-cpu-features
>>>> +# NB: All tests should be added to $(tests) and all static tests should
>>>> +# be added to $(tests-static).
>>>> +tests += tst-get-cpu-features tst-get-cpu-features-static
>>>
>>>
>>> Why the comment? What makes this instance so special to warrant one?
>>>
>>
>> I can take out the comment.
>>
>
> Here is the updated patch. OK for master?
OK for master.
Reviewed-by: Carlos O'Donell <carlos@redhat.com>
> Thanks.
>
> H.J.
> ---
> All tests should be added to $(tests).
>
> [BZ #23458]
> * sysdeps/x86/Makefile (tests): Add tst-get-cpu-features-static.
> ---
> sysdeps/x86/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sysdeps/x86/Makefile b/sysdeps/x86/Makefile
> index 672bb19489..337b0b63dc 100644
> --- a/sysdeps/x86/Makefile
> +++ b/sysdeps/x86/Makefile
> @@ -5,7 +5,7 @@ endif
> ifeq ($(subdir),elf)
> sysdep-dl-routines += dl-get-cpu-features
>
> -tests += tst-get-cpu-features
> +tests += tst-get-cpu-features tst-get-cpu-features-static
> tests-static += tst-get-cpu-features-static
> endif
>
>
--
Cheers,
Carlos.
prev parent reply other threads:[~2018-07-30 20:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-27 20:38 H.J. Lu
2018-07-27 21:14 ` Florian Weimer
2018-07-27 21:41 ` H.J. Lu
2018-07-29 14:20 ` V2 " H.J. Lu
2018-07-30 20:34 ` Carlos O'Donell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=73c98be5-ce50-557b-2cd3-0e6877ad4a06@redhat.com \
--to=carlos@redhat.com \
--cc=fweimer@redhat.com \
--cc=hjl.tools@gmail.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).