From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oa1-x2f.google.com (mail-oa1-x2f.google.com [IPv6:2001:4860:4864:20::2f]) by sourceware.org (Postfix) with ESMTPS id 14F293858D1E for ; Wed, 29 Mar 2023 11:54:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 14F293858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-oa1-x2f.google.com with SMTP id 586e51a60fabf-17aceccdcf6so15905870fac.9 for ; Wed, 29 Mar 2023 04:54:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1680090843; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=Svbeaa2ewl9tYnSSm0cMCDGUSwlyjXfyu+SW7mNXaqk=; b=Ub8ZFIV7Pd7HHLVi7QBG8/x7dhDQ2zgIUgXVVUksU18vJ6HXQ2my1RiDmtQ/3IOArz b5LAjEKbWSzjEc0FLwkVRt+fxEJig6uw6lX+FafP/YCk2saKOUUTHi5WTvfNd4WWSin6 sBsJzrf45sGyPozq2Fb+8RXib70JCSKXYLGaezr61aPosgruPilacFAPfVmyLX7fdHMk 9kZJRDtgvtT1X5JpyHvla4DClX9jj/thtgjUUSeAUKbUQLqTGjKUFFt6RXB7sbsf/G+Q Xh7O8wiEItXCgFiOjQdhPy2pcH5lJWSmvsjHJTMk0Tb817+z+CYl0cDpCmAdxdzbLnJ7 486A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680090843; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Svbeaa2ewl9tYnSSm0cMCDGUSwlyjXfyu+SW7mNXaqk=; b=ivJ5k4TjurWP9qNvjkXgDTvJ6bA4lZjO/mledR2q9RaCRwDr6JGDwGdd+Xoq7RVw6h 4vh6al593Dll8LzTFj/MWZ6NVT5r3iWimFk+jx0MBw1XsVIxgyTc5R6qkub+6+ZNv+ZM 2+6mYPVEN2TsDj0LXTDpWxudir92RTSqZRUjTj+DySe69/a6ZaAm7Q9acJ2/N7wkgb9q YA9YEXPUUarvMTBL5PtUh+kJfmZCQYV+4Kszlymm3eYZ2SucXsrcmoaDN0K3HZTd73Db UQeGlIuFR3ztnrWTAdBrnOOowST1agvkv0hDr6z3D0ZfNjYnyyWql2z1SEcs4qKOTTIZ OGCg== X-Gm-Message-State: AAQBX9c3GqLJdtNN+Rft3zINmp9WihPXQwTjucF5WFPrUcQdNPB/eg6f R4I458K2vpVvyG+1/d5cBRTSubkQD01kChsncn7SGA== X-Google-Smtp-Source: AKy350bfTrVW9o2o6+9AolY4JosvRtCWFci0lr5HjIqE2Ss0n/sWL5c3B6BXyTu8iHB3JBOq8Yedlg== X-Received: by 2002:a05:6871:892:b0:17f:c80c:572d with SMTP id r18-20020a056871089200b0017fc80c572dmr1405710oaq.27.1680090843064; Wed, 29 Mar 2023 04:54:03 -0700 (PDT) Received: from ?IPV6:2804:1b3:a7c1:60f9:1426:1d2d:d6b:1761? ([2804:1b3:a7c1:60f9:1426:1d2d:d6b:1761]) by smtp.gmail.com with ESMTPSA id vk10-20020a0568710e4a00b00172426ebe58sm11649555oab.27.2023.03.29.04.54.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 29 Mar 2023 04:54:02 -0700 (PDT) Message-ID: <74067409-32ed-eead-e73a-47c6c88a9473@linaro.org> Date: Wed, 29 Mar 2023 08:54:00 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH] Remove --disable-experimental-malloc option Content-Language: en-US To: DJ Delorie Cc: libc-alpha@sourceware.org References: From: Adhemerval Zanella Netto Organization: Linaro In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-12.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 28/03/23 16:41, DJ Delorie wrote: > Adhemerval Zanella writes: >> -'--disable-experimental-malloc' >> - By default, a per-thread cache is enabled in 'malloc'. While this >> - cache can be disabled on a per-application basis using tunables >> - (set glibc.malloc.tcache_count to zero), this option can be used to >> - remove it from the build completely. >> - > > Ok. Also, yay :-) > >> CPPFLAGS-malloc-debug.c += -DUSE_TCACHE=0 >> -ifeq ($(experimental-malloc),yes) >> CPPFLAGS-malloc.c += -DUSE_TCACHE=1 >> -else >> -CPPFLAGS-malloc.c += -DUSE_TCACHE=0 >> -endif > > In the future, we could default this inside malloc.c instead of doing > this in the Makefile, but it's not important now. Ok. > >> diff --git a/manual/install.texi b/manual/install.texi >> index 260f8a5c82..cb76fbd28f 100644 >> --- a/manual/install.texi >> +++ b/manual/install.texi >> @@ -292,12 +292,6 @@ This option is for hackers and distributions experimenting with >> independently-maintained implementations of libcrypt. It may become >> the default in a future release. >> >> -@item --disable-experimental-malloc >> -By default, a per-thread cache is enabled in @code{malloc}. While >> -this cache can be disabled on a per-application basis using tunables >> -(set glibc.malloc.tcache_count to zero), this option can be used to >> -remove it from the build completely. >> - > > LGTM. > Reviewed-by: DJ Delorie > Thanks, I will add a NEW entry on deprecated and removed features: * The --disable-experimental-malloc is no longer available. The per-thread cache can still be disable per-application using tunables (glibc.malloc.tcache_count set to zero).