public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Adhemerval Zanella Netto <adhemerval.zanella@linaro.org>
To: Askar Safin <safinaskar@zohomail.com>, carlos@redhat.com
Cc: libc-alpha@sourceware.org, dalias@libc.org
Subject: Re: [PATCH] trivial doc fix: remove weird phrase "syscall takes zero to five arguments"
Date: Mon, 12 Feb 2024 14:13:15 -0300	[thread overview]
Message-ID: <7444508c-eaa3-4b75-bba0-b32aaf1e4f68@linaro.org> (raw)
In-Reply-To: <20240212170036.410-2-safinaskar@zohomail.com>



On 12/02/24 13:48, Askar Safin wrote:
> "number of arguments, from zero to five" is wrong, because on Linux maximal number
> of arguments is 6, not 5. Also, maximal number of arguments is kernel-dependent,
> so let's not include it here at all.

mips o32 supports 7 arguments, but I think this is the only supported
kABI that allows it (csky also have INTERNAL_SYSCALL_RAW7, but I am
not sure it really uses this macro for any syscall).

> 
> Moreover, "Each kind of system call has a definite number of arguments" is questionable.
> Think about SYS_open on Linux, which takes 2 or 3 arguments. Or SYS_clone on Linux x86_64, which
> takes 2 to 5 arguments. So I propose to fully remove this sentence.
> 
> Signed-off-by: Askar Safin <safinaskar@zohomail.com>

LGTM, thanks.

Reviewed-by: Adhemerval Zanella  <adhemerval.zanella@linaro.org>

> ---
> 
> Again: yes, I give up pushing my "syscall_no_errno".
> But while I was writing "syscall_no_errno" patch I noticed this manual error,
> so I submit it.
> 
>  manual/startup.texi | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/manual/startup.texi b/manual/startup.texi
> index 9bf24123f5..96a7a472bb 100644
> --- a/manual/startup.texi
> +++ b/manual/startup.texi
> @@ -727,8 +727,7 @@ identified by a number.  Macros for all the possible system call numbers
>  are defined in @file{sys/syscall.h}
>  
>  The remaining arguments are the arguments for the system call, in
> -order, and their meanings depend on the kind of system call.  Each kind
> -of system call has a definite number of arguments, from zero to five.
> +order, and their meanings depend on the kind of system call.
>  If you code more arguments than the system call takes, the extra ones to
>  the right are ignored.
>  

      reply	other threads:[~2024-02-12 17:13 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-12 16:48 Askar Safin
2024-02-12 17:13 ` Adhemerval Zanella Netto [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7444508c-eaa3-4b75-bba0-b32aaf1e4f68@linaro.org \
    --to=adhemerval.zanella@linaro.org \
    --cc=carlos@redhat.com \
    --cc=dalias@libc.org \
    --cc=libc-alpha@sourceware.org \
    --cc=safinaskar@zohomail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).