From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from bonobo.cedar.relay.mailchannels.net (bonobo.cedar.relay.mailchannels.net [23.83.210.22]) by sourceware.org (Postfix) with ESMTPS id 99173387688C for ; Fri, 30 Jun 2023 15:33:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 99173387688C Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=gotplt.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gotplt.org X-Sender-Id: dreamhost|x-authsender|siddhesh@gotplt.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 28242341BFA; Fri, 30 Jun 2023 15:33:06 +0000 (UTC) Received: from pdx1-sub0-mail-a286.dreamhost.com (unknown [127.0.0.6]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 177A13420C3; Fri, 30 Jun 2023 15:33:05 +0000 (UTC) ARC-Seal: i=1; s=arc-2022; d=mailchannels.net; t=1688139185; a=rsa-sha256; cv=none; b=ygPfkkmkIxqJuLBuDT+A6Oq+JFn84IVSOPBqjJBf9O8nhyoxYx03Q6eUKkzFVhffPtyA2u PPvQg7DkHjEUFMy5XPE6ZgA9/MD1fc2WvJzMzobT2hRHoGN6gNp0G/nhjcmql+IMQArMJC S0JG4S4iXbBFw6txUhR80XLk31Rby3oUvbPxBCcGRMVWw5eRfb3zHdn5FD8p5FJCN7MTyQ PGjnLQIaGSDI1qyxYOGwJoqzscqM/dfM/mhYLC+6Yg2e+IFHmyLqIsEGNUst+Sy/jepQO4 jnnVrqNmc6vviVCFtoIxEDY73osFtwI/7vMN9pCd9qSQHOqx8C4jkKz94igumQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=mailchannels.net; s=arc-2022; t=1688139185; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=DvyoOs7+xGrYNCOlgNYmAqc9VrtHzjTn7fcEzegFN2Y=; b=E10lWsOBJQ45qQUjOAO/GN7IHkMe/qyXoa5V9S4LLl9mhlba6Ui9D4kUsa+Q9SpZgDk/Sy PSvUh/aeRMWuwcvoDjY6L2vZuHHPVss1Zn+iyoXSHvPES///fT0j7nDDX5MIydkit4jZ1+ r8XJ4aXxqgGI2r7Iv34VFbqg84DpGleZ1M7k5SQzKPU1ZdOJEVKILvqIbSMfhoxFyxPsWT jiGdCAoRTcLve9Y8kWxthXNcLn4uTmi1x5ULWq6/O+d4Os+Fwc3JO5mJigCQ3Lb/33HWlg 1jg/F7xGfqldhnb6YPmpLnYxFSlo2DavS6jplr9/t9uaFiwTho1pqaIRIGHAOA== ARC-Authentication-Results: i=1; rspamd-9fcc56855-bx8pc; auth=pass smtp.auth=dreamhost smtp.mailfrom=siddhesh@gotplt.org X-Sender-Id: dreamhost|x-authsender|siddhesh@gotplt.org X-MC-Relay: Good X-MailChannels-SenderId: dreamhost|x-authsender|siddhesh@gotplt.org X-MailChannels-Auth-Id: dreamhost X-Eyes-Absorbed: 2f6dadf5117a11c3_1688139185951_1938461269 X-MC-Loop-Signature: 1688139185951:1082677235 X-MC-Ingress-Time: 1688139185951 Received: from pdx1-sub0-mail-a286.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384) by 100.127.59.48 (trex/6.9.1); Fri, 30 Jun 2023 15:33:05 +0000 Received: from [192.168.0.182] (bras-vprn-toroon4834w-lp130-09-174-91-45-44.dsl.bell.ca [174.91.45.44]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) (Authenticated sender: siddhesh@gotplt.org) by pdx1-sub0-mail-a286.dreamhost.com (Postfix) with ESMTPSA id 4Qszq44flBz7M; Fri, 30 Jun 2023 08:33:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gotplt.org; s=dreamhost; t=1688139184; bh=DvyoOs7+xGrYNCOlgNYmAqc9VrtHzjTn7fcEzegFN2Y=; h=Date:Subject:To:From:Content-Type:Content-Transfer-Encoding; b=eopRmy/KnWM8r85JiS8Ob8tL15RKVRIAOy0L2vByuF8A6hVp3/s4T/IrWOdG0lyjn qBuQ6MRgv6Fx6ztktWV27MjQvBJWruZopqJzgJAtIiSlU5TwngsN35FgZcEVA8pmtz fjDh4+kD9kq/pv9QK2JApXChVDXx//oEhobO+UYufKJN/uLv69z5SAasQ6qiInROvP Fs0Y3r4egdTInKApmHF/8snu4wa2A1Kmcg0P+d9Yfl/YKg2TRTjerp2bJI+KTQ+1Vp nhs9aerSBl5aPNgDB2vD2aO6USogkW5qRJGEZq/z6/4dWot2bjBDwl7cpldAnhatUf pvKlmAVcC+I9g== Message-ID: <7450fb56-8d3a-af7f-cff9-fb4dacd8c552@gotplt.org> Date: Fri, 30 Jun 2023 11:33:03 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH v3 15/16] sysdeps/ieee754/ldbl-128ibm-compat: Fix warn unused result Content-Language: en-US To: =?UTF-8?B?RnLDqWTDqXJpYyBCw6lyYXQ=?= , libc-alpha@sourceware.org References: <20230628084246.778302-1-fberat@redhat.com> <20230628084246.778302-16-fberat@redhat.com> From: Siddhesh Poyarekar In-Reply-To: <20230628084246.778302-16-fberat@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-3037.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2023-06-28 04:42, Frédéric Bérat wrote: > Return value from *scanf and *asprintf routines are now properly checked > in test-scanf-ldbl-compat-template.c and test-printf-ldbl-compat.c. > --- > .../test-printf-ldbl-compat.c | 10 +++++---- > .../test-scanf-ldbl-compat-template.c | 21 ++++++++++--------- > 2 files changed, 17 insertions(+), 14 deletions(-) LGTM. Reviewed-by: Siddhesh Poyarekar > > diff --git a/sysdeps/ieee754/ldbl-128ibm-compat/test-printf-ldbl-compat.c b/sysdeps/ieee754/ldbl-128ibm-compat/test-printf-ldbl-compat.c > index 3c759e1427..be37af7c31 100644 > --- a/sysdeps/ieee754/ldbl-128ibm-compat/test-printf-ldbl-compat.c > +++ b/sysdeps/ieee754/ldbl-128ibm-compat/test-printf-ldbl-compat.c > @@ -30,12 +30,13 @@ do_test_call_varg (FILE *stream, const char *format, ...) > char *buffer = NULL; > char string[128]; > va_list args; > + int ret; > > printf ("%15s", "vasprintf: "); > va_start (args, format); > - vasprintf (&buffer, format, args); > + ret = vasprintf (&buffer, format, args); > va_end (args); > - if (buffer == NULL) > + if (ret == -1 || buffer == NULL) > printf ("Error using vasprintf\n"); > else > { > @@ -82,10 +83,11 @@ do_test_call_rarg (FILE *stream, const char *format, long double ld, double d) > { > char *buffer = NULL; > char string[128]; > + int ret; > > printf ("%15s", "asprintf: "); > - asprintf (&buffer, format, ld, d); > - if (buffer == NULL) > + ret = asprintf (&buffer, format, ld, d); > + if (ret == -1 || buffer == NULL) > printf ("Error using asprintf\n"); > else > { > diff --git a/sysdeps/ieee754/ldbl-128ibm-compat/test-scanf-ldbl-compat-template.c b/sysdeps/ieee754/ldbl-128ibm-compat/test-scanf-ldbl-compat-template.c > index e8da3a67f0..776c12dd16 100644 > --- a/sysdeps/ieee754/ldbl-128ibm-compat/test-scanf-ldbl-compat-template.c > +++ b/sysdeps/ieee754/ldbl-128ibm-compat/test-scanf-ldbl-compat-template.c > @@ -37,10 +37,10 @@ > ldptr = va_arg (args, long double *); \ > fptr = va_arg (args, float *); \ > va_end (args); \ > - if (*ldptr == -1 && *fptr == -2) \ > + if (*ldptr == -1 && *fptr == -2 && ret == 2) \ > printf ("OK"); \ > else \ > - printf ("ERROR (%Lf %f)", *ldptr, *fptr); \ > + printf ("ERROR (%Lf %f %d)", *ldptr, *fptr, ret); \ > printf ("\n"); > > #define CLEAR_VALUE \ > @@ -48,10 +48,10 @@ > f = 0; > > #define CHECK_VALUE \ > - if (ld == -1 && f == -2) \ > + if (ld == -1 && f == -2 && ret == 2) \ > printf ("OK"); \ > else \ > - printf ("ERROR (%Lf %f)", ld, f); \ > + printf ("ERROR (%Lf %f %d)", ld, f, ret); \ > printf ("\n"); > > static void > @@ -62,40 +62,41 @@ do_test_call (FILE *stream, CHAR *string, const CHAR *format, ...) > float *fptr; > long double *ldptr; > va_list args; > + int ret; > > CLEAR_VALUE > printf ("fscanf: "); > - FSCANF (stream, format, &ld, &f); > + ret = FSCANF (stream, format, &ld, &f); > CHECK_VALUE > > CLEAR_VALUE > printf ("scanf: "); > - SCANF (format, &ld, &f); > + ret = SCANF (format, &ld, &f); > CHECK_VALUE > > CLEAR_VALUE > printf ("sscanf: "); > - SSCANF (string, format, &ld, &f); > + ret = SSCANF (string, format, &ld, &f); > CHECK_VALUE > > CLEAR_VARGS > printf ("vfscanf: "); > va_start (args, format); > - VFSCANF (stream, format, args); > + ret = VFSCANF (stream, format, args); > va_end (args); > CHECK_VARGS > > CLEAR_VARGS > printf ("vscanf: "); > va_start (args, format); > - VSCANF (format, args); > + ret = VSCANF (format, args); > va_end (args); > CHECK_VARGS > > CLEAR_VARGS > printf ("vsscanf: "); > va_start (args, format); > - VSSCANF (string, format, args); > + ret = VSSCANF (string, format, args); > va_end (args); > CHECK_VARGS > }